gecko-dev/config
Nathan Froyd 87007ca0f2 Bug 1377157 - remove VCINSTALLDIR from cargo's environment when running in MozillaBuild; r=ted.mielczarek
Stable Rust currently has logic similar to the following for finding the
linker on Windows:

  if VCINSTALLDIR in os.env:
    search for things in PATH
    if found, return, otherwise fallthrough

  look for MSVC installations of various kinds

For our current MozillaBuild setup where we clear out PATH prior to
invoking Cargo, this works: even though VCINSTALLDIR is set and we
(unsuccessfully) search through an empty PATH, we'll still fallback to
looking for MSVC installations.

Beta Rust has altered this search strategy:

  if VCINSTALLDIR in os.env:
    search for things in PATH
    return the result of the search, regardless of success

  look for MSVC installations of various kinds

Note that in the above logic, if VCINSTALLDIR is set, we are only going
to try looking in PATH for an appropriate linker.  Since PATH is empty
in our current MozillaBuild setup, beta Rust will therefore fail to find
the correct linker.  This failure causes numerous problems.

Since Firefox is already trying to "clean" the environment that Cargo is
invoked in, we should work a little bit harder by unsetting VCINSTALLDIR
entirely, and simply force Rust to search for known MSVC installations.
Making this change makes stable and beta Rust behave identically.

(We don't have to worry about this distinction in automation, because
the "cleaning" code is only activated when we detect a MozillaBuild
shell.)
2017-06-29 13:41:57 -04:00
..
Moz
external Bug 1353650 - Part 4: Update to ICU 59. rs=Waldo 2017-04-19 07:00:05 -07:00
faster Bug 1319345 - application.ini fixup for artifact build bustage; r=gps 2016-11-22 14:50:28 -08:00
makefiles Bug 1370695 - Remove build system code handling binary components. r=glandium 2017-06-13 16:01:45 -07:00
tests Bug 1304508 - Remove makefile mkdir testing; r=ted 2017-04-26 13:27:37 -07:00
Makefile.in Bug 1338608 - Move check_mkdir.tpy into a python unittest manifest; r=chmanchester 2017-02-02 17:49:11 -05:00
MozZipFile.py
android-common.mk Bug 1258760 - Allow re-signing already signed APK files. r=gps 2016-03-15 16:01:44 -07:00
autoconf-js.mk.in
autoconf.mk.in
baseconfig.mk Bug 1338559 - Use the tier system to recurse for 'make check'; r=glandium 2017-02-03 16:47:28 -05:00
check_js_msg_encoding.py Bug 1361172 - Rewrite code for finding files in VCS checkout; r=glandium 2017-05-18 16:06:49 -07:00
check_js_opcode.py Bug 1343417 - Verify bytecode documentation in js/src/vm/Opcodes.h in make check. r=nbp 2017-04-03 10:14:38 +09:00
check_macroassembler_style.py Bug 1376921 - Remove mips from the list of checked MacroAssemblers. r=tcampbell 2017-06-29 18:49:10 +00:00
check_source_count.py
check_spidermonkey_style.py Bug 1361172 - Rewrite code for finding files in VCS checkout; r=glandium 2017-05-18 16:06:49 -07:00
check_vanilla_allocations.py
config.mk Bug 1355671 - Add optimization flags to HOST_CXXFLAGS similarly to HOST_CFLAGS. r=gps 2017-04-07 17:03:21 +09:00
createprecomplete.py
doxygen.cfg.in
emptyvars-js.mk.in
emptyvars.mk.in
expandlibs.py
expandlibs_config.py Bug 1353541 Fix rustc in MinGW build r=froydnj,ted 2017-04-26 12:08:59 -05:00
expandlibs_exec.py
expandlibs_gen.py Bug 1304815 - rearrange Rust crate structure for newer Rust releases; r=ted.mielczarek 2016-10-15 18:16:13 -04:00
find_OOM_errors.py
gcc-stl-wrapper.template.h Bug 1269171 - Change how mozalloc.h is hooked in STL wrappers. r=froydnj 2016-05-22 08:32:40 +09:00
gcc_hidden.h
install.bat
link.py Bug 1303227 - Wrap libxul.so linker to prevent getting the linking process killed; r=glandium 2016-09-20 17:58:34 -07:00
make-stl-wrappers.py Bug 1269171 - Change how mozalloc.h is hooked in STL wrappers. r=froydnj 2016-05-22 08:32:40 +09:00
milestone.txt Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2017-06-12 13:48:15 +01:00
moz.build Bug 1338608 - Move check_mkdir.tpy into a python unittest manifest; r=chmanchester 2017-02-02 17:49:11 -05:00
mozunit.py bug 1280326 - followup fix to make MockedOpen really case-insensitive on Windows. r=jmaher 2016-07-01 07:15:23 -04:00
msvc-stl-wrapper.template.h Bug 1376057 - Replace MSVC wrappers with std::exception::_Set_raise_handler. - r=froydnj 2017-06-27 11:51:34 -07:00
nsinstall.c Backed out changeset 349a316ed0f7 (bug 1316735) for build packaging failures 2016-12-13 10:48:40 -08:00
nsinstall.py Bug 1293234 - Use octal notation for permission modes in the build system; r=gps 2016-08-08 13:45:17 +02:00
pathsub.c
pathsub.h
printconfigsetting.py
printprereleasesuffix.py
pythonpath.py
rebuild_check.py
recurse.mk Bug 1361418 - Remove Java Addons from Firefox for Android. r=sebastian 2017-05-02 11:49:16 -07:00
rules.mk Bug 1377157 - remove VCINSTALLDIR from cargo's environment when running in MozillaBuild; r=ted.mielczarek 2017-06-29 13:41:57 -04:00
static-checking-config.mk Bug 1316545 part 4 - Run clang.exe instead of clang-cl.exe for loading the plugin. r=ehsan,glandium 2016-11-22 14:20:58 +08:00
stl-headers Bug 1350262 - implement prime rehash policy compat for unordered_map and unordered_set in libstdc++. r=glandium 2017-05-09 22:15:18 -04:00
string-format.js
system-headers Bug 1353650 - Part 3.1: Add unicode/unistr.h to system-headers to unbreak system-ICU builds. r=glandium 2017-05-11 01:30:09 -07:00
version.mk
version_win.pl