9ef53fde87
This bug occurs under the following conditions: - The clip chain instance has multiple clip items. - The first item in the clip chain is a clip rectangle, with: - ClipMode::Clip - Is in the same coordinate system as the primitive. In this case, the code would skip adding the clip rect to the mask (due to the same coord system). However, the logic that determines whether to render subsequent masks with blend disabled or multiplicative blend was only considering the index of the clip item in the clip chain. In this case, these masks would get added to the blend enabled batches, but the first clip mask which would have written the initial mask values was skipped. The end result was that the subsequent clip masks would be blending with uninitialized render target contents from a previous frame. This patch changes the logic to track when the first clip mask has actually been added to the batch, rather than relying on the index. In this case, it means that the rounded rect mask will get drawn in the blend disabled path, writing the correct mask values without blending with the existing render target contents. Differential Revision: https://phabricator.services.mozilla.com/D20590 --HG-- extra : moz-landing-system : lando |
||
|---|---|---|
| .. | ||
| ci-scripts | ||
| debugger | ||
| direct-composition | ||
| examples | ||
| webrender | ||
| webrender_api | ||
| webrender_build | ||
| wr_malloc_size_of | ||
| wrench | ||
| .gitignore | ||
| .taskcluster.yml | ||
| Cargo.lock | ||
| Cargo.toml | ||
| LICENSE | ||
| README.md | ||
| appveyor.yml | ||
| rustfmt.toml | ||
| servo-tidy.toml | ||
README.md
WebRender
GPU renderer for the Web content, used by Servo.
Note that the canonical home for this code is in gfx/wr folder of the mozilla-central repository at https://hg.mozilla.org/mozilla-central. The Github repository at https://github.com/servo/webrender should be considered a downstream mirror, although it contains additional metadata (such as Github wiki pages) that do not exist in mozilla-central. Pull requests against the Github repository are still being accepted, although once reviewed, they will be landed on mozilla-central first and then mirrored back. If you are familiar with the mozilla-central contribution workflow, filing bugs in Bugzilla and submitting patches there would be preferred.
Update as a Dependency
After updating shaders in WebRender, go to servo and:
- Go to the servo directory and do ./mach update-cargo -p webrender
- Create a pull request to servo
Use WebRender with Servo
To use a local copy of WebRender with servo, go to your servo build directory and:
- Edit Cargo.toml
- Add at the end of the file:
[patch."https://github.com/servo/webrender"]
"webrender" = { path = "<path>/webrender" }
"webrender_api" = { path = "<path>/webrender_api" }
where <path> is the path to your local copy of WebRender.
- Build as normal
Documentation
The Wiki has a few pages describing the internals and conventions of WebRender.
Testing
Tests run using OSMesa to get consistent rendering across platforms.
Still there may be differences depending on font libraries on your system, for example.
See this gist for how to make the text tests useful in Fedora, for example.