gecko-dev/toolkit
harry 43ec533571 Bug 1594132 - Move background-color rules so they do not appear under appearance rules, enabling sidebar vibrancy. r=ntim,dao
`appearance` CSS rules allow elements to take on system appearance. For UI elements that we want to take on system styling, we set `appearance: auto` combined with platform-specific rules like `-moz-default-appearance: -moz-mac-vibrant-titlebar-light;`

macOS sidebar vibrancy broke because a background-color was being applied to `root`. That colour appeared under elements with `appearance: auto` set, so we wouldn't see the platform-specific styling. This patch moves the root background-color to `#navigator-toolbox`, so that it does not appear under `#sidebar-box`.

We still want a background colour applied to sidebars when a lwtheme includes one. We only want `appearance: auto` applied to sidebars when the active theme does not have sidebar styling rules. That's why `#sidebar-box:not(:-moz-lwtheme)` is changed to `#sidebar-box:not([lwt-sidebar])`.

This patch also removes the rule
```
:root:-moz-lwtheme {
  appearance: none;
}
```
from osx/global/global.css. There's no corresponding addition of a `#navigator-toolbox { appearance:none; }` rule because that rule already exists in [osx/browser.css](https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/browser/themes/osx/browser.css#45).

Differential Revision: https://phabricator.services.mozilla.com/D104416
2021-02-23 15:03:45 +00:00
..
actors Bug 1679174 - Filter out videos with NaN duration. r=mtigley 2021-02-19 01:51:25 +00:00
components Bug 1594132 - Move background-color rules so they do not appear under appearance rules, enabling sidebar vibrancy. r=ntim,dao 2021-02-23 15:03:45 +00:00
content Bug 1694059 - Rename various nnt prefs. r=spohl,mstange 2021-02-22 20:05:35 +00:00
crashreporter Backed out changeset 7c67e3cb1ded (bug 1403348) for causing xpc failures in AsyncShutdown. CLOSED TREE 2021-02-23 02:17:08 +02:00
docs Bug 1665854 - fx doc: Various improvements + configuration + fixes in the doc r=firefox-build-system-reviewers,rstewart 2020-09-22 06:26:17 +00:00
library Bug 1670538 - Use an allow-list in RUSTC_BOOTSTRAP for rustc >= 1.50.0. r=firefox-build-system-reviewers,andi,sheehan,mhentges 2021-02-17 21:47:28 +00:00
locales Bug 1669732, add error message for invalid number of copies r=mstriemer,fluent-reviewers 2021-02-18 16:23:54 +00:00
modules Bug 1665942 - Collect userContextId from tab in _collectBaseTabData and stop collecting it in the session history collection; r=nika,geckoview-reviewers,agi 2021-02-23 08:28:57 +00:00
mozapps Bug 1689230 - Simplify gViewController API methods. r=rpl 2021-02-22 22:44:03 +00:00
profile Bug 1693561 - avoid stat'ing profiles.ini twice during startup, r=mossop. 2021-02-22 20:48:14 +00:00
system Bug 1692391 - Rename NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK macros, replacing ABORT with IGNORE. These macros just log the exception and move on, without aborting. r=haik 2021-02-16 22:55:21 +00:00
themes Bug 1594132 - Move background-color rules so they do not appear under appearance rules, enabling sidebar vibrancy. r=ntim,dao 2021-02-23 15:03:45 +00:00
xre Bug 1691894 - Simplify uses of WithEntryHandle that only use OrInsert(With) by using GetOrInsertWith. r=xpcom-reviewers,necko-reviewers,jgilbert,nika 2021-02-22 12:07:46 +00:00
.eslintrc.js
l10n-registry.manifest
moz.build Bug 1687239 part 3 - Remove the PluginProblem UA Widget and related CSS pseudos. r=emilio 2021-01-25 11:53:57 +00:00
moz.configure Bug 1693689 - Avoid bootstrapping toolchains unless needed. r=firefox-build-system-reviewers,andi,sheehan,mhentges 2021-02-23 03:34:04 +00:00
toolkit.mozbuild Bug 1664898 - move media/mtransport to media/transport. r=ng 2020-09-22 21:43:49 +00:00