gecko-dev/docshell/shistory
Nicholas Nethercote cd3fc14877 Bug 1488321 - Improve GetTransactionAtIndex() result checking. r=nika
Specifically:

- Check the nsresult consistently, but don't check (unnecessarily) for null on
  success.

- In AddEntry(), move GetTransactionAtIndex() before all state-changing
  operations, so we don't end up with partial state updates upon failure.

- Use early returns to reduce indenting.

--HG--
extra : rebase_source : 17815f6813f024fae1cf4ec3cf1b7985ab7a2ff2
2018-09-05 08:53:28 +10:00
..
ChildSHistory.cpp Bug 1487328 - Make nsSHistory *not* implement nsIWebNavigation. r=nika 2018-09-03 09:27:37 +10:00
ChildSHistory.h Bug 1487328 - Make nsSHistory *not* implement nsIWebNavigation. r=nika 2018-09-03 09:27:37 +10:00
ParentSHistory.cpp Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot 2018-06-26 17:05:01 -07:00
ParentSHistory.h Bug 1434768 - Part 1: Add Child/ParentSHistory classes which wrap nsISHistory, r=bz 2018-04-10 17:49:44 -04:00
moz.build Bug 1487296 - Merge nsISHistoryInternal into nsISHistory. r=nika 2018-08-30 11:37:40 +10:00
nsIBFCacheEntry.idl
nsISHEntry.idl Bug 1485279 - Merge nsISHContainer into nsISHEntry. r=qdot 2018-08-22 19:20:56 +10:00
nsISHTransaction.idl Bug 1488321 - Enforce non-nullness for nsISHTransaction.sHEntry. r=nika 2018-09-05 08:53:28 +10:00
nsISHistory.idl Bug 1488321 - Improve GetTransactionAtIndex() result checking. r=nika 2018-09-05 08:53:28 +10:00
nsISHistoryListener.idl Bug 1487328 - Remove nsISHistoryListener.OnHistoryGo{Back,Forward}. r=nika 2018-09-03 09:27:37 +10:00
nsSHEntry.cpp Bug 1485279 - Merge nsISHContainer into nsISHEntry. r=qdot 2018-08-22 19:20:56 +10:00
nsSHEntry.h Bug 1485279 - Merge nsISHContainer into nsISHEntry. r=qdot 2018-08-22 19:20:56 +10:00
nsSHEntryShared.cpp Bug 1487296 - Merge nsISHistoryInternal into nsISHistory. r=nika 2018-08-30 11:37:40 +10:00
nsSHEntryShared.h Bug 894215 part 1. Change nsSHEntryShared to inherit from nsStubMutationObserver. r=smaug 2018-05-18 23:37:56 -04:00
nsSHTransaction.cpp Bug 1488321 - Enforce non-nullness for nsISHTransaction.sHEntry. r=nika 2018-09-05 08:53:28 +10:00
nsSHTransaction.h Bug 1488321 - Enforce non-nullness for nsISHTransaction.sHEntry. r=nika 2018-09-05 08:53:28 +10:00
nsSHistory.cpp Bug 1488321 - Improve GetTransactionAtIndex() result checking. r=nika 2018-09-05 08:53:28 +10:00
nsSHistory.h Bug 1488321 - Improve GetTransactionAtIndex() result checking. r=nika 2018-09-05 08:53:28 +10:00