gecko-dev/toolkit
Jared Wein ab7ca91730 Bug 1524210 - Only clear the richlistbox selection when the box itself is clicked if the richlistbox is of multiselection type. r=Gijs
There are a couple ways to fix this specific bug in Preferences. We could expand the padding up to the start border and remove the margin, though there would still exist a 1px padding on the richlistbox. Historically this code, at least for Preferences, was impossible to hit. The scrollbox couldn't get clicked because its size was defined by an inner xul:box that was the size of the richlistitems and whatever margin they had. Clicking next to the richlistitems in the Preferences before this regression was a click on the anonymous box and thus didn't clear the selection. Another potential fix could be if we added a special attribute that doesn't allow deselecting if clicking into nothing, but that seems like a band-aid that we would end up using in many other places instead of just removing this behavior.

Differential Revision: https://phabricator.services.mozilla.com/D18371

--HG--
extra : moz-landing-system : lando
2019-02-04 22:14:57 +00:00
..
actors Merge mozilla-inbound to mozilla-central. a=merge 2019-01-29 12:01:56 +02:00
components Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 2019-02-04 19:10:18 +00:00
content Bug 1524210 - Only clear the richlistbox selection when the box itself is clicked if the richlistbox is of multiselection type. r=Gijs 2019-02-04 22:14:57 +00:00
crashreporter Bug 1524194 - Do not add stack pointer to clobber list r=ted 2019-02-01 11:37:06 +00:00
forgetaboutsite Bug 1514594: Part 3 - Change ChromeUtils.import API. 2019-01-17 10:18:31 -08:00
library Backed out 6 changesets (bug 1516228) for causing bug 1523056. a=backout 2019-01-26 21:12:33 +02:00
locales Convert resetProfile.dtd to Fluent (Bug 1517307) r=jaws,flod 2019-02-03 21:33:23 +00:00
modules Bug 1524593 - nsISearchService (aka nsIBrowserSearchService, previously) refactor to be mostly an asynchronous, in preparation of WebExtension engines. r=daleharvey 2019-02-02 11:27:21 +00:00
mozapps Bug 1524407 - Cleanup of unused and unnecessary code in nsUpdateDriver.cpp. r=mhowell 2019-01-31 22:28:50 -08:00
pluginproblem Bug 1507895 - Part IV, Remove the XBL pluginProblem binding r=smaug 2019-01-26 07:51:10 +00:00
profile Bug 1455707: Detect when running an older version than previously ran with the selected profile. r=froydnj, r=mconley, r=Gijs 2019-01-30 14:56:30 -08:00
recordreplay Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 2019-02-04 19:10:18 +00:00
system Bug 1521460 - Also reformat objective-c files r=mstange,ehsan,spohl 2019-01-21 18:18:16 +01:00
themes Bug 1511381 - Prevent forced layout flush when click-to-play UI loads on page load r=mconley 2019-01-31 17:56:03 +00:00
xre Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 2019-02-04 19:10:18 +00:00
.eslintrc.js
moz.build Backed out 7 changesets (bug 1518632, bug 1463198, bug 1455707, bug 1522934, bug 1322797, bug 1474285) for build bustages at /builds/worker/workspace/build/src/toolkit/xre/nsAppRunner.cpp on a CLOSED TREE 2019-01-31 03:34:49 +02:00
moz.configure Backed out 2 changesets (bug 1515641) for Linux static-analysis bustage on a CLOSED TREE. 2019-02-02 00:55:11 +02:00
nss.configure Bug 1513134 - Detect unnecessary --help dependencies. r=firefox-build-system-reviewers,gps 2018-12-11 19:34:28 +00:00
toolkit.mozbuild Bug 1508782 - Add moz.yaml for bspatch in toolkit/mozapps/update; r=mhowell 2018-12-10 19:07:42 +00:00