mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность
gecko-dev/editor/libeditor
История
Masayuki Nakano 6b77e7ceba Bug 1772022 - Make `EditorBase::DeleteNodeWithTransaction()` return `NS_ERROR_EDITOR_DESTROYED` if so r=m_kato 
Its callers check `EditorBase::Destroyed()` with at least adding 4 lines, and
some callers do not check this important state.  So, we should make it check
`Destroyed()` at last and omit the additional error check in the caller sites.

Note that it's a virtual method, but `HTMLEditor` checks whether it's a
removable node or not.  So, we should can merge it into `EditorBase`.  This
patch does it too.

Differential Revision: https://phabricator.services.mozilla.com/D148084
 		2022-06-03 02:03:47 +00:00
..
crashtests Bug 1765156 - Part 4: Use SpecialPowers.ChromeUtils.import in editor/. r=kmag 2022-05-03 06:32:26 +00:00
tests Backed out 4 changesets (bug 1770727) for causing mochitest failures in test_bug1180105/test_access_control. CLOSED TREE 2022-05-24 17:24:40 +03:00
CSSEditUtils.cpp Bug 1766355 - part 7: Rewrite `HTMLEditor::RemoveContainerWithTransaction` with `MoveNodeTransaction` and make it stop touching `Selection` directly r=m_kato 2022-05-20 09:01:40 +00:00
CSSEditUtils.h Bug 1767386 - part 1: Make some `CSSEditUtils` methods using `GetCSSEquivalentToHTMLInlineStyleSetInternal` return error with `Result` r=m_kato 2022-05-09 06:03:21 +00:00
ChangeAttributeTransaction.cpp
…
ChangeAttributeTransaction.h Bug 1764866 - Add "mozilla/EditorForwards.h" r=m_kato 2022-04-20 14:46:16 +00:00
ChangeStyleTransaction.cpp Bug 1727844 - part 7: Make `HTMLEditor` related classes use constants in `HTMLEditUtils` to use specific character code point r=m_kato 2021-08-31 17:37:42 +00:00
ChangeStyleTransaction.h Bug 1764866 - Add "mozilla/EditorForwards.h" r=m_kato 2022-04-20 14:46:16 +00:00
CompositionTransaction.cpp Bug 1758420 - part 2: Clean up update timing of `TextComposition` r=m_kato 2022-04-21 03:37:56 +00:00
CompositionTransaction.h Bug 1764866 - Add "mozilla/EditorForwards.h" r=m_kato 2022-04-20 14:46:16 +00:00
DeleteNodeTransaction.cpp Bug 1727840 - Make `DeleteNodeTransaction` allow to create its instance for non-editable text node which was created or modified by an editor r=m_kato 2021-09-15 00:20:19 +00:00
DeleteNodeTransaction.h Bug 1764866 - Add "mozilla/EditorForwards.h" r=m_kato 2022-04-20 14:46:16 +00:00
DeleteRangeTransaction.cpp Bug 1764684 - part 2: Make editor use methods of `EditorBase` to collapse `Selection` r=m_kato 2022-04-20 14:36:52 +00:00
DeleteRangeTransaction.h Bug 1764866 - Add "mozilla/EditorForwards.h" r=m_kato 2022-04-20 14:46:16 +00:00
DeleteTextTransaction.cpp Bug 1764684 - part 2: Make editor use methods of `EditorBase` to collapse `Selection` r=m_kato 2022-04-20 14:36:52 +00:00
DeleteTextTransaction.h Bug 1764866 - Add "mozilla/EditorForwards.h" r=m_kato 2022-04-20 14:46:16 +00:00
EditAction.h Bug 1766355 - part 1: Add `MoveNodeTransaction` to handle delete node and insert node in a transaction class instance r=m_kato 2022-05-20 08:28:08 +00:00
EditAggregateTransaction.cpp
…
EditAggregateTransaction.h Bug 1764866 - Add "mozilla/EditorForwards.h" r=m_kato 2022-04-20 14:46:16 +00:00
EditTransactionBase.cpp Bug 1766355 - part 1: Add `MoveNodeTransaction` to handle delete node and insert node in a transaction class instance r=m_kato 2022-05-20 08:28:08 +00:00
EditTransactionBase.h Bug 1766355 - part 1: Add `MoveNodeTransaction` to handle delete node and insert node in a transaction class instance r=m_kato 2022-05-20 08:28:08 +00:00
EditorBase.cpp Bug 1772022 - Make `EditorBase::DeleteNodeWithTransaction()` return `NS_ERROR_EDITOR_DESTROYED` if so r=m_kato 2022-06-03 02:03:47 +00:00
EditorBase.h Bug 1772022 - Make `EditorBase::DeleteNodeWithTransaction()` return `NS_ERROR_EDITOR_DESTROYED` if so r=m_kato 2022-06-03 02:03:47 +00:00
EditorCommands.cpp Bug 1713756 - Make editor command classes treat `EditorBase` instead of `TextEditor` r=m_kato 2021-06-09 07:17:52 +00:00
EditorCommands.h Bug 1764866 - Add "mozilla/EditorForwards.h" r=m_kato 2022-04-20 14:46:16 +00:00
EditorController.cpp
…
EditorController.h
…
EditorDOMPoint.h Bug 1762115 - part 10: Make `HTMLEditor::InsertBRElement` stop touching `Selection` directly r=m_kato 2022-05-03 01:03:05 +00:00
EditorEventListener.cpp Bug 1771448 - part 4: Rename `HTMLEditor::GetActiveEditingHost` to `ComputeEditingHost` r=m_kato 2022-05-31 03:41:01 +00:00
EditorEventListener.h Bug 1770874 - part 6: Move most part of `EditorEventListener::Blur` into `EditorBase` r=m_kato 2022-05-27 04:02:30 +00:00
EditorForwards.h Bug 1766355 - part 1: Add `MoveNodeTransaction` to handle delete node and insert node in a transaction class instance r=m_kato 2022-05-20 08:28:08 +00:00
EditorUtils.cpp Bug 1771809 - Make `HTMLEditor::AutoDeleteRangesHandler::HandleDeleteNonCollapsedRanges` check if handling range is still editable r=m_kato 2022-06-01 05:52:15 +00:00
EditorUtils.h Bug 1771809 - Make `HTMLEditor::AutoDeleteRangesHandler::HandleDeleteNonCollapsedRanges` check if handling range is still editable r=m_kato 2022-06-01 05:52:15 +00:00
HTMLAbsPositionEditor.cpp Bug 1771448 - part 4: Rename `HTMLEditor::GetActiveEditingHost` to `ComputeEditingHost` r=m_kato 2022-05-31 03:41:01 +00:00
HTMLAnonymousNodeEditor.cpp Bug 1771448 - part 4: Rename `HTMLEditor::GetActiveEditingHost` to `ComputeEditingHost` r=m_kato 2022-05-31 03:41:01 +00:00
HTMLEditHelpers.cpp Bug 1766355 - part 3: Make `MoveNodeResult` store caret point suggestion r=m_kato 2022-05-20 08:28:09 +00:00
HTMLEditHelpers.h Bug 1766355 - part 4: Make `HTMLEditor::MoveNodeWithTransaction` and `HTMLEditor::MoveNodeToEndWithTransaction` return `MoveNodeResult` r=m_kato 2022-05-20 08:28:09 +00:00
HTMLEditSubActionHandler.cpp Bug 1772022 - Make `EditorBase::DeleteNodeWithTransaction()` return `NS_ERROR_EDITOR_DESTROYED` if so r=m_kato 2022-06-03 02:03:47 +00:00
HTMLEditUtils.cpp Bug 1771564 - Constify ComputedStyle usage in nsComputedDOMStyle. r=dholbert 2022-05-28 01:04:24 +00:00
HTMLEditUtils.h Bug 1730442 - part 6: Make `HTMLEditor::InsertTableColumnsWithTransaction()` collect all necessary data before touching the DOM tree r=m_kato 2022-05-20 07:39:53 +00:00
HTMLEditor.cpp Bug 1772022 - Make `EditorBase::DeleteNodeWithTransaction()` return `NS_ERROR_EDITOR_DESTROYED` if so r=m_kato 2022-06-03 02:03:47 +00:00
HTMLEditor.h Bug 1772022 - Make `EditorBase::DeleteNodeWithTransaction()` return `NS_ERROR_EDITOR_DESTROYED` if so r=m_kato 2022-06-03 02:03:47 +00:00
HTMLEditorCommands.cpp Bug 1714918 - Sort out editor class accessors of `nsIEditor` r=m_kato 2021-06-11 03:01:08 +00:00
HTMLEditorController.cpp
…
HTMLEditorController.h
…
HTMLEditorDataTransfer.cpp Bug 1772022 - Make `EditorBase::DeleteNodeWithTransaction()` return `NS_ERROR_EDITOR_DESTROYED` if so r=m_kato 2022-06-03 02:03:47 +00:00
HTMLEditorDeleteHandler.cpp Bug 1772022 - Make `EditorBase::DeleteNodeWithTransaction()` return `NS_ERROR_EDITOR_DESTROYED` if so r=m_kato 2022-06-03 02:03:47 +00:00
HTMLEditorDocumentCommands.cpp Bug 1714918 - Sort out editor class accessors of `nsIEditor` r=m_kato 2021-06-11 03:01:08 +00:00
HTMLEditorEventListener.cpp Bug 1455514 - part 1: Add accessors and static helper methods to retrieve `nsINode` or its concrete classes from `EventTarget` r=smaug 2021-11-02 13:03:43 +00:00
HTMLEditorEventListener.h Bug 1764866 - Add "mozilla/EditorForwards.h" r=m_kato 2022-04-20 14:46:16 +00:00
HTMLEditorObjectResizer.cpp Bug 1771448 - part 4: Rename `HTMLEditor::GetActiveEditingHost` to `ComputeEditingHost` r=m_kato 2022-05-31 03:41:01 +00:00
HTMLEditorState.cpp Bug 1771448 - part 4: Rename `HTMLEditor::GetActiveEditingHost` to `ComputeEditingHost` r=m_kato 2022-05-31 03:41:01 +00:00
HTMLInlineTableEditor.cpp Bug 1771448 - part 4: Rename `HTMLEditor::GetActiveEditingHost` to `ComputeEditingHost` r=m_kato 2022-05-31 03:41:01 +00:00
HTMLStyleEditor.cpp Bug 1772022 - Make `EditorBase::DeleteNodeWithTransaction()` return `NS_ERROR_EDITOR_DESTROYED` if so r=m_kato 2022-06-03 02:03:47 +00:00
HTMLTableEditor.cpp Bug 1772022 - Make `EditorBase::DeleteNodeWithTransaction()` return `NS_ERROR_EDITOR_DESTROYED` if so r=m_kato 2022-06-03 02:03:47 +00:00
InsertNodeTransaction.cpp Bug 1762115 - part 2: Make `InsertNodeTransaction::DoTransaction()` stop touching `Selection` directly r=m_kato 2022-05-02 23:17:18 +00:00
InsertNodeTransaction.h Bug 1762115 - part 2: Make `InsertNodeTransaction::DoTransaction()` stop touching `Selection` directly r=m_kato 2022-05-02 23:17:18 +00:00
InsertTextTransaction.cpp Bug 1764684 - part 2: Make editor use methods of `EditorBase` to collapse `Selection` r=m_kato 2022-04-20 14:36:52 +00:00
InsertTextTransaction.h Bug 1764866 - Add "mozilla/EditorForwards.h" r=m_kato 2022-04-20 14:46:16 +00:00
InternetCiter.cpp Bug 1722484 Part 2 - Replace LineBreaker::Next() and WordBreaker::Next() with the new iterators. r=m_kato 2021-11-09 01:14:15 +00:00
InternetCiter.h Bug 1734590 - Both the static InternetCiter methods are now infallible, so no need to return/check an nsresult. r=TYLin 2021-10-11 12:20:42 +00:00
JoinNodesTransaction.cpp Bug 1762115 - part 5: Make `SplitNodeResult` store and suggest new caret position r=m_kato 2022-05-03 00:06:16 +00:00
JoinNodesTransaction.h Bug 1764866 - Add "mozilla/EditorForwards.h" r=m_kato 2022-04-20 14:46:16 +00:00
ManualNAC.h
…
MoveNodeTransaction.cpp Bug 1766355 - part 9: Make `HTMLEditor::ReplaceContainerWithTransactionInternal` and its callers use `MoveNodeTransaction` and return `CreateElementResult` r=m_kato 2022-05-20 10:44:04 +00:00
MoveNodeTransaction.h Bug 1766355 - part 4: Make `HTMLEditor::MoveNodeWithTransaction` and `HTMLEditor::MoveNodeToEndWithTransaction` return `MoveNodeResult` r=m_kato 2022-05-20 08:28:09 +00:00
PlaceholderTransaction.cpp Bug 1766956 - part 2: Make `PlaceholderTransaction::Merge` return `false` if the caret points of merging transactions are in different root nodes r=m_kato 2022-05-09 04:55:42 +00:00
PlaceholderTransaction.h Bug 1766956 - part 1: Make `PlaceholderTransaction::StartSelectionEquals` call `SelectionState::Equals` only when both selection caches store caret positions r=m_kato 2022-05-09 04:55:42 +00:00
ReplaceTextTransaction.cpp Bug 1764684 - part 2: Make editor use methods of `EditorBase` to collapse `Selection` r=m_kato 2022-04-20 14:36:52 +00:00
ReplaceTextTransaction.h Bug 1764866 - Add "mozilla/EditorForwards.h" r=m_kato 2022-04-20 14:46:16 +00:00
SelectionState.cpp Bug 1766355 - part 1: Add `MoveNodeTransaction` to handle delete node and insert node in a transaction class instance r=m_kato 2022-05-20 08:28:08 +00:00
SelectionState.h Bug 1766355 - part 7: Rewrite `HTMLEditor::RemoveContainerWithTransaction` with `MoveNodeTransaction` and make it stop touching `Selection` directly r=m_kato 2022-05-20 09:01:40 +00:00
SplitNodeTransaction.cpp Bug 1762115 - part 5: Make `SplitNodeResult` store and suggest new caret position r=m_kato 2022-05-03 00:06:16 +00:00
SplitNodeTransaction.h Bug 1764866 - Add "mozilla/EditorForwards.h" r=m_kato 2022-04-20 14:46:16 +00:00
TextEditSubActionHandler.cpp Bug 1765018 - part 4: Make `EditorBase::InsertTextWithTransaction` treat only `EditorDOMPoint` r=m_kato 2022-04-20 23:46:19 +00:00
TextEditor.cpp Bug 1771780 - Make `TextEditor::ReinitializeSelection` skip things which are necessary to be handled only at getting `focus` event r=m_kato 2022-06-01 00:01:50 +00:00
TextEditor.h Bug 1770874 - part 8: Make `EditorBase::OnBlur` temporarily a virtual method r=m_kato 2022-05-27 04:09:19 +00:00
TextEditorDataTransfer.cpp Bug 1753508 - Add logger of selection batch r=smaug 2022-03-11 02:24:24 +00:00
TypeInState.cpp Bug 1765018 - part 6: Make `TypeInState::OnSelectionChange` stop using `EditorRawDOMPoint` r=m_kato 2022-04-20 23:52:10 +00:00
TypeInState.h Bug 1765018 - part 2: Make `EditorBase::Get(Start|End)Point` return `EditorDOMPoint` or `EditorRawDOMPoint` r=m_kato 2022-04-20 23:35:18 +00:00
WSRunObject.cpp Bug 1772022 - Make `EditorBase::DeleteNodeWithTransaction()` return `NS_ERROR_EDITOR_DESTROYED` if so r=m_kato 2022-06-03 02:03:47 +00:00
WSRunObject.h Bug 1762115 - part 12: Make `WhiteSpaceVisibilityKeeper::InsertBRElement` stop touching `Selection` directly r=m_kato 2022-05-03 01:14:50 +00:00
moz.build Bug 1766355 - part 1: Add `MoveNodeTransaction` to handle delete node and insert node in a transaction class instance r=m_kato 2022-05-20 08:28:08 +00:00