gecko-dev/gfx/gl
Nicholas Nethercote 7974362afd Bug 1567329 - Append `_AtStartup` to `once` static pref getters. r=erahm
Currently it's completely unclear at use sites that the getters for `once`
static prefs return the pref value from startup, rather than the current pref
value. (Bugs have been caused by this.) This commit improves things by changing
the getter name to make it clear that the pref value obtained is from startup.

This required changing things within libpref so it distinguishes between the
"base id" (`foo_bar`) and the "full id" (`foo_bar` or
`foo_bar_DoNotUseDirectly` or `foo_bar_AtStartup` or
`foo_bar_AtStartup_DoNotUseDirectly`; the name used depends on the `mirror` and
`do_not_use_directly` values in the YAML definition.) The "full id" is used in
most places, while the "base id" is used for the `GetPrefName_*` and
`GetPrefDefault_*` functions.

(This is a nice demonstration of the benefits of the YAML file, BTW. Making
this change with the old code would have involved adding an entry to every
single pref in StaticPrefList.h.)

The patch also rejigs the comment at the top of StaticPrefList.yaml, to clarify
some things.

Differential Revision: https://phabricator.services.mozilla.com/D38604

--HG--
extra : moz-landing-system : lando
2019-07-22 02:10:14 +00:00
..
AndroidNativeWindow.h Bug 1540581 - P6. Tidy some C++ declarations in gfx/. r=gerald,jrmuizel 2019-04-11 12:36:51 +00:00
AndroidSurfaceTexture.cpp Bug 1559524 - Reduce calls to GLLibraryEGL::Get(). r=lsalzman 2019-06-15 05:21:12 +00:00
AndroidSurfaceTexture.h Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre 2019-01-18 10:16:18 +01:00
DecomposeIntoNoRepeatTriangles.cpp Bug 1289211 - Rename InfallibleTArray to nsTArray in gfx/ r=mstange 2019-07-10 05:25:54 +00:00
DecomposeIntoNoRepeatTriangles.h Bug 1289211 - Rename InfallibleTArray to nsTArray in gfx/ r=mstange 2019-07-10 05:25:54 +00:00
ForceDiscreteGPUHelperCGL.h Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00
GLBlitHelper.cpp Bug 1493898 - P6. Move YUVColorSpace definition in the gfx namespace. r=mattwoodrow. 2019-04-11 12:41:33 +00:00
GLBlitHelper.h Bug 1493898 - P6. Move YUVColorSpace definition in the gfx namespace. r=mattwoodrow. 2019-04-11 12:41:33 +00:00
GLBlitHelperD3D.cpp Bug 1560157 - Remove EGLUtils.h. r=lsalzman 2019-06-21 16:53:09 +00:00
GLConsts.h Bug 1536672 - Implement WebGL OVR_multiview2 behind draft flag. r=lsalzman,qdot 2019-05-23 20:48:21 +00:00
GLContext.cpp Bug 1567329 - Append `_AtStartup` to `once` static pref getters. r=erahm 2019-07-22 02:10:14 +00:00
GLContext.h Bug 1557577 - Remove GLContext::fDrawRangeElements. r=lsalzman 2019-06-07 10:20:19 +00:00
GLContextCGL.h Bug 1565668 - Add support for using an IOSurface as the default framebuffer for a GLContextCGL. r=jgilbert 2019-07-17 20:44:44 +00:00
GLContextEAGL.h Bug 1528396 - More precise GL symbol loading. r=lsalzman 2019-02-22 21:17:28 +00:00
GLContextEGL.h Bug 1559524 - Reduce calls to GLLibraryEGL::Get(). r=lsalzman 2019-06-15 05:21:12 +00:00
GLContextFeatures.cpp Bug 1528881 - Part 5: gfx/gl: Make some global functions static. r=jgilbert 2019-06-14 23:42:59 +00:00
GLContextGLX.h Bug 1540581 - P6. Tidy some C++ declarations in gfx/. r=gerald,jrmuizel 2019-04-11 12:36:51 +00:00
GLContextProvider.h Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre 2019-01-18 10:16:18 +01:00
GLContextProviderCGL.mm Bug 1565668 - Create a depth buffer for the default framebuffer of a GLContext that is used with WebRender. r=jgilbert 2019-07-17 20:45:53 +00:00
GLContextProviderEAGL.mm Bug 1550422 - P23. Remove now unused gfxPrefs. r=jrmuizel 2019-05-26 14:31:53 +00:00
GLContextProviderEGL.cpp Bug 1559524 - Reduce calls to GLLibraryEGL::Get(). r=lsalzman 2019-06-15 05:21:12 +00:00
GLContextProviderGLX.cpp Bug 1561825 - Make layout.* static prefs follow the naming convention. r=KrisWright 2019-06-27 16:28:25 +10:00
GLContextProviderImpl.h Bug 1532949 - Bug 1532024 - Explicityly create headless context for webrender in RenderCompositorEGL r=jgilbert 2019-03-13 00:17:01 +00:00
GLContextProviderNull.cpp Bug 1532949 - Bug 1532024 - Explicityly create headless context for webrender in RenderCompositorEGL r=jgilbert 2019-03-13 00:17:01 +00:00
GLContextProviderWGL.cpp Bug 1561491 - Make gl.* static prefs follow the naming convention. r=KrisWright 2019-06-26 13:05:06 +10:00
GLContextProviderWayland.cpp Bug 1532949 - Bug 1532024 - Explicityly create headless context for webrender in RenderCompositorEGL r=jgilbert 2019-03-13 00:17:01 +00:00
GLContextSymbols.h Bug 1557577 - Remove GLContext::fDrawRangeElements. r=lsalzman 2019-06-07 10:20:19 +00:00
GLContextTypes.h Bug 1559286 - Remove gl.msaa-level and SurfaceCaps.antialias. r=lsalzman 2019-06-14 19:09:54 +00:00
GLContextWGL.h Bug 1528396 - More precise GL symbol loading. r=lsalzman 2019-02-22 21:17:28 +00:00
GLDebugUtils.cpp Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00
GLDebugUtils.h Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00
GLDefs.h Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre 2019-01-18 10:16:18 +01:00
GLLibraryEGL.cpp Bug 1567329 - Append `_AtStartup` to `once` static pref getters. r=erahm 2019-07-22 02:10:14 +00:00
GLLibraryEGL.h Bug 1560157 - Remove EGLUtils.h. r=lsalzman 2019-06-21 16:53:09 +00:00
GLLibraryLoader.cpp Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 2019-03-13 10:19:06 +01:00
GLLibraryLoader.h Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 2019-03-13 10:19:06 +01:00
GLParseRegistryXML.py Bug 1559975: Fix python2/3 compat in gfx/ r=ahal 2019-07-05 14:28:55 +00:00
GLReadTexImageHelper.cpp Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan 2019-04-05 21:41:42 +00:00
GLReadTexImageHelper.h Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00
GLScreenBuffer.cpp Bug 1562331 - Make webgl.* static prefs follow the naming convention. r=KrisWright 2019-06-29 07:56:43 +10:00
GLScreenBuffer.h Bug 1559286 - Remove gl.msaa-level and SurfaceCaps.antialias. r=lsalzman 2019-06-14 19:09:54 +00:00
GLTextureImage.cpp Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00
GLTextureImage.h Bug 1540581 - P6. Tidy some C++ declarations in gfx/. r=gerald,jrmuizel 2019-04-11 12:36:51 +00:00
GLTypes.h Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre 2019-01-18 10:16:18 +01:00
GLUploadHelpers.cpp Bug 1544180 - Add CheckedInt check r=jgilbert 2019-05-14 12:05:57 +09:00
GLUploadHelpers.h Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00
GLXLibrary.h Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 2019-03-13 10:19:06 +01:00
GfxTexturesReporter.cpp Bug 1567329 - Append `_AtStartup` to `once` static pref getters. r=erahm 2019-07-22 02:10:14 +00:00
GfxTexturesReporter.h Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00
HeapCopyOfStackArray.h Bug 1511383: Update vim modelines after clang-format; r=sylvestre 2018-11-30 16:39:55 +01:00
MozFramebuffer.cpp Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00
MozFramebuffer.h Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00
ScopedGLHelpers.cpp Bug 1442825 - Remove ScopedGLWrapper base class. r=lsalzman 2019-06-17 06:40:27 +00:00
ScopedGLHelpers.h Bug 1442825 - Remove ScopedGLWrapper base class. r=lsalzman 2019-06-17 06:40:27 +00:00
SharedSurface.cpp Bug 1546192 - Check SharedSurface_Basic::Create failure 2019-06-17 13:40:13 +09:00
SharedSurface.h Bug 1546192 - Check SharedSurface_Basic::Create failure 2019-06-17 13:40:13 +09:00
SharedSurfaceANGLE.cpp Bug 1559524 - Reduce calls to GLLibraryEGL::Get(). r=lsalzman 2019-06-15 05:21:12 +00:00
SharedSurfaceANGLE.h Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00
SharedSurfaceD3D11Interop.cpp Bug 1562331 - Make webgl.* static prefs follow the naming convention. r=KrisWright 2019-06-29 07:56:43 +10:00
SharedSurfaceD3D11Interop.h Bug 1540581 - P6. Tidy some C++ declarations in gfx/. r=gerald,jrmuizel 2019-04-11 12:36:51 +00:00
SharedSurfaceEGL.cpp Bug 1559524 - Reduce calls to GLLibraryEGL::Get(). r=lsalzman 2019-06-15 05:21:12 +00:00
SharedSurfaceEGL.h Bug 1559524 - Reduce calls to GLLibraryEGL::Get(). r=lsalzman 2019-06-15 05:21:12 +00:00
SharedSurfaceGL.cpp Bug 1523969 part 8 - Move method definition inline comments to new line in 'gfx/'. r=kats 2019-02-25 16:07:19 -06:00
SharedSurfaceGL.h Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00
SharedSurfaceGLX.cpp Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00
SharedSurfaceGLX.h Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00
SharedSurfaceIO.cpp Bug 1540581 - P5. Add ColorSpace info to MacIOSurface. r=mattwoodrow 2019-04-11 12:36:31 +00:00
SharedSurfaceIO.h Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00
SurfaceTypes.h Bug 1559286 - Remove gl.msaa-level and SurfaceCaps.antialias. r=lsalzman 2019-06-14 19:09:54 +00:00
TextureImageEGL.cpp Bug 1559524 - Reduce calls to GLLibraryEGL::Get(). r=lsalzman 2019-06-15 05:21:12 +00:00
TextureImageEGL.h Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00
WGLLibrary.h Bug 1528396 - More precise GL symbol loading. r=lsalzman 2019-02-22 21:17:28 +00:00
moz.build Bug 1565668 - Add support for using an IOSurface as the default framebuffer for a GLContextCGL. r=jgilbert 2019-07-17 20:44:44 +00:00