gecko-dev/accessible
James Teh e72ae1eb3e Bug 1841943: Remove broken LazyInstantiator code to resolve a fake root accessible. r=nlapre
The code previously called DefWindowProc to get a system generated client IAccessible. However, DefWindowProc doesn't do this and I'm fairly sure it never has.
Even if we use CreateStdAccessibleObject instead:

1. We crash in LazyInstantiator's destructor because we try to call into mWeakMsaaRoot, which doesn't exist in this case.
2. We crash when some clients call us because AddRef and Release assume that we've transplanted our ref count into mRealRootUnk, but we don't do that in the case of a fake root.
3. We don't (and can't) aggregate the fake root COM object, so QueryInterface would be asymmetric. This may well cause obscure crashes/leaks.

We could fix all of these issues, but since this has clearly never been used or relied upon, we should just remove it.
We already have stub implementations for key methods and the others will just fail as they always have.
There should be no visible change with this patch.

Differential Revision: https://phabricator.services.mozilla.com/D182864
2023-07-11 21:58:49 +00:00
..
android Bug 1840295: Remove Windows specific ifdefs for PDocAccessible:: FocusEvent and CaretMoveEvent. r=eeejay 2023-07-05 04:15:27 +00:00
aom Bug 1840732 Part 5: Remove unnecessary includes from accessible/aom, r=Jamie 2023-07-07 03:22:08 +00:00
atk Bug 1837163: Use correct ATK text attribute names. r=eeejay 2023-07-11 01:32:08 +00:00
base Bug 1840732 Part 1: Remove unnecessary includes from accessible/base, r=Jamie 2023-07-07 03:22:07 +00:00
basetypes Bug 1840732 Part 2: Remove unnecessary includes from accessible/basetypes, r=Jamie 2023-07-07 03:22:07 +00:00
docs Bug 1621950 - fix some myst ref warnings r=firefox-source-docs-reviewers,devtools-reviewers,sylvestre 2023-03-30 08:01:22 +00:00
generic Bug 1840732 Part 3: Remove unnecessary includes from accessible/generic, r=Jamie 2023-07-07 03:22:07 +00:00
html Bug 1840732 Part 6: Remove unnecessary includes from accessible/html, r=Jamie 2023-07-07 03:22:08 +00:00
interfaces Bug 1754905 - Match Pivot API in nsIAccessiblePivot. r=Jamie 2023-06-28 21:45:16 +00:00
ipc Bug 1840732 Part 7: Remove unnecessary includes from accessible/ipc, r=Jamie 2023-07-07 03:22:09 +00:00
mac Bug 1840295: Remove Windows specific ifdefs for PDocAccessible:: FocusEvent and CaretMoveEvent. r=eeejay 2023-07-05 04:15:27 +00:00
other Bug 1840295: Remove Windows specific ifdefs for PDocAccessible:: FocusEvent and CaretMoveEvent. r=eeejay 2023-07-05 04:15:27 +00:00
tests Bug 1841216: Fire a11y description change event when aria-description is changed. r=nlapre 2023-07-06 01:32:56 +00:00
windows Bug 1841943: Remove broken LazyInstantiator code to resolve a fake root accessible. r=nlapre 2023-07-11 21:58:49 +00:00
xpcom Bug 1840732 Part 4: Remove unnecessary includes from accessible/xpcom, r=Jamie 2023-07-07 03:22:08 +00:00
xul Bug 1839922 - Remove usage of {Has,Get}Attr(kNameSpaceID_None, ..). r=edgar 2023-06-23 10:01:32 +00:00
moz.build Bug 1754905 - Match Pivot API in nsIAccessiblePivot. r=Jamie 2023-06-28 21:45:16 +00:00