gecko-dev/mozglue
Toshihito Kikuchi 481aa7905b Bug 1588245 - More values to DetourResultCode. r=mhowell
This is the third attempt to investigate the launcher failure of our detour.
The previous commits d8315e4ed18d and 1b81ea85c43d added the assembly bytes
of a detour target and a special error code `DetourResultCode` to the launcher
failure ping.

In the latest telemetry data, however, the most common value of `hresult`
is still `ERROR_UNIDENTIFIED_ERROR`, meaning the previous commit missed to
set an error code in the common fallible codepath we wanted to know.
Besides `ERROR_UNIDENTIFIED_ERROR`, we're seeing `DETOUR_PATCHER_DO_RESERVE_ERROR`
in the telemetry, but having that code is not enough to pinpoint a falling
operation.

For further investigation, this patch adds ten more values to `DetourResultCode`.
`FUNCHOOKCROSSPROCESS_COPYSTUB_ERROR` is the last codepath we forgot to cover
in the previous commit.  The values of `MMPOLICY_RESERVE_*` are to investigate
`DETOUR_PATCHER_DO_RESERVE_ERROR` in the MMPolicy level.  In both cases, we add
the last Windows error code to `DetourError::mOrigBytes`.

Differential Revision: https://phabricator.services.mozilla.com/D92974
2020-10-08 19:00:22 +00:00
..
android Bug 689178 - Remove crash-reporter hooks to externally provide library mappings. r=gsvelto 2020-06-25 08:43:23 +00:00
baseprofiler Bug 1524625 - DLL loads during early startup should show profiler markers, r=gerald. 2020-10-05 13:47:27 +00:00
build Bug 1601980 - use MOZ_ATOMIC_BITFIELDS in imagelib to avoid races on flags. r=aosmond,decoder 2020-10-01 13:22:49 +00:00
dllservices Bug 1524625 - DLL loads during early startup should show profiler markers, r=gerald. 2020-10-05 13:47:27 +00:00
linker Bug 1519636 - Reformat recent changes to the Google coding style r=andi 2020-07-14 09:34:19 +00:00
misc Bug 1588245 - More values to DetourResultCode. r=mhowell 2020-10-08 19:00:22 +00:00
static Bug 1617369 - Reformat mozglue/ using rustfmt r=glandium 2020-03-04 06:12:38 +00:00
tests Bug 1668057: Allow DLL interceptor to patch 64-bit immediate MOVs r=tkikuchi 2020-10-05 22:25:44 +00:00
moz.build Bug 1598196 - Support disabling the linker on Android in the code. r=froydnj 2019-11-21 14:57:24 +00:00