mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность
gecko-dev/browser/modules
История
Chris Pearce 4a6ff21ab5 Bug 1473671 - Don't store persistent block permission if ESC pressed while showing permission doorhanger. r=florian 
While showing a doorhanger permisison prompt, if the user presses the ESC key
we call the secondary action callback, passing in whether any checkbox on
the popup notification was checked.

In the case of an autoplay-media permission prompt, we have a "remember"
checkbox, which is checked by default. So pressing ESC means the user will
remember a "block" result for the current site.

We believe that users don't expect pressing ESC to result in a remembered
decision, they expect pressing ESC to avoid making a decision. So we want to
ignore the checkbox when ESC is pressed for autoplay-media.

So this patch adds a new PopupNotification behaviour which reports the source
of event which caused the action callback to be called. This enables the ESC
key press to ignore storing a permission.

Note: the change here to not store a permission on ESC press applies to all
permissions, not just autoplay-media.


MozReview-Commit-ID: IUWFN8LG9VF

--HG--
extra : rebase_source : b004bc211177a7bfb6dcea563d75db9a6750b214
 		2018-07-17 14:45:17 +12:00
..
test Bug 1463291: Move docShell getter from Document to Window. r=bz 2018-05-21 16:58:23 -07:00
AboutNewTab.jsm Bug 1369466 - Change consumers to the new location of RemotePageManager. r=mossop 2018-07-26 22:09:12 -03:00
AsyncTabSwitcher.jsm Bug 1176019 - Don't let cache interfere with tab warming r=mconley 2018-05-15 09:31:13 -07:00
BlockedSiteContent.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in browser/ r=mikedeboer 2018-07-25 09:10:07 +01:00
BrowserErrorReporter.jsm Bug 1470505: Disable browser error collection for webextension errors. r=Gijs 2018-07-09 18:27:22 +00:00
BrowserUsageTelemetry.jsm Bug 1477042 - Add a pref for counting URIs in private browsing mode. r=mikedeboer 2018-07-27 22:45:29 +00:00
BrowserWindowTracker.jsm Bug 1466071: Part 1: Prevent orderedWindows from changing while iterating. r=mikedeboer 2018-06-05 13:47:58 -07:00
ClickEventHandler.jsm Bug 1463291: Move docShell getter from Document to Window. r=bz 2018-05-21 16:58:23 -07:00
ContentClick.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in browser/ r=mikedeboer 2018-07-25 09:10:07 +01:00
ContentCrashHandlers.jsm Bug 1369466 - Change consumers to the new location of RemotePageManager. r=mossop 2018-07-26 22:09:12 -03:00
ContentLinkHandler.jsm Bug 1479236: Stop loading NetUtil.jsm in the content process. r=Mossop 2018-07-28 17:47:06 -07:00
ContentMetaHandler.jsm Bug 1464548: Part 3 - Update callers to use defineLazyGlobalGetters. r=mccr8 2018-05-25 17:02:29 -07:00
ContentObservers.js
…
ContentSearch.jsm Bug 1437942 - Remove search engines from langpacks. r=adw 2018-06-04 16:45:50 -05:00
ContentWebRTC.jsm Bug 1476145 part 3. Stop using getInterface(nsIDOMWindowUtils) in browser/. r=gijs 2018-07-24 19:47:41 -04:00
ContextMenu.jsm Bug 1449968 - Add support for Inspect Element in Shadow DOM;r=bgrins 2018-07-05 18:48:24 +02:00
ExtensionsUI.jsm Bug 1463291: Move docShell getter from Document to Window. r=bz 2018-05-21 16:58:23 -07:00
Feeds.jsm Bug 1477670 - remove content handler code from browser/, r=florian,jkt 2018-07-24 17:54:40 +01:00
FormSubmitObserver.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in browser/ r=mikedeboer 2018-07-25 09:10:07 +01:00
FormValidationHandler.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in browser/ r=mikedeboer 2018-07-25 09:10:07 +01:00
HomePage.jsm Bug 721211: consolidate home page retrieval code, make it support non-localized prefs, r=jaws 2018-05-28 12:38:01 +02:00
LaterRun.jsm
…
LightWeightThemeWebInstallListener.jsm Bug 1462673 - Only load LightWeightThemeWebInstallListener when necessary. r=mconley 2018-05-25 14:22:14 -03:00
LightweightThemeChildHelper.jsm Bug 1474163 - Make use of sharedData for content theme data. r=mconley 2018-07-13 16:21:34 +01:00
NetErrorContent.jsm Bug 1463291: Move docShell getter from Document to Window. r=bz 2018-05-21 16:58:23 -07:00
OpenInTabsUtils.jsm
…
PageActions.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in browser/ r=mikedeboer 2018-07-25 09:10:07 +01:00
PageInfoListener.jsm Bug 1461444 - Only load the PageInfoListener content code when needed. r=johannh 2018-05-25 14:22:13 -03:00
PageStyleHandler.jsm Bug 1463291: Move docShell getter from Document to Window. r=bz 2018-05-21 16:58:23 -07:00
PermissionUI.jsm Bug 1473671 - Don't store persistent block permission if ESC pressed while showing permission doorhanger. r=florian 2018-07-17 14:45:17 +12:00
PingCentre.jsm Bug 1464548: Part 3 - Update callers to use defineLazyGlobalGetters. r=mccr8 2018-05-25 17:02:29 -07:00
PluginContent.jsm Bug 1476145 part 3. Stop using getInterface(nsIDOMWindowUtils) in browser/. r=gijs 2018-07-24 19:47:41 -04:00
ProcessHangMonitor.jsm
…
ReaderParent.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in browser/ r=mikedeboer 2018-07-25 09:10:07 +01:00
RemotePrompt.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in browser/ r=mikedeboer 2018-07-25 09:10:07 +01:00
Sanitizer.jsm Bug 1476333 - Refer to AppConstants.BROWSER_CHROME_URL to get the browser URL from the frontend;r=Gijs 2018-07-24 08:12:50 -07:00
SavantShieldStudy.jsm Bug 1465694 - Add tab event telemetry for Savant Shield study; r=dao 2018-06-06 03:44:48 -07:00
SchedulePressure.jsm
…
SiteDataManager.jsm Bug 1450448 - Correctly handle non-initialized appCache in site data preferences. r=Gijs 2018-05-15 22:02:33 +02:00
SitePermissions.jsm Bug 1470082 - Change autoplay checkbox to combobox. r=cpearce,flod,johannh 2018-06-29 14:14:33 +01:00
TabsList.jsm Bug 1470947 - Part 2: Call _tabAttrModified on busy and progress changes r=dao 2018-06-25 11:30:44 -04:00
ThemeVariableMap.jsm Backed out 2 changesets (bug 1347204) for ESlint failure on browser_ext_themes_ntp_colors. CLOSED TREE 2018-07-06 01:13:43 +03:00
TransientPrefs.jsm
…
Windows8WindowFrameColor.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in browser/ r=mikedeboer 2018-07-25 09:10:07 +01:00
WindowsJumpLists.jsm Bug 1476238 - Use nsresult/promise rejection in initListBuild r=Gijs 2018-07-20 16:56:01 +00:00
WindowsPreviewPerTab.jsm Bug 1476145 part 3. Stop using getInterface(nsIDOMWindowUtils) in browser/. r=gijs 2018-07-24 19:47:41 -04:00
ZoomUI.jsm
…
moz.build Bug 1474163 - Make use of sharedData for content theme data. r=mconley 2018-07-13 16:21:34 +01:00
webrtcUI.jsm Bug 1459613 - Show extension name in PermissionUI / webrtcUI doorhangers and menus items. r=johannh 2018-05-16 19:32:42 +02:00