gecko-dev/dom/media/eme
Boris Zbarsky 9789fc91bb Bug 1615035. Use ErrorResults, not nsresults, to propagate errors in CDM code. r=bryce
Please review this very carefully!  This exposes a bunch of error messages that
used to only be visible on DetailedPromise to web content.  Are there any
privacy/security issues with exposing those?  If needed, we could use more
generic messages instead, but exposing this information if we can seemed like
the right way to go.

I did look over the error messages coming from GeckoMediaDrmBridgeV21.java and
none of them look like they expose any interesting state.  The messages from
ChromiumCDMProxy expose mKeySystem, but that came from the web page to start
with, I think.

Also, are these messages even meaningful for web content?  Some of the error
messages (like the one from MediaDrmCDMProxy::md_SetServerCertificate) seem
like they include internal function names, so are not great for web content...
I'm not quite sure what the best thing to do there is.

Note: There is a behavior change to ChromiumCDMParent::GetStatusForPolicy because
NS_ERROR_INVALID_ARG is not a valid thing to throw to web content.  I've used
TypeError, since that's what normally gets used for invalid args.

Differential Revision: https://phabricator.services.mozilla.com/D62645

--HG--
extra : moz-landing-system : lando
2020-02-19 01:15:33 +00:00
..
mediadrm Bug 1615035. Use ErrorResults, not nsresults, to propagate errors in CDM code. r=bryce 2020-02-19 01:15:33 +00:00
CDMCaps.cpp
CDMCaps.h Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan 2019-12-06 09:24:56 +00:00
CDMProxy.h Bug 1615035. Use ErrorResults, not nsresults, to propagate errors in CDM code. r=bryce 2020-02-19 01:15:33 +00:00
DecryptorProxyCallback.h Bug 1615035. Use ErrorResults, not nsresults, to propagate errors in CDM code. r=bryce 2020-02-19 01:15:33 +00:00
DetailedPromise.cpp Bug 1615022 part 2. Require an rvalue reference to reject a Promise with an ErrorResult. r=farre,kvark 2020-02-14 15:42:30 +00:00
DetailedPromise.h Bug 1615022 part 2. Require an rvalue reference to reject a Promise with an ErrorResult. r=farre,kvark 2020-02-14 15:42:30 +00:00
EMEUtils.cpp bug 1610296 - Rename TypedArray_base::ComputeLengthAndData to TypedArray_base::ComputeState; r=bzbarsky 2020-01-23 03:22:06 +00:00
EMEUtils.h
MediaEncryptedEvent.cpp bug 1610296 - Rename TypedArray_base::ComputeLengthAndData to TypedArray_base::ComputeState; r=bzbarsky 2020-01-23 03:22:06 +00:00
MediaEncryptedEvent.h
MediaKeyError.cpp
MediaKeyError.h
MediaKeyMessageEvent.cpp bug 1610296 - Rename TypedArray_base::ComputeLengthAndData to TypedArray_base::ComputeState; r=bzbarsky 2020-01-23 03:22:06 +00:00
MediaKeyMessageEvent.h
MediaKeySession.cpp Bug 1612213 part 3. Switch Promise::RejectWithDOMException consumers to new convenience methods. r=smaug,jgilbert 2020-02-03 20:37:32 +00:00
MediaKeySession.h Bug 1611509 part 3. Remove the Date type from Web IDL. r=edgar 2020-01-27 08:50:35 +00:00
MediaKeyStatusMap.cpp
MediaKeyStatusMap.h
MediaKeySystemAccess.cpp Bug 1609861 part 5. Stop using NS_ERROR_DOM_TYPE_ERR in IsTypeSupported. r=jya 2020-01-17 16:19:12 +00:00
MediaKeySystemAccess.h
MediaKeySystemAccessManager.cpp Bug 1612213 part 3. Switch Promise::RejectWithDOMException consumers to new convenience methods. r=smaug,jgilbert 2020-02-03 20:37:32 +00:00
MediaKeySystemAccessManager.h Bug 1587573 - Clarify threading model used by MediaKeySystemAccessManager. r=dminor 2019-10-24 21:55:54 +00:00
MediaKeys.cpp Bug 1615035. Use ErrorResults, not nsresults, to propagate errors in CDM code. r=bryce 2020-02-19 01:15:33 +00:00
MediaKeys.h Bug 1615035. Use ErrorResults, not nsresults, to propagate errors in CDM code. r=bryce 2020-02-19 01:15:33 +00:00
moz.build