gecko-dev/mozglue
Gerald Squelart 41c580344f Bug 1572027 - Make BlocksRingBuffer::EntryReader move-only - r=gregtatum
After some bad experiences, I think EntryReader should be move-only:
- It needs to be moveable so it can be created from a function, and move-
  constructed into a Maybe<> if needed.
- It can be passed around as a reference.

Previously, it could be passed by value, but it was too easy to create bugs,
e.g.: A function delegates to a sub-function to read something at the beginning,
then the first function wants to read more past that, but if the reader was
passed by value the first function would not see past what the sub-function did
read.

As a bonus, `mRing` can now be a reference instead of a pointer, and other
members can be const.

Differential Revision: https://phabricator.services.mozilla.com/D40958

--HG--
extra : moz-landing-system : lando
2019-08-07 21:33:09 +00:00
..
android Bug 1555205 - Move db/sqlite3 to third_party/; r=mak 2019-05-29 10:16:29 +00:00
baseprofiler Bug 1572027 - Make BlocksRingBuffer::EntryReader move-only - r=gregtatum 2019-08-07 21:33:09 +00:00
build Bug 1571875: Part 2 - Change over all existing static local uses of DynamicallyLinkedFunctionPtr to use StaticDynamicallyLinkedFunctionPtr instead; r=mhowell 2019-08-07 15:58:09 +00:00
linker Bug 1562642 - Part 2 - Add missing MPL2 headers r=Gijs 2019-07-08 09:27:47 +00:00
misc Bug 1571875: Part 2 - Change over all existing static local uses of DynamicallyLinkedFunctionPtr to use StaticDynamicallyLinkedFunctionPtr instead; r=mhowell 2019-08-07 15:58:09 +00:00
tests Bug 1572027 - Make BlocksRingBuffer::EntryReader move-only - r=gregtatum 2019-08-07 21:33:09 +00:00
moz.build Bug 1492121 - MOZ_BASE_PROFILER may be defined in BaseProfiler.h to enable Base Profiler - r=njn 2019-06-06 06:17:30 +00:00