gecko-dev/toolkit/modules
Chris Pearce 4a6ff21ab5 Bug 1473671 - Don't store persistent block permission if ESC pressed while showing permission doorhanger. r=florian
While showing a doorhanger permisison prompt, if the user presses the ESC key
we call the secondary action callback, passing in whether any checkbox on
the popup notification was checked.

In the case of an autoplay-media permission prompt, we have a "remember"
checkbox, which is checked by default. So pressing ESC means the user will
remember a "block" result for the current site.

We believe that users don't expect pressing ESC to result in a remembered
decision, they expect pressing ESC to avoid making a decision. So we want to
ignore the checkbox when ESC is pressed for autoplay-media.

So this patch adds a new PopupNotification behaviour which reports the source
of event which caused the action callback to be called. This enables the ESC
key press to ignore storing a permission.

Note: the change here to not store a permission on ESC press applies to all
permissions, not just autoplay-media.


MozReview-Commit-ID: IUWFN8LG9VF

--HG--
extra : rebase_source : b004bc211177a7bfb6dcea563d75db9a6750b214
2018-07-17 14:45:17 +12:00
..
addons Backed out 2 changesets (bug 1463016, bug 1463291) for geckoview failures 2018-07-29 03:55:23 +03:00
docs
secondscreen Bug 1464548: Part 3 - Update callers to use defineLazyGlobalGetters. r=mccr8 2018-05-25 17:02:29 -07:00
sessionstore Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer 2018-07-25 11:00:35 +01:00
subprocess Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer 2018-07-25 11:00:35 +01:00
tests Bug 1369466 - Move RemotePageManager test to its new location. r=mossop 2018-07-26 22:09:34 -03:00
third_party/jsesc Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
AppConstants.jsm Bug 1476333 - Define the browser chrome URL as BROWSER_CHROME_URL so it can be accessed from AppConstants instead of a pref;r=gps 2018-07-24 08:12:48 -07:00
AppMenuNotifications.jsm Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
AsyncPrefs.jsm Bug 1430751 - Apply unified behavior model for about: pages to about:privatebrowsing. r=gijs,mrbkap 2018-03-05 09:20:34 +01:00
AutoCompletePopupContent.jsm Bug 1474155: Part 2 - Move AutoCompletePopup to a separate JSM. r=mconley 2018-07-10 11:57:47 -07:00
AutoScrollController.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer 2018-07-25 11:00:35 +01:00
Battery.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer 2018-07-25 11:00:35 +01:00
BinarySearch.jsm Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
BrowserUtils.jsm Backed out 2 changesets (bug 1463016, bug 1463291) for geckoview failures 2018-07-29 03:55:23 +03:00
CanonicalJSON.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer 2018-07-25 11:00:35 +01:00
CertUtils.jsm Bug 1475647 - Remove nsISSLStatusProvider interface. r=baku,Gijs,jchen,jryans,keeler,mcmanus 2018-07-13 11:48:55 -07:00
CharsetMenu.jsm Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
ClientID.jsm Bug 1445921 - Allow client ID to be set and reset. r=Dexter 2018-07-10 12:51:01 +00:00
Color.jsm Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Console.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer 2018-07-25 11:00:35 +01:00
CreditCard.jsm Bug 1461477 - Create a CreditCard.jsm to consolidate various credit card handling and validation. r=MattN 2018-05-15 12:41:35 -04:00
DateTimePickerContent.jsm Bug 1467586 - Convert the DateTimePickerListener object into a class to be instantiated when needed. r=mconley 2018-06-09 18:46:39 -03:00
DateTimePickerParent.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer 2018-07-25 11:00:35 +01:00
DeferredTask.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer 2018-07-25 11:00:35 +01:00
Deprecated.jsm Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
E10SUtils.jsm Bug 1476145 part 6. Stop using getInterface(nsIDOMWindowUtils) in toolkit. r=mossop 2018-07-24 19:47:42 -04:00
EventEmitter.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer 2018-07-25 11:00:35 +01:00
FileUtils.jsm Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Finder.jsm Backed out 2 changesets (bug 1463016, bug 1463291) for geckoview failures 2018-07-29 03:55:23 +03:00
FinderHighlighter.jsm Bug 1476145 part 6. Stop using getInterface(nsIDOMWindowUtils) in toolkit. r=mossop 2018-07-24 19:47:42 -04:00
FinderIterator.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer 2018-07-25 11:00:35 +01:00
FormLikeFactory.jsm Bug 1456843 - Compute FormLike elements lazily on <form>-less fields. r=MattN 2018-07-13 12:41:06 -04:00
GMPExtractorWorker.js
GMPInstallManager.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer 2018-07-25 11:00:35 +01:00
GMPUtils.jsm Bug 1456630 - Stop checking for Vista or earlier in GMPUtils, since those verisons of Windows aren't supported anymore. r=cpearce 2018-04-24 17:00:53 -04:00
Geometry.jsm Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
HiddenFrame.jsm Backed out 2 changesets (bug 1463016, bug 1463291) for geckoview failures 2018-07-29 03:55:23 +03:00
Http.jsm
IndexedDB.jsm Bug 1406181 - Add openForPrincipal static method and changes to IDB cursor wrapping in IndexedDB.jsm. r=aswan 2018-04-14 15:10:29 +02:00
InlineSpellChecker.jsm Bug 1477917 - Part 2. Use AString instead of wstring in spellchecker. r=masayuki 2018-07-26 03:13:51 +00:00
InlineSpellCheckerContent.jsm Bug 1465875 part 1. Eliminate pointless QIs to nsIDOMNSEditableElement. r=qdot 2018-06-01 22:35:22 -04:00
Integration.jsm Bug 1460092: Add ESLint rule to enforce use of ChromeUtils.generateQI. r=Gijs 2018-05-08 18:36:22 -07:00
JSONFile.jsm Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
LightweightThemeConsumer.jsm Bug 1474163 - Make use of sharedData for content theme data. r=mconley 2018-07-13 16:21:34 +01:00
Log.jsm Bug 1452200 - 1b. Add template literal support to Log.jsm; r=markh 2018-04-15 14:53:28 -04:00
NLP.jsm Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
NewTabUtils.jsm Bug 1475012 - fix ordering of getTopFrecentSites in ActivityStreamProvider r=ursula 2018-07-11 12:26:39 -07:00
ObjectUtils.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer 2018-07-25 11:00:35 +01:00
PageMenu.jsm Bug 1476145 part 6. Stop using getInterface(nsIDOMWindowUtils) in toolkit. r=mossop 2018-07-24 19:47:42 -04:00
PageMetadata.jsm Bug 1433958 - Change code that sets nsIURI.userPass to use nsIURIMutator r=mayhemer 2018-02-26 20:43:46 +01:00
PermissionsUtils.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer 2018-07-25 11:00:35 +01:00
PopupBlocking.jsm Bug 1474155: Part 1 - Move PopupBlocking to a separate JSM. r=mconley 2018-07-10 11:57:55 -07:00
PopupNotifications.jsm Bug 1473671 - Don't store persistent block permission if ESC pressed while showing permission doorhanger. r=florian 2018-07-17 14:45:17 +12:00
Preferences.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer 2018-07-25 11:00:35 +01:00
PrintingContent.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer 2018-07-25 11:00:35 +01:00
PrivateBrowsingUtils.jsm Bug 1462470 - Part 2 - Alert about trackers when Tracking Protection is off in the identity popup. r=Paolo 2018-05-24 13:12:30 +02:00
ProfileAge.jsm Bug 1466518 - Store current timestamp as profile directory scan date in a scalar. r=chutten 2018-06-30 12:00:20 +00:00
Promise-backend.js Bug 1433175 - enable the use-cc-etc eslint rule, r=Standard8. 2018-02-28 18:51:35 +01:00
Promise.jsm
PromiseMessage.jsm Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
PromiseUtils.jsm Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
PropertyListUtils.jsm Bug 1464548: Part 3 - Update callers to use defineLazyGlobalGetters. r=mccr8 2018-05-25 17:02:29 -07:00
RemoteController.js Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8 2018-04-22 20:55:06 -07:00
RemoteFinder.jsm Bug 1418033 - Make it possible to disable fast find. r=mikedeboer 2018-05-14 21:49:43 +02:00
RemoteSecurityUI.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer 2018-07-25 11:00:35 +01:00
RemoteWebProgress.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer 2018-07-25 11:00:35 +01:00
ResetProfile.jsm Bug 1429157 - Create an enterprise policy to prevent profile refreshes r=Felipe,Gijs 2018-03-28 09:44:07 -07:00
ResponsivenessMonitor.jsm Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
SelectContentHelper.jsm Bug 1464548: Part 3 - Update callers to use defineLazyGlobalGetters. r=mccr8 2018-05-25 17:02:29 -07:00
SelectParentHelper.jsm Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
SelectionSourceContent.jsm Bug 1365626 - Remove View MathML Source feature. r=mconley 2018-06-28 20:45:31 +00:00
ServiceRequest.jsm Bug 1464548: Part 3 - Update callers to use defineLazyGlobalGetters. r=mccr8 2018-05-25 17:02:29 -07:00
Services.jsm Bug 1476030 - Part 1 - Expose xulStore through Services;r=Gijs 2018-07-18 09:43:38 -07:00
ShortcutUtils.jsm Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Sqlite.jsm Bug 1442353 - Reuse timeoutPromise in Sqlite.jsm r=florian 2018-03-01 10:43:07 -08:00
Task.jsm Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Timer.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer 2018-07-25 11:00:35 +01:00
Troubleshoot.jsm Bug 1476145 part 6. Stop using getInterface(nsIDOMWindowUtils) in toolkit. r=mossop 2018-07-24 19:47:42 -04:00
UpdateUtils.jsm Bug 1464548: Part 3 - Update callers to use defineLazyGlobalGetters. r=mccr8 2018-05-25 17:02:29 -07:00
WebChannel.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer 2018-07-25 11:00:35 +01:00
WebChannelContent.jsm Bug 1463291: Move docShell getter from Document to Window. r=bz 2018-05-21 16:58:23 -07:00
WindowDraggingUtils.jsm Bug 1455596 - Remove support for <panel backdrag="true"/>. r=enn,ehsan 2018-04-24 22:07:20 +02:00
WindowsRegistry.jsm Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
ZipUtils.jsm Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer 2018-07-25 11:00:35 +01:00
css-selector.js Bug 1449972 - part2: Move getCssPath and getXPath to toolkit css-selector;r=bgrins 2018-07-18 07:33:21 +02:00
jar.mn
moz.build Bug 1369466 - Remove the old RemotePageManager.jsm code. r=mossop 2018-07-26 22:09:38 -03:00
offlineAppCache.jsm Bug 1415342 - Part 1 - Move OfflineAppCacheHelper to Toolkit. r=standard8 2018-04-12 19:16:02 +02:00
win.xul