gecko-dev/js
Iain Ireland b8f20f5b00 Bug 1691184: Recompile if necessary before retrying interrupted regexp r=mgaudet
If an interrupt occurs during regexp execution, we return up the stack to RegExpShared::execute to handle it, then try again. Normally it's safe (if slow) to GC and discard jitcode at this point, because we can fall back to interpreted bytecode (which is not discarded). However, if the input string is long enough, then we [jump straight to compilation without producing bytecode](https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/js/src/vm/RegExpObject.cpp#590-596). In that case, when we resume, we will have neither bytecode nor jitcode, and end up dereferencing a null pointer.

The fix is to recompile after handling the interrupt. In addition to fixing the crash, forcing compilation here should improve our chance of eventual success (compared to resuming in the regexp interpreter).

Differential Revision: https://phabricator.services.mozilla.com/D104479
2021-03-09 18:34:43 +00:00
..
ductwork/debugger Bug 1654103: Standardize on Black for Python code in `mozilla-central`. 2020-10-26 18:34:53 +00:00
examples
public Bug 1696920 - Part 4: Require non-nullptr JSContext in CharsToNewUTF8CharsZ. r=jandem 2021-03-09 10:07:58 +00:00
src Bug 1691184: Recompile if necessary before retrying interrupted regexp r=mgaudet 2021-03-09 18:34:43 +00:00
xpconnect Bug 1696978 - Require user input for slow extension warning r=smaug,extension-reviewers,kmag 2021-03-09 01:35:03 +00:00
app.mozbuild Bug 1679938 - Don't recurse the build into mfbt for projects that don't need it. r=firefox-build-system-reviewers,mhentges 2020-12-01 23:52:03 +00:00
ffi.configure Bug 1654103: Standardize on Black for Python code in `mozilla-central`. 2020-10-26 18:34:53 +00:00
moz.build Bug 1654103: Standardize on Black for Python code in `mozilla-central`. 2020-10-26 18:34:53 +00:00
moz.configure Bug 1692939 - Fix SM bustage. r=glandium CLOSED TREE 2021-02-19 01:25:47 +02:00
sub.configure Bug 1654103: Standardize on Black for Python code in `mozilla-central`. 2020-10-26 18:34:53 +00:00