gecko-dev/xpcom/base
Nika Layzell 7ced96212e Bug 1778211 - Reject xpidl CDATA containing 'virtual', r=xpcom-reviewers,necko-reviewers,mccr8,dragana
We'll probably want to do something more accurate in the future with a
custom clang static analysis pass which validates that XPIDL interfaces
have the expected vtable and struct layout, however doing so would be
more involved than the string matching done in this patch.

In addition to checking for extra virtual methods, we'll likely also
want to check for data members on interfaces, and reject them unless the
class is marked as `[builtinclass]` in addition to some other attribute
which we'll need to add to prevent them from being implemented in Rust
(as c++ data members will not be reflected by the rust macro).

There were 2 instances of a comment which contained the word 'virtual'
within a CDATA block. These comments were moved out of the CDATA block
to avoid triggering the error.

Differential Revision: https://phabricator.services.mozilla.com/D151068
2022-07-06 14:53:06 +00:00
..
AppShutdown.cpp Bug 1766572: Part 3 - Make nsTerminator aware of late shutdown phases. r=xpcom-reviewers,nika 2022-05-13 15:47:53 +00:00
AppShutdown.h Bug 1766572: Part 3 - Make nsTerminator aware of late shutdown phases. r=xpcom-reviewers,nika 2022-05-13 15:47:53 +00:00
AutoRestore.h Bug 1519636 - Reformat recent changes to the Google coding style r=andi 2020-08-02 15:29:15 +00:00
AvailableMemoryTracker.cpp Bug 1733308 - Fix non-unified builds errors in xpcom/base. r=xpcom-reviewers,mccr8 2021-10-01 01:49:16 +00:00
AvailableMemoryTracker.h
AvailableMemoryWatcher.cpp Bug 1532955 - Track available memory on linux. r=gsvelto,tkikuchi 2021-12-02 11:14:30 +00:00
AvailableMemoryWatcher.h Bug 1730066 - Enable tab unloading on macOS r=spohl 2021-10-21 04:43:35 +00:00
AvailableMemoryWatcherLinux.cpp Bug 1762469: xpcom memory reporter cleanup r=nika 2022-04-04 22:57:37 +00:00
AvailableMemoryWatcherMac.cpp Bug 1730066 - Enable tab unloading on macOS r=spohl 2021-10-21 04:43:35 +00:00
AvailableMemoryWatcherUtils.h Bug 1532955 - Track available memory on linux. r=gsvelto,tkikuchi 2021-12-02 11:14:30 +00:00
AvailableMemoryWatcherWin.cpp Bug 1762839 - Adjust locking in AvailableMemoryWatcherWin to appease thread safety checker. r=nika 2022-04-10 21:58:26 +00:00
ClearOnShutdown.cpp Bug 1696397: Move SpinEventLoopUntilOrShutdown to -Quit and move the current shutdown state logic from nsThreadManager to AppShutdown; r=kmag,xpcom-reviewers 2021-03-17 08:07:48 +00:00
ClearOnShutdown.h Bug 1696397: Move SpinEventLoopUntilOrShutdown to -Quit and move the current shutdown state logic from nsThreadManager to AppShutdown; r=kmag,xpcom-reviewers 2021-03-17 08:07:48 +00:00
CodeAddressService.h Bug 1699375 - Make MozFormatCodeAddress* return the printed size, and use that instead of strlen. r=nika 2021-03-22 21:25:30 +00:00
CountingAllocatorBase.h Bug 1678062 - Remove unnecessary includes. r=andi 2020-11-23 16:12:02 +00:00
CycleCollectedJSContext.cpp Bug 1661293 - Move idle-time nursery GCs to a new nsJSContext::MaybePokeGC r=jonco,smaug 2022-06-06 22:53:11 +00:00
CycleCollectedJSContext.h Bug 1661293 - Make nsJSContext::MaybePokeGC trigger eager minor GCs, and change the naming to support later adding EAGER_ALLOC_TRIGGER major GCs r=jonco,smaug 2022-06-06 22:53:11 +00:00
CycleCollectedJSRuntime.cpp Bug 1774651 - Add a MinorGC perfstat measurement r=smaug 2022-06-30 17:36:32 +00:00
CycleCollectedJSRuntime.h Bug 1661293 - Make nsJSContext::MaybePokeGC trigger eager minor GCs, and change the naming to support later adding EAGER_ALLOC_TRIGGER major GCs r=jonco,smaug 2022-06-06 22:53:11 +00:00
Debug.cpp
Debug.h
DebuggerOnGCRunnable.cpp
DebuggerOnGCRunnable.h
DeferredFinalize.cpp
DeferredFinalize.h Bug 1733308 - Fix non-unified builds errors in xpcom/base. r=xpcom-reviewers,mccr8 2021-10-01 01:49:16 +00:00
EnumeratedArrayCycleCollection.h
ErrorList.py Bug 1758789 - part13 : fallback to our state machine when the external engine fails to work. r=jolin 2022-06-30 22:34:20 +00:00
ErrorNames.cpp Bug 1740543 - Expose xpcom's GetErrorName() to JS. r=xpcom-reviewers,nika 2021-12-09 14:00:39 +00:00
ErrorNames.h
GkRustUtils.cpp Bug 1724152: Replace GkRustUtils::GenerateUUID with nsID::GenerateUUID. r=ckerschb 2021-11-04 08:55:46 +00:00
GkRustUtils.h Bug 1724152: Replace GkRustUtils::GenerateUUID with nsID::GenerateUUID. r=ckerschb 2021-11-04 08:55:46 +00:00
HoldDropJSObjects.cpp
HoldDropJSObjects.h Bug 1712725 - Disallow using HoldJSObjects/DropJSObjects for non-nsISupports classes that don't have a CC participant. r=mccr8 2021-05-27 08:35:41 +00:00
IntentionalCrash.h
JSObjectHolder.cpp
JSObjectHolder.h
LogCommandLineHandler.cpp Bug 1684173 - Add newline character at end of files when missing r=sylvestre,geckoview-reviewers,agi 2021-01-07 08:53:08 +00:00
LogCommandLineHandler.h
LogModulePrefWatcher.cpp
LogModulePrefWatcher.h
Logging.cpp Bug 1766561 - Use %lu for Windows Error types (DWORD). r=rkraesig,xpcom-reviewers,application-update-reviewers,mhowell,bobowen,necko-reviewers,keeler,media-playback-reviewers,bytesized,barret,alwu,kershaw 2022-05-03 20:49:07 +00:00
Logging.h Bug 1678062 - Remove unnecessary includes. r=andi 2020-11-23 16:12:02 +00:00
MacHelpers.h
MacHelpers.mm Bug 1692391 - Replace the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NSRESULT macros with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(NS_ERROR_FAILURE). r=haik 2021-02-16 22:55:20 +00:00
MacStringHelpers.h
MacStringHelpers.mm Bug 1692391 - Replace the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NSRESULT macros with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(NS_ERROR_FAILURE). r=haik 2021-02-16 22:55:20 +00:00
MemoryInfo.cpp Bug 1701368 - Part1: Extract nsAvailableMemoryWatcher as AvailableMemoryWatcherWin.cpp. r=gsvelto 2021-07-06 22:30:57 +00:00
MemoryInfo.h Bug 1678062 - Remove unnecessary includes. r=andi 2020-11-23 16:12:02 +00:00
MemoryMapping.cpp Bug 1652813 - Provide an API to get the resident unique memory of a process without waking it up;r=njn 2020-08-20 13:57:40 +00:00
MemoryMapping.h Bug 1701368 - Part1: Extract nsAvailableMemoryWatcher as AvailableMemoryWatcherWin.cpp. r=gsvelto 2021-07-06 22:30:57 +00:00
MemoryPressureLevelMac.h Bug 1730066 - Enable tab unloading on macOS r=spohl 2021-10-21 04:43:35 +00:00
MemoryReportingProcess.h Bug 1678062 - Remove unnecessary includes. r=andi 2020-11-23 16:12:02 +00:00
MemoryTelemetry.cpp Bug 1733308 - Fix non-unified builds errors in xpcom/base. r=xpcom-reviewers,mccr8 2021-10-01 01:49:16 +00:00
MemoryTelemetry.h Bug 1689182 - Collect content memory telemetry from the parent process, r=kmag 2021-01-28 19:48:03 +00:00
NSPRLogModulesParser.cpp Bug 1636888 - Allow specifying entire rust modules in MOZ_LOG r=froydnj 2020-06-10 07:18:40 +00:00
NSPRLogModulesParser.h
OwningNonNull.h Bug 1766768 - Fix move constructor of OwningNonNull(RefPtr<>&&) to actually move. r=mccr8 2022-04-29 11:32:07 +00:00
RLBoxSandboxPool.cpp Bug 1744460 part 2 - Update woff2 RLBoxSandboxPool to track minimum sandbox size r=bholley 2021-12-09 00:01:17 +00:00
RLBoxSandboxPool.h Bug 1762605 - RLBox thread-safety annotations r=bholley 2022-04-01 20:43:57 +00:00
RLBoxUtils.h Bug 1747514 - Fix some pointer arithmetic issues in RLBox. r=shravanrn 2021-12-25 06:00:25 +00:00
ShutdownPhase.h Bug 1766572: Part 1 - Remove obsolete ShutdownPhase::XPCOMShutdownLoaders. r=xpcom-reviewers,nika 2022-05-13 15:47:52 +00:00
SizeOfState.h Bug 1678062 - Remove unnecessary includes. r=andi 2020-11-23 16:12:02 +00:00
StaticLocalPtr.h
StaticMonitor.h Bug 1519636 - Reformat recent changes to the Google coding style r=andi,media-playback-reviewers,necko-reviewers,padenot,dragana 2022-06-07 12:32:55 +00:00
StaticMutex.h Bug 1207753 - Base thread-safety attribution support r=nika 2022-03-16 23:01:41 +00:00
StaticPtr.h Bug 1774158 - Use RefPtrTraits in StaticRefPtr. r=xpcom-reviewers,barret 2022-06-14 13:33:27 +00:00
TupleCycleCollection.h Bug 1678062 - Remove unnecessary includes. r=andi 2020-11-23 16:12:02 +00:00
components.conf Bug 1731890 - Adding Utility process with basic sandbox r=agi,nika,bobowen 2022-01-12 20:52:58 +00:00
moz.build Bug 1747165 - Replace TK_FLAGS/TK_LIBS with MOZ_GTK3_FLAGS/MOZ_GTK3_LIBS. r=firefox-build-system-reviewers,andi 2021-12-23 20:29:07 +00:00
nsAlgorithm.h Bug 1678062 - Remove unnecessary includes. r=andi 2020-11-23 16:12:02 +00:00
nsAutoRef.h Bug 1601556 - Make Result<V, E> a literal type if V and E are literal types and PackingStrategy is not Variant. r=emilio 2021-03-23 12:35:19 +00:00
nsCOMPtr.cpp Bug 1661242 - Declare nsCOMPtr_base::begin_assignment MOZ_ALWAYS_INLINE in release builds. r=froydnj 2020-09-03 14:45:09 +00:00
nsCOMPtr.h Bug 1729011 - Change dead link to MDN in nsCOMPtr.h to reference source docs. r=xpcom-reviewers,mccr8 DONTBUILD 2021-09-03 15:14:01 +00:00
nsCRTGlue.cpp Bug 1764262 - Redirect MOZ_LOG output to Nyx when fuzzing. r=xpcom-reviewers,nika 2022-04-25 19:12:23 +00:00
nsCRTGlue.h Bug 1746052, further restrict the characters that are allowed in filenames, as save as doesn't allow these, r=mccr8 2022-05-06 10:00:54 +00:00
nsClassInfoImpl.cpp
nsCom.h
nsConsoleMessage.cpp Bug 1696856 - [devtools] Move isForwardedFromContentProcess to nsConsoleMessage. r=baku. 2021-03-10 12:44:22 +00:00
nsConsoleMessage.h Bug 1696856 - [devtools] Move isForwardedFromContentProcess to nsConsoleMessage. r=baku. 2021-03-10 12:44:22 +00:00
nsConsoleService.cpp Merge autoland to mozilla-central. a=merge 2022-03-24 11:35:23 +02:00
nsConsoleService.h Bug 1207753 - Various xpcom thread-safety annotations r=nika 2022-03-23 22:22:51 +00:00
nsCrashOnException.cpp
nsCrashOnException.h
nsCycleCollectionNoteChild.h
nsCycleCollectionNoteRootCallback.h Bug 1678062 - Remove unnecessary includes. r=andi 2020-11-23 16:12:02 +00:00
nsCycleCollectionParticipant.cpp
nsCycleCollectionParticipant.h Bug 1757635 - Part 1: Add `using ::ImplCycleCollectionUnlink` inside NS_IMPL_CYCLE_COLLECTION_WITH_JS_MEMBERS r=mccr8 2022-05-25 23:41:25 +00:00
nsCycleCollectionTraversalCallback.h Bug 1741246 - Pass JS::GCCellPtr in nsCycleCollectionTraversalCallback::NoteJSChild(). r=jonco 2021-11-16 14:52:54 +00:00
nsCycleCollector.cpp Bug 1776243 - Add a more explicit assertion in NS_CycleCollectorSuspect3(). r=smaug 2022-06-27 17:16:11 +00:00
nsCycleCollector.h Bug 1732161 - Track CCReason for all cycle collections (replacing ccType) r=smaug 2021-10-14 18:15:40 +00:00
nsCycleCollectorTraceJSHelpers.cpp Bug 1733308 - Fix non-unified builds errors in xpcom/base. r=xpcom-reviewers,mccr8 2021-10-01 01:49:16 +00:00
nsDebug.h Bug 1514936, part 2 - Drop the outer arguments from static components. r=xpcom-reviewers,nika 2022-05-17 20:24:19 +00:00
nsDebugImpl.cpp Bug 1774864 - Cleanup xpcom/ includes r=sylvestre 2022-06-24 07:13:59 +00:00
nsDebugImpl.h Bug 1514936, part 2 - Drop the outer arguments from static components. r=xpcom-reviewers,nika 2022-05-17 20:24:19 +00:00
nsDumpUtils.cpp Bug 1774864 - Cleanup xpcom/ includes r=sylvestre 2022-06-24 07:13:59 +00:00
nsDumpUtils.h Bug 1207753 - Various xpcom thread-safety annotations r=nika 2022-03-23 22:22:51 +00:00
nsError.h Bug 1678062 - Remove unnecessary includes. r=andi 2020-11-23 16:12:02 +00:00
nsErrorService.cpp Bug 1733308 - Fix non-unified builds errors in xpcom/base. r=xpcom-reviewers,mccr8 2021-10-01 01:49:16 +00:00
nsErrorService.h
nsGZFileWriter.cpp
nsGZFileWriter.h Bug 1519636 - Reformat with clang-format-11 to the Google coding style r=andi,sg,geckoview-reviewers,snorp 2020-11-18 09:05:59 +00:00
nsIAvailableMemoryWatcherBase.idl Bug 1729911 - Define minInactiveDurationInMS not to unload fresh tabs. r=NeilDeakin 2021-10-20 23:22:57 +00:00
nsIClassInfoImpl.h Bug 1519636 - Reformat recent changes to the Google coding style r=andi,necko-reviewers,dragana 2020-10-06 16:12:00 +00:00
nsIConsoleListener.idl
nsIConsoleMessage.idl Bug 1696856 - [devtools] Move isForwardedFromContentProcess to nsConsoleMessage. r=baku. 2021-03-10 12:44:22 +00:00
nsIConsoleService.idl Bug 1189827: Move logMessageWithMode to nsIConsoleService. r=smaug 2021-11-29 14:52:29 +00:00
nsICycleCollectorListener.idl
nsID.cpp Bug 1745613 - Change nsID::GenerateUUID() to not use NSS's RNG off the main thread. r=keeler 2022-01-05 03:26:38 +00:00
nsID.h Bug 25886 - Remove NS_DEFINE_IID. r=xpcom-reviewers,nika 2022-04-21 14:47:27 +00:00
nsIDUtils.h Bug 1726648 - Add a helper to trim brackets from nsID r=mccr8,smaug 2021-08-23 10:54:11 +00:00
nsIDebug2.idl (Bug 1635487) Wired up sync logging for extension pref storage r=lina,markh 2020-06-27 19:15:17 +00:00
nsIErrorService.idl
nsIException.idl
nsIGZFileWriter.idl Bug 1657033 - Use Span<const char> in JSONWriter - r=froydnj 2020-09-14 02:33:20 +00:00
nsIInterfaceRequestor.idl
nsIInterfaceRequestorUtils.cpp
nsIInterfaceRequestorUtils.h
nsIMacPreferencesReader.idl
nsIMacUtils.idl
nsIMemory.idl
nsIMemoryInfoDumper.idl Bug 1653671 - Add aMinimizeMemoryUsage argument to dumpMemoryReportsToNamedFile(). r=froydnj 2020-08-21 17:11:03 +00:00
nsIMemoryReporter.idl Bug 1586236 - Use memory resource notifications to detect low memory scenarios on Windows. r=gsvelto 2021-03-31 15:18:05 +00:00
nsIMessageLoop.idl
nsINIParser.cpp Bug 1184468 - Use nsTHashtable::Keys where possible. r=xpcom-reviewers,nika 2021-03-24 17:56:50 +00:00
nsINIParser.h
nsISecurityConsoleMessage.idl
nsISizeOf.h
nsISupports.idl
nsISupportsBase.h
nsISupportsImpl.cpp Bug 1678463 - Part 1: Add _WITH_DELETE_ON_EVENT_TARGET macros to nsISupportsImpl, r=mccr8 2020-12-14 18:30:51 +00:00
nsISupportsImpl.h Bug 1738106 - Part 2: Allow XPCOM classes to use SupportsThreadSafeWeakPtr, r=glandium,xpcom-reviewers 2022-05-02 20:37:34 +00:00
nsISupportsUtils.h
nsIUUIDGenerator.idl
nsIVersionComparator.idl
nsIWeakReference.idl Bug 1778211 - Reject xpidl CDATA containing 'virtual', r=xpcom-reviewers,necko-reviewers,mccr8,dragana 2022-07-06 14:53:06 +00:00
nsIWeakReferenceUtils.h
nsInterfaceRequestorAgg.cpp Bug 1637500 - P2. Rename methods as they are not always dealing with "threads". r=froydnj 2020-06-23 05:05:36 +00:00
nsInterfaceRequestorAgg.h
nsMacPreferencesReader.h
nsMacPreferencesReader.mm Bug 1733308 - Fix non-unified builds errors in xpcom/base. r=xpcom-reviewers,mccr8 2021-10-01 01:49:16 +00:00
nsMacUtilsImpl.cpp Bug 1635428 - Part 1: Move mozilla::IsDevelopmentBuild to Omnijar.h r=mccr8 2022-03-31 23:36:25 +00:00
nsMacUtilsImpl.h Bug 1762469: xpcom memory reporter cleanup r=nika 2022-04-04 22:57:37 +00:00
nsMaybeWeakPtr.h
nsMemory.cpp
nsMemory.h Bug 1678062 - Remove unnecessary includes. r=andi 2020-11-23 16:12:02 +00:00
nsMemoryImpl.cpp Bug 1514936, part 2 - Drop the outer arguments from static components. r=xpcom-reviewers,nika 2022-05-17 20:24:19 +00:00
nsMemoryImpl.h Bug 1514936, part 2 - Drop the outer arguments from static components. r=xpcom-reviewers,nika 2022-05-17 20:24:19 +00:00
nsMemoryInfoDumper.cpp Bug 1732161 - Track CCReason for all cycle collections (replacing ccType) r=smaug 2021-10-14 18:15:40 +00:00
nsMemoryInfoDumper.h
nsMemoryReporterManager.cpp Bug 1777220 - Remove memory map assertions r=glandium 2022-06-30 04:11:11 +00:00
nsMemoryReporterManager.h Bug 1762469: xpcom memory reporter cleanup r=nika 2022-04-04 22:57:37 +00:00
nsMessageLoop.cpp Bug 1514936, part 2 - Drop the outer arguments from static components. r=xpcom-reviewers,nika 2022-05-17 20:24:19 +00:00
nsMessageLoop.h Bug 1514936, part 2 - Drop the outer arguments from static components. r=xpcom-reviewers,nika 2022-05-17 20:24:19 +00:00
nsObjCExceptions.h Bug 1694000 - Ignore "Missing Touches." exception when it bubbles up to the event loop. r=spohl 2021-02-20 22:11:34 +00:00
nsObjCExceptions.mm Bug 1694000 - Ignore "Missing Touches." exception when it bubbles up to the event loop. r=spohl 2021-02-20 22:11:34 +00:00
nsQueryObject.h Bug 1632099 - P1. Have nsQueryObject accept const smart pointers. r=froydnj 2020-06-22 14:42:16 +00:00
nsSecurityConsoleMessage.cpp
nsSecurityConsoleMessage.h
nsSystemInfo.cpp Bug 1763392 - Generate SDK bindings for nested Java classes as nested C++ classes. r=agi,media-playback-reviewers,bryce 2022-04-07 11:12:20 +00:00
nsSystemInfo.h Bug 1737177: Add `nsSystemInfo` runtime flag for whether running application is running under Microsoft Windows S Mode. r=mhowell 2021-11-16 15:11:32 +00:00
nsTraceRefcnt.cpp Backed out 9 changesets (bug 1772006) causing build bustages on nsTString.cpp. CLOSED TREE 2022-06-11 01:13:42 +03:00
nsTraceRefcnt.h Bug 1699375 - Move WalkTheStack to mozglue. r=nika 2021-03-22 21:25:30 +00:00
nsUUIDGenerator.cpp Bug 1723674 - Move nsUUIDGenerator logic to new nsID::GenerateUUID() factory functions that use nsRandomGenerator. r=keeler 2021-10-14 03:28:49 +00:00
nsUUIDGenerator.h Bug 1723674 - Move nsUUIDGenerator logic to new nsID::GenerateUUID() factory functions that use nsRandomGenerator. r=keeler 2021-10-14 03:28:49 +00:00
nsVersionComparator.cpp
nsVersionComparator.h Bug 1651136 - Part 1: Allow (and mark) certain xpcom/ headers as non-XPCOM. r=froydnj,bytesized 2020-07-08 22:57:26 +00:00
nsVersionComparatorImpl.cpp
nsVersionComparatorImpl.h
nsWeakReference.cpp Bug 1778211 - Reject xpidl CDATA containing 'virtual', r=xpcom-reviewers,necko-reviewers,mccr8,dragana 2022-07-06 14:53:06 +00:00
nsWeakReference.h
nsWindowsHelpers.h Bug 1695817 - Part 6: Show name and publisher of an application owning a module. r=Gijs,fluent-reviewers,mhowell 2021-05-28 22:35:59 +00:00
nscore.h Bug 1746540 - Move --enable-logrefcnt to python configure. r=nika,firefox-build-system-reviewers,mhentges 2021-12-18 00:32:35 +00:00
nsrootidl.idl Bug 1778211 - Reject xpidl CDATA containing 'virtual', r=xpcom-reviewers,necko-reviewers,mccr8,dragana 2022-07-06 14:53:06 +00:00