gecko-dev/devtools/server
Nicolas Chevobbe f8d23aaa81 Bug 1733539 - [devtools] Fix NodeActor#waitForFrameLoad. r=jdescottes.
`waitForFrameLoad` was waiting for the `DOMContentLoaded` if the document `readyState`
wasn't "complete".
But `readyState` can be "interactive", which means `DOMContentLoaded` was already
emitted. In such case, `waitForFrameLoad` would wait forever.
This would cause blank markup view in the inspector panel if a node was selected
in an iframe and the page would be passed the "loading" `readyState`, but still
in the "interactive" phase.

The fix is simple: only wait for `DOMContentLoaded` if `readyState` is "loading".

The existing test we have for checking selecting node in iframe and reloading
is modified; we include a slow loading image in the iframe, which will make it
stay in the "interactive" state a bit longer.
Without the fix, the test was failing nicely, highlighting the issue.

Differential Revision: https://phabricator.services.mozilla.com/D127282
2021-10-05 08:12:31 +00:00
..
actors Bug 1733539 - [devtools] Fix NodeActor#waitForFrameLoad. r=jdescottes. 2021-10-05 08:12:31 +00:00
connectors Bug 1732120 - [devtools] Remove FrameTargetActor in favor of WindowGlobalTargetActor. r=nchevobbe,devtools-backward-compat-reviewers 2021-09-27 12:16:12 +00:00
performance Bug 1732120 - [devtools] Rename BrowsingContextTargetActor to WindowGlobalTargetActor. r=nchevobbe,devtools-backward-compat-reviewers 2021-09-27 12:16:11 +00:00
socket Bug 1700106 - [devtools] Remove now-useless eslint files related to mochitests. r=jdescottes,Standard8 2021-03-23 15:51:18 +00:00
startup Bug 1732120 - [devtools] Remove FrameTargetActor in favor of WindowGlobalTargetActor. r=nchevobbe,devtools-backward-compat-reviewers 2021-09-27 12:16:12 +00:00
tests Bug 1730165 - [devtools] Only notify about stylesheets of the target window when EFT is enabled. r=ochameau. 2021-10-05 08:11:23 +00:00
devtools-server-connection.js Bug 1699111 - [devtools] Rename transports onClosed callback to onTransportClosed. r=jdescottes 2021-04-13 13:44:24 +00:00
devtools-server.js Bug 1732120 - [devtools] Remove FrameTargetActor in favor of WindowGlobalTargetActor. r=nchevobbe,devtools-backward-compat-reviewers 2021-09-27 12:16:12 +00:00
moz.build Bug 1654103: Standardize on Black for Python code in `mozilla-central`. 2020-10-26 18:34:53 +00:00