gecko-dev/testing
Dave Townsend 9cbfdc7c2d Bug 1453751: Load favicons in the content process. r=mak, r=gijs, r=aswan
Summary:
This moves the load of favicons into the content process. We use the same logic
for finding favicons (based on waiting until none have shown up for a short
time) but then load the favicon and convert it to a data uri which we then
dispatch to the parent process. Along the way this fixes asssociating the load
with the tab for WebExtension and devtools, fixes CSP usage for the load, fixes
expiry detection of the favicon and stops us from loading the same resource
twice.

This change also merges the prefs browser.chrome.site_icons and
browser.chrome.favicons leaving just the former controlling favicon loading. It
adds the pref browser.chrome.guess_favicon to allow disabling guessing where
a favicon might be located for a site (at <hostname>/favicon.ico). This is
mainly to allow disabling this in tests where those additional yet automatic
requests are uninteresting for the test.

There are multiple clean-ups that can follow this but this is a first step along
that path.

MozReview-Commit-ID: E0Cs59UnxaF

Reviewers: mak

Tags: #secure-revision

Bug #: 1453751

Differential Revision: https://phabricator.services.mozilla.com/D1672
Differential Revision: https://phabricator.services.mozilla.com/D1673
Differential Revision: https://phabricator.services.mozilla.com/D1674

--HG--
rename : browser/base/content/test/general/browser_bug408415.js => browser/base/content/test/favicons/browser_bug408415.js
rename : browser/base/content/test/general/browser_bug550565.js => browser/base/content/test/favicons/browser_bug550565.js
rename : browser/base/content/test/general/browser_favicon_change.js => browser/base/content/test/favicons/browser_favicon_change.js
rename : browser/base/content/test/general/browser_favicon_change_not_in_document.js => browser/base/content/test/favicons/browser_favicon_change_not_in_document.js
rename : browser/base/content/test/general/browser_subframe_favicons_not_used.js => browser/base/content/test/favicons/browser_subframe_favicons_not_used.js
rename : browser/base/content/test/general/file_bug970276_favicon1.ico => browser/base/content/test/favicons/file_bug970276_favicon1.ico
rename : browser/base/content/test/general/file_bug970276_favicon1.ico => browser/base/content/test/favicons/file_bug970276_favicon2.ico
rename : browser/base/content/test/general/file_bug970276_popup1.html => browser/base/content/test/favicons/file_bug970276_popup1.html
rename : browser/base/content/test/general/file_bug970276_popup2.html => browser/base/content/test/favicons/file_bug970276_popup2.html
rename : browser/base/content/test/general/file_favicon_change.html => browser/base/content/test/favicons/file_favicon_change.html
rename : browser/base/content/test/general/file_favicon_change_not_in_document.html => browser/base/content/test/favicons/file_favicon_change_not_in_document.html
rename : browser/base/content/test/general/file_bug970276_favicon1.ico => browser/base/content/test/favicons/file_generic_favicon.ico
rename : browser/base/content/test/general/file_with_favicon.html => browser/base/content/test/favicons/file_with_favicon.html
extra : rebase_source : 53dc0c682bf61d5135fbca172ac5238b414a1771
2018-06-04 12:53:55 -07:00
..
awsy Bug 1442361 - Track explicit memory usage in the base content memory test. r=mccr8 2018-06-21 14:57:12 -07:00
config Bug 1462934 - Update Android AVD configs to use archives with build.prop included; r=me,a=test-only 2018-06-08 14:26:49 -06:00
crashtest
firefox-ui Bug 1466071: Part 3: Test session save when quitting quickly. r=whimboo 2018-06-08 09:09:07 -07:00
geckodriver Bug 1406006 - Get well formatted commit hash and commit date when building geckodriver. r=ato 2018-06-17 09:38:23 +02:00
gtest
jsshell Bug 1465360 - add asm.js-apps shell benchmark to jsshell-bench. r=ahal 2018-06-19 08:58:20 -04:00
marionette Bug 1469307 - Pretty-print Attr objects in format.pprint. r=whimboo 2018-06-18 16:05:39 +01:00
mochitest Bug 1453751: Load favicons in the content process. r=mak, r=gijs, r=aswan 2018-06-04 12:53:55 -07:00
modules
mozbase Bug 1470177 - Ensure numeric comparison of timeout in adb.py; r=bc 2018-06-25 10:09:48 -06:00
mozharness Bug 1395540 - Part 6: Fix missing whitespace. r=me 2018-06-22 12:13:35 -07:00
profiles Bug 1453751: Load favicons in the content process. r=mak, r=gijs, r=aswan 2018-06-04 12:53:55 -07:00
raptor Bug 1468535 - Port raptor-speedometer firefox to linux64; r=jmaher 2018-06-22 11:24:38 -04:00
runtimes
specialpowers Backed out 5 changesets (bug 1413098) for frequent failure in toolkit/content/tests/browser/browser_autoplay_policy_user_gestures.js on a CLOSED TREE 2018-05-31 15:21:15 +03:00
talos Bug 1456762 - Remove now unnecessary import-globals-from statements in html files. r=mossop 2018-06-16 08:21:33 +00:00
tools
tps Bug 1470122 - Bump mozinstall to 1.16.0; r=whimboo 2018-06-21 13:26:41 +01:00
web-platform Bug 1453751: Load favicons in the content process. r=mak, r=gijs, r=aswan 2018-06-04 12:53:55 -07:00
webdriver Bug 1441204 - Release webdriver crate 0.36.0. r=maja_zf 2018-06-14 13:28:33 -07:00
xpcshell Bug 1440022: disconnect push tests from actually running r=lina 2018-06-13 20:46:17 -04:00
README.txt
cppunittest.ini Bug 1468199 - remove references to b2g in test manifests r=jmaher 2018-06-12 14:57:00 +03:00
mach_commands.py Bug 1445975 - Add a basic mach command for running jsshell benchmarks, r=jmaher 2018-05-15 14:41:16 -04:00
moz.build
remotecppunittests.py
runcppunittests.py
testsuite-targets.mk

README.txt

Common testing tools for mozilla codebase projects, test suite definitions
for automated test runs, tests that don't fit anywhere else, and other fun
stuff