gecko-dev/other-licenses/nsis
Chris Peterson 35d27dc9bd Bug 1663217 - Remove MOZ_MUST_USE comment from NSIS BitsUtils.cpp. r=agashlin
The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard __attribute__((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.

BitsUtils.cpp only references MOZ_MUST_USE in a comment about forking a copy of mozilla::ScopeExit to remove some dependencies on other Mozilla header files (including MOZ_MUST_USE from mfbt/Attributes.h). [[nodiscard]] doesn't require a header file, so we can just remove this comment about MOZ_MUST_USE.

Differential Revision: https://phabricator.services.mozilla.com/D89296
2020-09-09 17:23:34 +00:00
..
Contrib Bug 1663217 - Remove MOZ_MUST_USE comment from NSIS BitsUtils.cpp. r=agashlin 2020-09-09 17:23:34 +00:00
Plugins Bug 1632463 - Part 2: Update WebBrowser.dll r=mhowell 2020-04-29 14:23:33 +00:00
nsisui.exe Bug 1596812 Part 1 - Update our custom nsisui.exe. r=agashlin 2020-04-20 03:06:07 +00:00