зеркало из https://github.com/mozilla/gecko-dev.git
caa66cb247
I don't understand what's happening in this code and would appreciate some guidance. It's possible that there are two different meanings of the word "offset" that are clashing here. SharedLibrary::GetOffset() means firstMappingStart - baseAddress. I get a feeling that the "zero offset" check here cares more about the mapping offset phdr.p_offset, but I'm not sure. Anyway, the purpose of this patch is the following: Now that the previous patch sets SharedLibrary::mOffset to something non-zero, this check breaks unwinding for the affected libraries. With the check removed, unwinding seems to work mostly fine, as evidenced by this profile: https://perfht.ml/2MBKzON But removing the check might break something else that I'm not seeing. Depends on D3835 Differential Revision: https://phabricator.services.mozilla.com/D3836 --HG-- extra : moz-landing-system : lando |
||
|---|---|---|
| .. | ||
| bloatview | ||
| clang-tidy | ||
| code-coverage | ||
| compare-locales | ||
| coverity | ||
| docs | ||
| fuzzing | ||
| infer | ||
| jprof | ||
| leak-gauge | ||
| lint | ||
| power | ||
| profiler | ||
| quitter | ||
| rb | ||
| rewriting | ||
| tryselect | ||
| update-packaging | ||
| mach_commands.py | ||
| moz.build | ||