зеркало из https://github.com/mozilla/gecko-dev.git
2a4eb30ed4
It turns out setting CARGO_PROFILE_RELEASE_LTO has unwanted side effects. First it's not actually strictly equivalent to using `cargo rustc -- -Clto`. For instance, it apparently also enables cross-language LTO in newer versions of cargo. Second, it changes the rust computed hash for all the dependencies of the crate being built with the variable set, which makes them diverge from when the same dependencies are built through another crate in the tree that is not LTOed. This effectively makes us build a _lot_ of crates twice, many of which are not cacheable. Since the original problem is that cargo >= 1.45 passes extra flags (`-C embed-bitcode=no`) to rustc that are incompatible with `-Clto`, and while it knows to adjust based on the `lto` setting in the build profile (which CARGO_PROFILE_RELEASE_LTO overrides the default of), cargo ignores flags passed via `cargo rustc -- ...` when making those adjustments. So, we need to override with `-C embed-bitcode=yes` on our own at the same time we pass `-Clto`. But doing that through `cargo rustc -- ...` is not enough because all the dependencies of the crate built with `-Clto` need to be built with `-C embed-bitcode=yes`. So we need to override with `RUSTFLAGS`, which will affect all the dependencies. But we also need to do this consistently across all crates, not only the dependencies of crates built with `-Clto`, otherwise we'd still end up building crates twice (once with and once without the override). Unfortunately, the `-C embed-bitcode=*` flag is also not supported in versions older than 1.45, so we have to avoid adding it on older versions. We unfortunately support a large range of versions of rustc (albeit only for tools/crashreporter), but we actually need to upgrade the smaller supported version because rustc < 1.38 doesn't support our top-level Cargo.lock. This makes the version check slightly less awful. Differential Revision: https://phabricator.services.mozilla.com/D84652 |
||
|---|---|---|
| .. | ||
| Moz | ||
| external | ||
| faster | ||
| makefiles | ||
| mozunit | ||
| tests | ||
| AB_rCD.mk | ||
| Makefile.in | ||
| MozZipFile.py | ||
| autoconf-js.mk.in | ||
| autoconf.mk.in | ||
| baseconfig.mk | ||
| check_js_msg_encoding.py | ||
| check_js_opcode.py | ||
| check_macroassembler_style.py | ||
| check_source_count.py | ||
| check_spidermonkey_style.py | ||
| check_vanilla_allocations.py | ||
| config.mk | ||
| createprecomplete.py | ||
| emptyvars-js.mk.in | ||
| emptyvars.mk.in | ||
| gcc-stl-wrapper.template.h | ||
| gcc_hidden.h | ||
| install.bat | ||
| make-stl-wrappers.py | ||
| make-system-wrappers.py | ||
| make-windows-h-wrapper.py | ||
| milestone.txt | ||
| moz.build | ||
| msvc-stl-wrapper.template.h | ||
| nsinstall.c | ||
| nsinstall.py | ||
| pathsub.c | ||
| pathsub.h | ||
| printconfigsetting.py | ||
| printprereleasesuffix.py | ||
| rebuild_check.py | ||
| recurse.mk | ||
| rules.mk | ||
| run-and-prefix.py | ||
| run_spidermonkey_checks.py | ||
| static-checking-config.mk | ||
| stl-headers.mozbuild | ||
| system-headers.mozbuild | ||
| version.mk | ||
| version_win.pl | ||
| windows-h-constant.decls.h | ||
| windows-h-unicode.decls.h | ||
| windows-h-wrapper.template.h | ||