gecko-dev/security
David Major dc67bfc9a3 Bug 1344629 - Part 6: Rewrite unnecessary uses of nsLiteralString. r=dbaron
There's an antipattern where nsLiteralString is used as an unnecessary intermediary in converting from CharT* to CharT*,
e.g. CallAFunctionThatTakesACharPointer(NS_LITERAL_CSTRING("foo").get());
or
NS_NAMED_LITERAL_STRING(foo, "abc");
CallAFunctionThatTakesACharPointer(foo.get());

This patch rewrites the callsites that can be trivially changed to use char*/char16_t*.

I'd somewhat like to remove nsTLiteralString::get() altogether, but in code that's less straightforward than these examples, get() is useful enough to keep.

MozReview-Commit-ID: Kh1rUziVllo

--HG--
extra : rebase_source : c21a65694d6e1c42fd88f73632f7ac8f38d005ae
2017-03-14 15:26:27 +13:00
..
apps Bug 1344829 - add BUG_COMPONENT to security/* files. r=keeler 2017-03-09 05:33:30 -05:00
certverifier Bug 1344829 - add BUG_COMPONENT to security/* files. r=keeler 2017-03-09 05:33:30 -05:00
manager Bug 1344629 - Part 6: Rewrite unnecessary uses of nsLiteralString. r=dbaron 2017-03-14 15:26:27 +13:00
nss Bug 1345368 - land NSS 09c491ef3b41, r=me 2017-03-13 06:01:21 +01:00
pkix Merge inbound to central, a=merge CLOSED TREE 2017-03-09 16:33:31 -08:00
sandbox Bug 1344711 - hand cleanup of remaining useless try blocks around get*Pref calls identified by eslint, r=jaws. 2017-03-07 15:29:48 +01:00
generate_certdata.py bug 1295937 - build NSS using gyp files. r=glandium 2016-11-09 12:37:09 -05:00
generate_mapfile.py Bug 1320690 - Re-enable bundled NSS on BSDs. r=ted 2016-11-28 14:33:36 +00:00
moz.build Bug 1344829 - add BUG_COMPONENT to security/* files. r=keeler 2017-03-09 05:33:30 -05:00
nss.symbols Bug 1342736 - Remove nsIX509CertDB.verifySignedManifestAsync(). r=mgoodwin 2017-02-26 20:25:36 +08:00