Apply suggestions from code review

Co-authored-by: Jan-Erik Rediger <badboy@archlinux.us>
This commit is contained in:
Alessio Placitelli 2021-05-05 12:15:09 +02:00 коммит произвёл GitHub
Родитель 268b0ba0e3
Коммит 0093a5db2c
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 4AEE18F83AFDEB23
1 изменённых файлов: 4 добавлений и 3 удалений

Просмотреть файл

@ -40,10 +40,11 @@ The following steps are required for applications using the Glean SDK, but not l
{{#include ../../shared/blockquote-stop.html}} {{#include ../../shared/blockquote-stop.html}}
##### Do not initialize with a fake value for `uploadEnabled`! ##### Initialize clean with the correct value for `uploadEnabled`!
> `Glean.initialize` **must** always be called with real values. > `Glean.initialize` must **always** be called with real values.
> For example, never call `Glean.initialize(upload=true)` if `true` is a placeholder value that later gets reset by `Glean.setUploadEnabled(false)`. > Always pass the user preferencen, e.g. `Glean.initialize(upload=userSettings.telemetry_enabled)` or the equivalent for your application.
> Never call `Glean.initialize(upload=true)` if `true` is a placeholder value that later gets reset by `Glean.setUploadEnabled(false)`.
> Depending on the provided placeholder value, this might trigger the generation of new client ids or the submission of bogus [`deletion-request` pings](../user/pings/deletion_request.md). > Depending on the provided placeholder value, this might trigger the generation of new client ids or the submission of bogus [`deletion-request` pings](../user/pings/deletion_request.md).
{{#include ../../../shared/tab_header.md}} {{#include ../../../shared/tab_header.md}}