Merge pull request #839 from Dexterp37/glean_upload_msg

1628348 - Rework the message for attempting to upload when disabled

glean-core/android/src/main/java/mozilla/telemetry/glean/Glean.kt

@@ -560,7 +560,7 @@ open class GleanInternalAPI internal constructor () {
         }
 
         if (!getUploadEnabled()) {
-            Log.e(LOG_TAG, "Glean must be enabled before submitting pings.")
+            Log.e(LOG_TAG, "Glean disabled: not submitting any pings.")
             return
         }
 

glean-core/ios/Glean/Glean.swift

@@ -384,7 +384,7 @@ public class Glean {
         }
 
         if !self.getUploadEnabled() {
-            self.logger.error("Glean must be enabled before sending pings")
+            self.logger.error("Glean disabled: not submitting any pings")
             return
         }
 

glean-core/python/glean/glean.py

@@ -444,7 +444,7 @@ class Glean:
             return
 
         if not cls.get_upload_enabled():
-            log.error("Glean must be enabled before submitting pings.")
+            log.error("Glean disabled: not submitting any pings.")
             return
 
         sent_ping = _ffi.lib.glean_submit_ping_by_name(

glean-core/src/lib.rs

@@ -532,7 +532,7 @@ impl Glean {
     /// * `reason`: A reason code to include in the ping
     pub fn submit_ping(&self, ping: &PingType, reason: Option<&str>) -> Result<bool> {
         if !self.is_upload_enabled() {
-            log::error!("Glean must be enabled before sending pings.");
+            log::error!("Glean disabled: not submitting any pings.");
             return Ok(false);
         }