зеркало из https://github.com/mozilla/glean.git
Ensure Python linting is ignoring the venv dir, not files
Also reformats the one file that was left out previously. [doc only]
This commit is contained in:
Родитель
ad57073dc7
Коммит
4f736e6986
4
Makefile
4
Makefile
|
@ -113,7 +113,7 @@ shellcheck: ## Run shellcheck against important shell scripts
|
||||||
|
|
||||||
lint-python: python-setup ## Run flake8 and black to lint Python code
|
lint-python: python-setup ## Run flake8 and black to lint Python code
|
||||||
$(GLEAN_PYENV)/bin/python3 -m flake8 glean-core/python/glean glean-core/python/tests
|
$(GLEAN_PYENV)/bin/python3 -m flake8 glean-core/python/glean glean-core/python/tests
|
||||||
$(GLEAN_PYENV)/bin/python3 -m black --check --exclude \(.venv\*\)\|\(.eggs\)\|_uniffi.py glean-core/python
|
$(GLEAN_PYENV)/bin/python3 -m black --check --exclude \(\.venv.\*\)\|\(.eggs\)\|_uniffi.py glean-core/python/glean glean-core/python/tests
|
||||||
$(GLEAN_PYENV)/bin/python3 -m mypy glean-core/python/glean
|
$(GLEAN_PYENV)/bin/python3 -m mypy glean-core/python/glean
|
||||||
|
|
||||||
.PHONY: lint-rust lint-kotlin lint-swift lint-yaml
|
.PHONY: lint-rust lint-kotlin lint-swift lint-yaml
|
||||||
|
@ -124,7 +124,7 @@ fmt-rust: ## Format all Rust code
|
||||||
cargo fmt --all
|
cargo fmt --all
|
||||||
|
|
||||||
fmt-python: python-setup ## Run black to format Python code
|
fmt-python: python-setup ## Run black to format Python code
|
||||||
$(GLEAN_PYENV)/bin/python3 -m black glean-core/python/glean glean-core/python/tests
|
$(GLEAN_PYENV)/bin/python3 -m black --exclude \(\.venv.\*\)\|\(.eggs\)\|_uniffi.py glean-core/python/glean glean-core/python/tests
|
||||||
|
|
||||||
.PHONY: fmt-rust fmt-python
|
.PHONY: fmt-rust fmt-python
|
||||||
|
|
||||||
|
|
|
@ -74,7 +74,9 @@ class EventMetricType:
|
||||||
|
|
||||||
self._inner.record(extra)
|
self._inner.record(extra)
|
||||||
|
|
||||||
def test_get_value(self, ping_name: Optional[str] = None) -> Optional[List[RecordedEvent]]:
|
def test_get_value(
|
||||||
|
self, ping_name: Optional[str] = None
|
||||||
|
) -> Optional[List[RecordedEvent]]:
|
||||||
"""
|
"""
|
||||||
Returns the stored value for testing purposes only.
|
Returns the stored value for testing purposes only.
|
||||||
|
|
||||||
|
|
Загрузка…
Ссылка в новой задаче