Formatting and linting

CODE_OF_CONDUCT.md

@@ -1,10 +1,11 @@
 # Community Participation Guidelines
 
-This repository is governed by Mozilla's code of conduct and etiquette guidelines. 
+This repository is governed by Mozilla's code of conduct and etiquette guidelines.
 For more details, please read the
-[Mozilla Community Participation Guidelines](https://www.mozilla.org/about/governance/policies/participation/). 
+[Mozilla Community Participation Guidelines](https://www.mozilla.org/about/governance/policies/participation/).
 
 ## How to Report
+
 For more information on how to report violations of the Community Participation Guidelines, please read our '[How to Report](https://www.mozilla.org/about/governance/policies/participation/reporting/)' page.
 
 <!--

package.json

@@ -49,7 +49,6 @@
     "minimist": "^1.2.0",
     "mocha": "^5.2.0",
     "npm-run-all": "^4.1.5",
-    "nsp": "^3.2.1",
     "prettier": "^1.10.2",
     "selenium-webdriver": "^3.6.0",
     "sinon": "4.0.0",
@@ -96,7 +95,6 @@
     "lint": "npm-run-all lint:*",
     "lint:eslint": "npm run eslint",
     "lint:fixpack": "fixpack",
-    "lint:nsp": "nsp check",
     "lint:tslint": "tslint src/**/*.ts",
     "lint:web-ext-lint": "web-ext lint",
     "postformat": "npm run eslint-fix && fixpack",

src/privileged/privacyContext/stubApi.js

@@ -16,18 +16,21 @@ this.privacyContext = class extends ExtensionAPI {
     const apiEventEmitter = new EventEmitter();
     return {
       privacyContext: {
-        /* @TODO no description given */
-        permanentPrivateBrowsing: async function permanentPrivateBrowsing() {
-          console.log("Called permanentPrivateBrowsing()");
-          return undefined;
-        },
-
-        /* @TODO no description given */
-        aPrivateBrowserWindowIsOpen: async function aPrivateBrowserWindowIsOpen() {
-          console.log("Called aPrivateBrowserWindowIsOpen()");
-          return undefined;
-        },
+        
+      /* @TODO no description given */
+      permanentPrivateBrowsing: async function permanentPrivateBrowsing  (  ) {
+        console.log("Called permanentPrivateBrowsing()", );
+        return undefined;
       },
-    };
+
+      /* @TODO no description given */
+      aPrivateBrowserWindowIsOpen: async function aPrivateBrowserWindowIsOpen  (  ) {
+        console.log("Called aPrivateBrowserWindowIsOpen()", );
+        return undefined;
+      },
+
+        
+      },
+    }
   }
-};
+}

src/studySetup.js

@@ -64,6 +64,7 @@ const baseStudySetup = {
 };
 
 async function isCurrentlyEligible(studySetup) {
+  let allowed;
   const dataPermissions = await browser.study.getDataPermissions();
   if (studySetup.studyType === "shield") {
     allowed = dataPermissions.shield;