Merge pull request #6136 from escattone/remove-unreachable-refresh-firefox-from-download-firefox-macro-1716

Remove unreachable Firefox refresh button from `download_firefox()` Jinja macro

kitsune/products/jinja2/products/product.html

@@ -2,7 +2,6 @@
 {% from 'includes/common_macros.html' import for_contributors_sidebar, download_firefox, featured_articles %}
 {% from 'products/includes/topic_macros.html' import help_topics, topic_metadata with context %}
 {% set crumbs = [(None, pgettext('DB: products.Product.title', product.title))] %}
-{% set scripts = ('products',) %}
 {% set classes = 'product-landing' %}
 {% set search_params = {'product': product.slug} %}
 {% set extra_body_attrs = {'data-product-slug': product.slug} %}

kitsune/sumo/jinja2/includes/common_macros.html

@@ -957,27 +957,6 @@
         <li><a href="https://www.mozilla.org/legal/privacy/firefox">{{ _('Privacy') }}</a></li>
       </ul>
     </div>
-    {#
-      afaict, this button is never shown. products.js is looking for a
-      data-latest-version attribute on the .download-button element above,
-      but it's not present. this should be fixed?
-    #}
-    <div class="refresh-firefox">
-      <p class="help-text">{{ _('Give Firefox a tune up') }}</p>
-      <a data-mozilla-ui-reset="reset" class="download-button sumo-button primary-button button-lg">
-        {{ _('Refresh Firefox') }}
-      </a>
-      <ul class="download-info text-body-xs">
-        <li><a class="reset-link" href="{{ url('wiki.document', 'refresh-firefox-reset-add-ons-and-settings') }}">
-            {{ _('How does it work?') }}
-          </a></li>
-        <li>
-          <a href="https://www.mozilla.org/firefox/new/#download-fx">
-            {{ _('Download a fresh copy') }}
-          </a>
-        </li>
-      </ul>
-    </div>
   </div>
 </div>
 {% endmacro %}

kitsune/sumo/static/sumo/js/products.js

@@ -1,17 +0,0 @@
-import UITour from "./libs/uitour";
-import compareVersions from "./compare_versions";
-
-(function($) {
-  'use strict';
-
-  $(function() {
-    var latestVersion = $('.download-firefox .download-button').data('latest-version');
-
-    UITour.getConfiguration('appinfo', function(info) {
-      if (compareVersions(info.version, latestVersion) === 0) {
-        $('.refresh-firefox').show();
-        $('.download-firefox').hide();
-      }
-    });
-  });
-})(jQuery);

kitsune/sumo/static/sumo/scss/layout/_products.scss

@@ -32,7 +32,3 @@
     margin: 0 p.$spacing-xs;
   }
 }
-
-.refresh-firefox {
-  display: none;
-}

webpack/entrypoints.js

@@ -54,9 +54,6 @@ const entrypoints = {
   "questions.geo": [
     "sumo/js/location.js",
   ],
-  products: [
-    "sumo/js/products.js",
-  ],
   topics: [
     "sumo/js/topics.js",
   ],