move circleci docker volume workaround outside of Makefile (#4703)

.circleci/config.yml

@@ -19,6 +19,11 @@ jobs:
       - run:
           name: Run mocha tests
           command: make test-js-ci
+      - run:
+          # copy synonym files to elasticsearch7 container, since circleci doesn't support volume mounts:
+          # https://circleci.com/docs/2.0/building-docker-images/#mounting-folders
+          name: Copy synonym files to elasticsearch7
+          command: docker cp ./kitsune/search/dictionaries/synonyms/. project_elasticsearch7_1:/usr/share/elasticsearch/config/synonyms
       - run:
           name: Run unit tests
           command: make test-ci

Makefile

@@ -127,9 +127,6 @@ build-ci: .docker-build-pull
 	touch .docker-build-ci
 
 test-ci: .docker-build-ci
-	# copy synonym files to elasticsearch7 container, since circleci doesn't support volume mounts:
-	# https://circleci.com/docs/2.0/building-docker-images/#mounting-folders
-	docker cp ./kitsune/search/dictionaries/synonyms/. project_elasticsearch7_1:/usr/share/elasticsearch/config/synonyms
 	${DC_CI} run test-image
 
 test-js-ci: .docker-build-ci