Remove requirement to tag deploys. Use -latest instead (#511)

.circleci/config.yml

@@ -133,32 +133,14 @@ workflows:
   version: 2
   build-and-deploy:
     jobs:
-      - unit-tests:
-          filters:
-            tags:
-              only: /.*/
-
+      - unit-tests
       - integration-tests:
           context: data-eng-circleci-tests
-          filters:
-            tags:
-              only: /.*/
-
-      - verify-requirements:
-          filters:
-            tags:
-              only: /.*/
-
-      - build-container:
-          filters:
-            tags:
-              only: /.*/
-
-      - docs-build:
-          filters:
-            tags:
-              only: /.*/
 
+      - verify-requirements
+      - build-container
+      - docs-build
+      
       - docs-deploy:
           requires:
             - docs-build
@@ -178,9 +160,18 @@ workflows:
             - integration-tests
             - build-container
           image: lookml-generator
-          tag: ${CIRCLE_TAG:-latest}
           filters:
-            tags:
-              only: /.*/
+            branches:
+              only: main
+      
+      - gcp-gcr/add-image-tag:
+          name: Add commit hash as docker image tag
+          context: data-eng-airflow-gcr
+          requires:
+            - Build and push lookml-generator
+          image: lookml-generator
+          source-tag: latest
+          target-tag: $CIRCLE_SHA1
+          filters:
             branches:
               only: main

Dockerfile

@@ -13,9 +13,9 @@ RUN groupadd --gid ${USER_ID} ${GROUP_ID} && \
 RUN apt-get update -qqy && \
     apt-get install -qqy python-dev build-essential git curl software-properties-common
 
-RUN apt-key adv --keyserver keyserver.ubuntu.com --recv-key C99B11DEB97541F0
-RUN apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-key C99B11DEB97541F0
-RUN apt-add-repository https://cli.github.com/packages
+RUN curl -fsSL https://cli.github.com/packages/githubcli-archive-keyring.gpg | dd of=/usr/share/keyrings/githubcli-archive-keyring.gpg \
+    && chmod go+r /usr/share/keyrings/githubcli-archive-keyring.gpg \
+    && echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/githubcli-archive-keyring.gpg] https://cli.github.com/packages stable main" | tee /etc/apt/sources.list.d/github-cli.list > /dev/null
 RUN apt update
 RUN apt install -y gh
 

README.md

@@ -119,7 +119,5 @@ is the following:
    should run using `make build && make run`, with changes reflected in LookML repos.
 2. Once merged, the changes should run on stage. They will run automatically after schema deploys,
    but they can be run manually by clearing the `lookml_generator_staging` task in [Airflow](https://workflow.telemetry.mozilla.org/tree?dag_id=probe_scraper).
-3. Once the changes are confirmed in stage, we first tag a new release here. Add a description with
-   what the new release includes. Finally, change the Airflow variable `lookml_generator_release_str`
-   to the version string you created when cutting the release. Re-run the DAG and the changes
+3. Once the changes are merged and a new release has been pushed, re-run the DAG and the changes
    should take effect.