48bceed842
svndiff.py: fix --add-new for JSON-format expectations
...
Review URL: https://codereview.chromium.org/19444003
git-svn-id: http://skia.googlecode.com/svn/trunk@10119 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 23:37:01 +00:00
4b38301a57
rebaseline.py: fix --add-new for JSON files
...
TBR=borenet
Review URL: https://codereview.chromium.org/19415002
git-svn-id: http://skia.googlecode.com/svn/trunk@10117 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 21:10:54 +00:00
61822a25d3
svndiff.py: add ability to compare before-and-after JSON files, not just raw images
...
This should complete step 3 of https://goto.google.com/ChecksumTransitionDetail !
R=borenet@google.com
Review URL: https://codereview.chromium.org/19112002
git-svn-id: http://skia.googlecode.com/svn/trunk@10113 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 18:56:32 +00:00
56799e2ee6
Add the lazy decoder from PictureFlags to SkImageDecoder
...
R=caryclark@google.com , scroggo@google.com
Author: sglez@google.com
Review URL: https://chromiumcodereview.appspot.com/19109002
git-svn-id: http://skia.googlecode.com/svn/trunk@10111 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 18:21:46 +00:00
ffcbdbfe6a
rebaseline.py: add --keep-going-on-failure option, off by default
...
R=borenet@google.com
Review URL: https://codereview.chromium.org/18092004
git-svn-id: http://skia.googlecode.com/svn/trunk@10109 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 17:35:39 +00:00
fc52e31a2a
Disable bench_pictures GPU config on Nexus 10
...
(RunBuilders:Perf-Android-Nexus10-MaliT604-Arm7-Release)
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/19192002
git-svn-id: http://skia.googlecode.com/svn/trunk@10074 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-15 13:50:35 +00:00
f37f2ccd75
clean up extra printfs in count_effects.lua
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10052 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-12 18:36:12 +00:00
6fb7756959
If a user requests a try on "all" builders, ask for confirmation
...
Addresses https://code.google.com/p/skia/issues/detail?id=1208
(SkipBuildbotRuns)
R=epoger@google.com
Review URL: https://codereview.chromium.org/18190006
git-svn-id: http://skia.googlecode.com/svn/trunk@10049 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-12 18:11:04 +00:00
585f89a8fe
rebaseline.py: until we fix bug 1410, keep going if we can't download an actual GM result
...
Review URL: https://codereview.chromium.org/19096007
git-svn-id: http://skia.googlecode.com/svn/trunk@10037 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-12 12:32:32 +00:00
66ba9f978f
rebaseline.py: skip any platforms we don't have actual results for, with warning message
...
R=borenet@google.com
Review URL: https://codereview.chromium.org/19052007
git-svn-id: http://skia.googlecode.com/svn/trunk@10022 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 19:20:30 +00:00
6dd1545ae9
Add script to verify that image files exist for every actual_result checksum
...
Should help with https://code.google.com/p/skia/issues/detail?id=1410
(SkipBuildbotRuns)
R=epoger@google.com
Review URL: https://codereview.chromium.org/18743006
git-svn-id: http://skia.googlecode.com/svn/trunk@10017 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 18:05:25 +00:00
9d5fedc5a6
add newline to bitmap rotation script output
...
BUG=
Review URL: https://codereview.chromium.org/18071007
git-svn-id: http://skia.googlecode.com/svn/trunk@10000 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 13:53:44 +00:00
76d119279e
Add safesync_url to build-tot-chromium.sh
...
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/18429006
git-svn-id: http://skia.googlecode.com/svn/trunk@9993 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 11:28:41 +00:00
2815c19c4d
add matrix objects to the lua bindings, as well as a lua script to find the proportion of image draw commands with different kinds of matrices
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9986 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 22:42:30 +00:00
2956387916
add paint:getEffects to return table of bools of a given effect is present on the paint
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9978 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 21:23:49 +00:00
6e1e785e4f
make svndiff.py executable
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9969 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 18:09:55 +00:00
3e7399fe28
Fix Housekeeper bot after r9961
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9965 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 17:23:47 +00:00
89fa4b9ee6
rebaseline.py: error out early if --expectations-root not pointing at gm-expected dir
...
BUG=https://code.google.com/p/skia/issues/detail?id=1403
R=senorblanco@chromium.org
Review URL: https://codereview.chromium.org/18416005
git-svn-id: http://skia.googlecode.com/svn/trunk@9961 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 16:54:10 +00:00
9de25e3fd4
rebaseline.py: use specified configs/tests as a FILTER over actually-run tests
...
Now that we have the actual-results.json file for every bot type, we know
the full set of tests that actual results are available for. If configs and/or
tests are specified, just use those as FILTERS over the actually available
results.
R=senorblanco@chromium.org
Review URL: https://codereview.chromium.org/18324018
git-svn-id: http://skia.googlecode.com/svn/trunk@9956 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 15:27:18 +00:00
387db0a2e5
add extra flag (currently unused) for high quality downsampling
...
BUG=
R=reed@google.com , robertphillips@google.com
Review URL: https://codereview.chromium.org/18386006
git-svn-id: http://skia.googlecode.com/svn/trunk@9927 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 14:13:04 +00:00
ba7ef37a04
rebaseline.py: look in gm-expected directory to see whether it's using git or svn
...
(before this change, it checked in the current working dir instead)
Review URL: https://codereview.chromium.org/18209010
git-svn-id: http://skia.googlecode.com/svn/trunk@9913 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-08 20:53:28 +00:00
a783f2bee8
rebaseline.py: if expectations dir contains JSON format results, update those instead of image files
...
Part of Step 3 in https://goto.google.com/ChecksumTransitionDetail
R=senorblanco@chromium.org
Review URL: https://codereview.chromium.org/18348018
git-svn-id: http://skia.googlecode.com/svn/trunk@9910 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-08 17:51:58 +00:00
34b73a2da1
rebaseline.py self-tests: prepare to add tests of JSON-format rebaselining
...
For now, rebaseline.py still does not support JSON-format rebaselining, so
the one self-test reports failure. But this change will allow us to test
the JSON-format rebaselining once rebaseline.py supports it.
R=scroggo@google.com
Review URL: https://codereview.chromium.org/18348015
git-svn-id: http://skia.googlecode.com/svn/trunk@9896 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-03 17:43:11 +00:00
0d19309080
Enable ASAN build
...
Requires Clang 3.1 or higher to be installed.
R=epoger@google.com
Review URL: https://codereview.chromium.org/18205007
git-svn-id: http://skia.googlecode.com/svn/trunk@9891 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-03 15:55:05 +00:00
491493119c
Add canFilterMaskGPU & filterMaskGPU to SkMaskFilter
...
https://codereview.chromium.org/18110012/
git-svn-id: http://skia.googlecode.com/svn/trunk@9888 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-03 15:34:35 +00:00
53953b457b
Create jsondiff tool to capture diffs between two JSON expectations files.
...
This will be used to view diffs before committing rebaselines, or to review
exactly what changed between two baseline revisions in the past.
Part of Step 3 in https://goto.google.com/ChecksumTransitionDetail
R=scroggo@google.com
Review URL: https://codereview.chromium.org/18103005
git-svn-id: http://skia.googlecode.com/svn/trunk@9878 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-02 20:22:27 +00:00
8575b4df41
Fix rebaseline.py self-test to account for r9859
...
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/18559002
git-svn-id: http://skia.googlecode.com/svn/trunk@9872 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-02 18:25:06 +00:00
63e9627fca
Add N4 to rebaseline.py
...
https://codereview.chromium.org/18023014/
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@9859 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-02 12:54:37 +00:00
f1754ec691
Replace SkPicture(SkStream) constructors with a factory.
...
SkPicture:
Remove the constructors which take an SkStream as an argument. Rather
than having to check a variable for success, the factory will return
NULL on failure.
Add a protected function for determining if an SkStream is an SKP
to share code with SkTimedPicture.
In the factory, check for a NULL SkStream.
Use a default decoder (from BUG:
https://code.google.com/p/skia/issues/detail?id=1325 )
SkDebuggerGUI:
Call SkPicture::CreateFromStream when necessary.
Write a factory for creating SkTimedPictures and use it.
Use the factory throughout tools.
Add include/lazy to utils and effects gyp include_dirs so SkPicture.h
can reference SkImageDecoder.h which references SkBitmapFactory.h (in
include/lazy).
Changes code Chromium uses, so this will require a temporary Skia
and then a change to Chromium to use the new Skia code.
TODO: Create a decoder that does nothing to be used by pinspect,
lua pictures, etc, and allow it to not assert in SkOrderedReadBuffer.
R=reed@google.com
Review URL: https://codereview.chromium.org/17113004
git-svn-id: http://skia.googlecode.com/svn/trunk@9822 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 21:32:00 +00:00
925cdca805
Skip the TIMESTAMP file.
...
Allows run_decoding_tests.py to pass the name of the folder, so
Android will not fail on account of the long adb command.
R=borenet@google.com
Review URL: https://codereview.chromium.org/18175008
git-svn-id: http://skia.googlecode.com/svn/trunk@9817 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 20:04:42 +00:00
5330e44796
Print the file being deserialized before deserializing.
...
That way it is easier to tell which file failed.
R=edisonn@google.com
Review URL: https://codereview.chromium.org/18219002
git-svn-id: http://skia.googlecode.com/svn/trunk@9811 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 17:52:53 +00:00
bc91e8b7d7
Fix run_decoding_tests on xoom.
...
Builder Test-Android-Xoom-Tegra2-Arm7-Debug fails run_decoding_tests
due to a couple of images. Add a way in skimage to ignore failures
if an image is expected to fail. Add an expectations file for xoom
that includes ignore-failure for the two files which are failing.
I have created https://code.google.com/p/skia/issues/detail?id=1382
to track the fact that these images fail to decode, despite the bot
showing green.
R=borenet@google.com
Review URL: https://codereview.chromium.org/18023008
git-svn-id: http://skia.googlecode.com/svn/trunk@9797 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-27 20:21:01 +00:00
aaeb87d32c
Add modulo flag to lua_pictures.
...
The intended use is spawning processes to save time.
R=caryclark@google.com , reed@google.com
Author: sglez@google.com
Review URL: https://chromiumcodereview.appspot.com/16950025
git-svn-id: http://skia.googlecode.com/svn/trunk@9736 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-21 21:45:20 +00:00
2b9424b342
Treat empty directory properly in skimage.
...
Instead of treating an empty directory as a file that failed to
decode, treat it as an empty directory.
Add self tests to check for this.
Builds upon from https://codereview.chromium.org/16866010 ,
which was reverted.
R=epoger@google.com
Review URL: https://codereview.chromium.org/17101029
git-svn-id: http://skia.googlecode.com/svn/trunk@9730 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-21 19:12:47 +00:00
3832da1e9c
Allow skimage expectations file to not exist.
...
If the file is not there, assume that all images are mismatches.
This allows running the test before the initial rebaseline.
R=epoger@google.com
Review URL: https://codereview.chromium.org/17448011
git-svn-id: http://skia.googlecode.com/svn/trunk@9690 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 19:12:53 +00:00
99a8ec9705
rebaseline.py: split image-based rebaselining, which will go away soon, into its own script
...
(part of step 3 in https://goto.google.com/ChecksumTransitionDetail )
also adds new --expectations-root option
R=scroggo@google.com , senorblanco@chromium.org
Review URL: https://codereview.chromium.org/17379004
git-svn-id: http://skia.googlecode.com/svn/trunk@9689 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 18:56:59 +00:00
6ef5a85bf4
force linking inside of skdiff
...
Review URL: https://codereview.chromium.org/16879012
git-svn-id: http://skia.googlecode.com/svn/trunk@9669 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 21:23:31 +00:00
7a11591e5e
Rename SkDrawCommand subclasses
...
SkDrawCommand subclass names are too generic and likely to clash in the default namespace.
This makes the header unusable in Chrome - for example, on Mac builders:
../../third_party/skia/src/utils/debugger/SkDrawCommand.h:251:7: error: redefinition of 'Comment'
class Comment : public SkDrawCommand {
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/AIFF.h:192:8: note: previous definition is here
struct Comment {
This CL renames SkDrawCommand subclasses using the following pattern: "${cmd}" -> "Sk${cmd}Command".
R=robertphillips@google.com , bungeman@google.com , djsollen@google.com
Author: fmalita@chromium.org
Review URL: https://chromiumcodereview.appspot.com/17101005
git-svn-id: http://skia.googlecode.com/svn/trunk@9667 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 20:20:55 +00:00
3da6c56f14
Allow files, making ".skp files or directories are required." less of a lie.
...
BUG=
R=reed@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/17151008
git-svn-id: http://skia.googlecode.com/svn/trunk@9665 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 18:35:58 +00:00
c7e1873c85
skimage: revert r9642
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9647 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 02:53:16 +00:00
e0433f1ad3
skimage: if --readPath points at an empty dir, create an empty expectations file
...
TBR=scroggo
Review URL: https://codereview.chromium.org/17294006
git-svn-id: http://skia.googlecode.com/svn/trunk@9642 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-17 19:34:58 +00:00
74feb1593a
skimage self-tests: confirm correctness of bitmap hash values
...
R=scroggo@google.com
Review URL: https://codereview.chromium.org/16866010
git-svn-id: http://skia.googlecode.com/svn/trunk@9591 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-13 19:12:05 +00:00
b8b3d90284
use ForceLinking to get codecs into lua_picture
...
BUG=
R=scroggo@google.com
Review URL: https://codereview.chromium.org/16847002
git-svn-id: http://skia.googlecode.com/svn/trunk@9549 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-12 20:07:10 +00:00
312e9a2f4c
add script to count glyph -vs- char draw calls
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9548 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-12 19:53:49 +00:00
bd4af3a9a6
rebaseline.py: keep going if we encounter an "INVALID" entry in the JSON file
...
Review URL: https://codereview.chromium.org/16826003
git-svn-id: http://skia.googlecode.com/svn/trunk@9543 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-12 19:07:00 +00:00
826ec81dbc
Small change that eliminates Parse Errors with encoded skps.
...
R=reed@google.com , caryclark@google.com , scroggo@google.com
Author: sglez@google.com
Review URL: https://chromiumcodereview.appspot.com/16034015
git-svn-id: http://skia.googlecode.com/svn/trunk@9538 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-12 18:28:36 +00:00
e78d20798d
rebaseline.py: try to download images from Google Storage before skia-autogen
...
This will allow us to complete Step 1 of https://goto.google.com/ChecksumTransitionDetail
R=scroggo@google.com
Review URL: https://codereview.chromium.org/16311011
git-svn-id: http://skia.googlecode.com/svn/trunk@9534 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-12 17:44:14 +00:00
dad5310ab6
rebaseline.py: add --add-new option, and only add new expectations if it is set
...
R=senorblanco@chromium.org
Review URL: https://codereview.chromium.org/16363006
git-svn-id: http://skia.googlecode.com/svn/trunk@9527 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-12 14:25:30 +00:00
cc2e1cf13c
rebaseline.py: improve readability of dry-run output
...
Split off of already-reviewed https://codereview.chromium.org/15789010/ ('rebaseline.py: --tests and --configs are now FILTERS within json results')
Review URL: https://codereview.chromium.org/16509006
git-svn-id: http://skia.googlecode.com/svn/trunk@9507 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-11 16:24:37 +00:00
bda4e91596
rebaseline.py: if rebaselining all platforms (not listing them explicitly), allow missing platforms
...
TBR=any-reviewer
Review URL: https://codereview.chromium.org/16782003
git-svn-id: http://skia.googlecode.com/svn/trunk@9506 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-11 16:16:02 +00:00
epoger@google.com
commit-bot@chromium.org
borenet@google.com
reed@google.com
humper@google.com
rmistry@google.com
robertphillips@google.com
scroggo@google.com
zachr@google.com