Граф коммитов

6 Коммитов

Автор SHA1 Сообщение Дата
rmistry@google.com 547012dc05 If the tree is closed then print information about contacting the sheriff.
The motivation for this CL is because it is not very obvious on how to submit when tree is closed in git.

Also added a section 'How to submit when tree is closed' in https://sites.google.com/site/skiadocs/developer-documentation/tree-sheriff

(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/13932026

git-svn-id: http://skia.googlecode.com/svn/trunk@8666 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-12 19:45:46 +00:00
rmistry@google.com f6c5f75b3c Display prompt for caution only if it is an interactive shell.
Created to fix https://code.google.com/p/skia/issues/detail?id=1197 : Skia Commit Queue quits if the tree is in Caution.

(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/13325002

git-svn-id: http://skia.googlecode.com/svn/trunk@8446 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-29 17:26:00 +00:00
rmistry@google.com 713276b143 Presubmit should check that source files end in atleast one newline
Review URL: https://codereview.appspot.com/7193063

git-svn-id: http://skia.googlecode.com/svn/trunk@7399 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 18:27:34 +00:00
rmistry@google.com c29934489f Display a warning prompt in presubmit if the tree status is in 'Caution'.
Example presubmit output:


Running presubmit upload checks ...

** Presubmit Warnings **
Tree state is: caution

***************
Please use caution in checkins
http://skia-tree-status-staging.appspot.com/banner-status?format=json
***************

There were presubmit warnings. Are you sure you wish to continue? (y/N):
Review URL: https://codereview.appspot.com/7200043

git-svn-id: http://skia.googlecode.com/svn/trunk@7337 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-23 14:35:58 +00:00
rmistry@google.com 6be0b4c63d Adding CheckChangeHasOnlyOneEol to upload and commit presubmit checks
Review URL: https://codereview.appspot.com/7151043

git-svn-id: http://skia.googlecode.com/svn/trunk@7247 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-17 14:50:59 +00:00
rmistry@google.com 8e3ff8cf0b Top-level presubmit script for Skia trunk that checks https://skia-tree-status.appspot.com/banner-status?format=json before a CL is committed.
gcl and git-cl will check for and run the presubmit script before you upload and/or commit your changes.
Review URL: https://codereview.appspot.com/7138046

git-svn-id: http://skia.googlecode.com/svn/trunk@7242 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-17 12:55:34 +00:00