commit-bot@chromium.org
e2b193ca5c
Revert of remove unused (by clients) SkUnitMapper ( https://codereview.chromium.org/283273002/ )
...
Reason for revert:
does not address all legacy callsites in chrome.
e.g.
[13:45:32.091872] ../../ui/native_theme/native_theme_base.cc:608:76: error: no matching function for call to ‘SkGradientShader::CreateLinear(SkPoint [3], SkColor [3], NULL, int, SkShader::TileMode, NULL)’
[13:45:32.091919] gradient_bounds, colors, NULL, 3, SkShader::kClamp_TileMode, NULL));
Original issue's description:
> remove unused (by clients) SkUnitMapper
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14761
R=robertphillips@google.com , scroggo@google.com , george@mozilla.com
TBR=george@mozilla.com , robertphillips@google.com , scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/287063009
git-svn-id: http://skia.googlecode.com/svn/trunk@14763 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-16 13:49:08 +00:00
commit-bot@chromium.org
ee0cac336c
remove unused (by clients) SkUnitMapper
...
BUG=skia:
R=robertphillips@google.com , scroggo@google.com , george@mozilla.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/283273002
git-svn-id: http://skia.googlecode.com/svn/trunk@14761 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-16 13:35:01 +00:00
commit-bot@chromium.org
8265fe61f0
Add polyfill for pointer events, change code to handle both mouse and pointer events equalls.
...
Mobile first!
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/286913005
git-svn-id: http://skia.googlecode.com/svn/trunk@14756 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-15 21:14:34 +00:00
commit-bot@chromium.org
9f3b925e76
Ping MySQL every minute in an attempt to keep the connection alive.
...
I've tried various MySQL server settings, and some TCP settings on the webtry server, none seem to keep the connection from hanging, so this is a brute-force solution.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/286543003
git-svn-id: http://skia.googlecode.com/svn/trunk@14720 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-14 12:55:34 +00:00
commit-bot@chromium.org
e003aecb30
remove unused Kernel33MaskFilter
...
R=robertphillips@google.com
TBR=robertphilips@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/280233002
git-svn-id: http://skia.googlecode.com/svn/trunk@14691 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-12 13:35:55 +00:00
commit-bot@chromium.org
3824bcdc66
Square pixels on zoom.
...
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/270073004
git-svn-id: http://skia.googlecode.com/svn/trunk@14587 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-06 13:04:35 +00:00
commit-bot@chromium.org
7e9fb8ddd6
Fix an issue with FireFox where it blurs when copying from a smaller to a
...
larger canvas. Work around that by drawing a rect for each pixel.
Also, add a drop shadow to the hex display so you can see it on a dark background color.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/261303002
git-svn-id: http://skia.googlecode.com/svn/trunk@14575 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-05 18:43:16 +00:00
commit-bot@chromium.org
166b7e4ad4
Add Doxygen link to titlebar.
...
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/268773002
git-svn-id: http://skia.googlecode.com/svn/trunk@14527 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-02 14:13:08 +00:00
commit-bot@chromium.org
d4ec0f1baa
Need checkerboard on history images too.
...
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/267723010
git-svn-id: http://skia.googlecode.com/svn/trunk@14526 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-02 12:56:43 +00:00
commit-bot@chromium.org
d9efd241bf
Add checkerboard under the image.
...
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/263853004
git-svn-id: http://skia.googlecode.com/svn/trunk@14519 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-01 20:52:12 +00:00
commit-bot@chromium.org
1e2a0cba37
Fix history on workspaces, where you couldn't click on old tries.
...
Also allow editing the first and last line because you might need
to do that to fix "old" tries that are already stored in the database.
By "old" I mean yesterday.
BUG=skia:
R=fmalita@google.com , fmalita@chromium.org
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/264833004
git-svn-id: http://skia.googlecode.com/svn/trunk@14516 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-01 20:17:18 +00:00
commit-bot@chromium.org
70222fadf0
Run Squid as a reverse caching proxy on port 80 and proxy the requests
...
to the server running on port 8000.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/261023002
git-svn-id: http://skia.googlecode.com/svn/trunk@14515 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-01 20:10:03 +00:00
commit-bot@chromium.org
a60538e954
Move to a theme that more closely matches what was there before.
...
Also, since it's a variation of "default" we can drop a whole file.
BUG=skia:
R=mtklein@google.com , fmalita@chromium.org
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/265703005
git-svn-id: http://skia.googlecode.com/svn/trunk@14507 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-01 19:21:33 +00:00
fmalita@google.com
950306ccf1
Use CodeMirror for WebTry snippets.
...
CodeMirror (http://codemirror.net ) is a rich code editor. This CL
adds the needed library and wires it with some minimal features, to
update the editor appearance to something like this:
http://codemirror.net/demo/theme.html?ambiance
We can later add Skia-customized features (custom keyword highlighting,
code completion, etc.).
(only tested locally)
R=jcgregorio@google.com , mtklein@google.com
Review URL: https://codereview.chromium.org/261693003
git-svn-id: http://skia.googlecode.com/svn/trunk@14499 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-01 15:14:56 +00:00
commit-bot@chromium.org
3dbcb10e75
Display the color at a point.
...
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/261533006
git-svn-id: http://skia.googlecode.com/svn/trunk@14494 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-01 12:54:25 +00:00
commit-bot@chromium.org
89126a6eda
Set ulimits for the compile stage.
...
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/265453010
git-svn-id: http://skia.googlecode.com/svn/trunk@14483 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 19:38:51 +00:00
commit-bot@chromium.org
715d88a4e9
Fix bug with starting at the home page.
...
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/260773002
git-svn-id: http://skia.googlecode.com/svn/trunk@14480 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 16:54:00 +00:00
commit-bot@chromium.org
2a8abc4552
Turn off warnings as errors, also allow c++11 extensions.
...
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/262603005
git-svn-id: http://skia.googlecode.com/svn/trunk@14478 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 16:49:34 +00:00
commit-bot@chromium.org
ea80046f79
Set TCP keepalive for MySQL connections.
...
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/268473002
git-svn-id: http://skia.googlecode.com/svn/trunk@14474 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 16:14:10 +00:00
commit-bot@chromium.org
51e3960e49
Add a magnifier lens to the image.
...
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/252993003
git-svn-id: http://skia.googlecode.com/svn/trunk@14424 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 21:03:34 +00:00
commit-bot@chromium.org
472f830351
Add git revision info to the titlebar
...
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/258033006
git-svn-id: http://skia.googlecode.com/svn/trunk@14407 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 15:33:31 +00:00
commit-bot@chromium.org
15b29811ca
Add pathops and capture stderr so we can get SkDebugf output.
...
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/252863002
git-svn-id: http://skia.googlecode.com/svn/trunk@14402 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 14:56:32 +00:00
commit-bot@chromium.org
edbd6ae92e
Use textContent instead of innerText.
...
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/249113004
git-svn-id: http://skia.googlecode.com/svn/trunk@14331 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-23 19:18:15 +00:00
reed@google.com
e0d9ce890e
Make drawText calls non-virtual, to ease SkFont and TextBlob ( https://codereview.chromium.org/243853006/ )"
...
associated chrome change (to be committed with DEPS roll)
https://codereview.chromium.org/248693002/
This reverts commit bfaceb53f58c9625b5471fcff35b5ca9ca3ae29c.
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/248083002
git-svn-id: http://skia.googlecode.com/svn/trunk@14321 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-23 04:00:17 +00:00
commit-bot@chromium.org
9004192101
Factor out common template code. Send stdout back to web page.
...
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/246823004
git-svn-id: http://skia.googlecode.com/svn/trunk@14317 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 21:13:45 +00:00
commit-bot@chromium.org
35ffc446b7
Adding the ability to click on the images in the history and have that load the code and image back into the editor space.
...
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/246393002
git-svn-id: http://skia.googlecode.com/svn/trunk@14310 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 19:32:06 +00:00
commit-bot@chromium.org
c3b738af50
Move to using HTML templates when filling out the workspace history.
...
This is a pre-step to having a history list that you can click on
and having the code moved back into the textarea, which will come
as a follow-up CL.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/244313007
git-svn-id: http://skia.googlecode.com/svn/trunk@14283 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 17:36:44 +00:00
commit-bot@chromium.org
fcbf1a1594
Update DESIGN, forgot to add new perms for the new tables.
...
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/243013005
git-svn-id: http://skia.googlecode.com/svn/trunk@14278 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 15:10:56 +00:00
commit-bot@chromium.org
1bc6ecc470
Picking from the wrong end of the workspace history list.
...
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/244133002
git-svn-id: http://skia.googlecode.com/svn/trunk@14275 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 14:57:50 +00:00
commit-bot@chromium.org
2dceedaa1e
Add support for serving up a view that can be iframed.
...
Also add support for creating the <iframe /> code needed for embedding.
This CL must land after https://codereview.chromium.org/240773003/
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/242613005
git-svn-id: http://skia.googlecode.com/svn/trunk@14266 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-19 14:50:23 +00:00
commit-bot@chromium.org
d04e1dd9e1
First pass at workspaces.
...
Ability to create new workspaces. Run tries in a workspace, each try is added to a history of a workspace.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/240773003
git-svn-id: http://skia.googlecode.com/svn/trunk@14265 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-19 13:55:50 +00:00
commit-bot@chromium.org
4bd8fdc04c
More sanitizing input.
...
Also fix issue with parsing time on MySQL.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/235953008
git-svn-id: http://skia.googlecode.com/svn/trunk@14195 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-15 00:43:51 +00:00
commit-bot@chromium.org
06aca01c23
Add /recent, a page that displays the last 20 tries.
...
Also broke out CSS as a separate file and added a title bar across both pages to easily navigate between Home and Recent.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/236193011
git-svn-id: http://skia.googlecode.com/svn/trunk@14190 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-14 20:12:08 +00:00
commit-bot@chromium.org
c81d1c40de
Now with permalinks.
...
Once we get a response from our XHR request update the URL to a permalink to that code.
This CL comes after https://codereview.chromium.org/235373002/
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/235323006
git-svn-id: http://skia.googlecode.com/svn/trunk@14187 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-14 18:53:10 +00:00
commit-bot@chromium.org
282333ffa2
Add design for sql storage, implementation of db that stores the data, not retrieving yet.
...
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/235373002
git-svn-id: http://skia.googlecode.com/svn/trunk@14175 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-14 14:54:07 +00:00
commit-bot@chromium.org
28fcae2ec7
Revert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. ( https://codereview.chromium.org/234243002/ )
...
Reason for revert:
Want to reland the original CL.
Original issue's description:
> Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/ )
>
> Reason for revert:
> breaking the Chrome deps roll.
> http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio
>
> Original issue's description:
> > Rename kPMColor_SkColorType to kN32_SkColorType.
> >
> > The new name better represents what this flag means.
> >
> > BUG=skia:2384
> >
> > Committed: http://code.google.com/p/skia/source/detail?r=14117
>
> TBR=reed@google.com ,scroggo@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14144
R=reed@google.com , bensong@google.com
TBR=bensong@google.com , reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/235523003
git-svn-id: http://skia.googlecode.com/svn/trunk@14156 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-11 17:15:40 +00:00
commit-bot@chromium.org
96edc24598
Revert of Rename kPMColor_SkColorType to kN32_SkColorType. ( https://codereview.chromium.org/227433009/ )
...
Reason for revert:
Chrome's side of define changes not easy to figure out quickly. Reverting this for DEPS roll for now.
Original issue's description:
> Rename kPMColor_SkColorType to kN32_SkColorType.
>
> The new name better represents what this flag means.
>
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14117
R=reed@google.com , scroggo@google.com
TBR=reed@google.com , scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384
Author: bensong@google.com
Review URL: https://codereview.chromium.org/234833003
git-svn-id: http://skia.googlecode.com/svn/trunk@14149 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-11 13:47:30 +00:00
commit-bot@chromium.org
d923288e50
Revert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. ( https://codereview.chromium.org/234243002/ )
...
Reason for revert:
fixes on the chrome side are landing (brettw), keep fingers crossed.
Original issue's description:
> Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/ )
>
> Reason for revert:
> breaking the Chrome deps roll.
> http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio
>
> Original issue's description:
> > Rename kPMColor_SkColorType to kN32_SkColorType.
> >
> > The new name better represents what this flag means.
> >
> > BUG=skia:2384
> >
> > Committed: http://code.google.com/p/skia/source/detail?r=14117
>
> TBR=reed@google.com ,scroggo@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14144
R=reed@google.com , scroggo@google.com
TBR=reed@google.com , scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384
Author: bensong@google.com
Review URL: https://codereview.chromium.org/233813004
git-svn-id: http://skia.googlecode.com/svn/trunk@14145 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-10 22:49:20 +00:00
commit-bot@chromium.org
757ebd20ef
Revert of Rename kPMColor_SkColorType to kN32_SkColorType. ( https://codereview.chromium.org/227433009/ )
...
Reason for revert:
breaking the Chrome deps roll.
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio
Original issue's description:
> Rename kPMColor_SkColorType to kN32_SkColorType.
>
> The new name better represents what this flag means.
>
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14117
R=reed@google.com , scroggo@google.com
TBR=reed@google.com , scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384
Author: bensong@google.com
Review URL: https://codereview.chromium.org/234243002
git-svn-id: http://skia.googlecode.com/svn/trunk@14144 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-10 22:36:34 +00:00
commit-bot@chromium.org
4f3452d62e
Flesh out the list of includes, also fix up README markdown
...
Currently only pulls in 'core' and 'effects'. Will add in gpu once we add an option to render via Mesa.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/232883004
git-svn-id: http://skia.googlecode.com/svn/trunk@14137 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-10 20:24:14 +00:00
commit-bot@chromium.org
c5367ec15d
Rename README and DESIGN so their markdown gets picked up my GitHub.
...
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/231883008
git-svn-id: http://skia.googlecode.com/svn/trunk@14130 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-10 14:13:23 +00:00
skia.committer@gmail.com
6b43f50761
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@14127 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-10 03:05:44 +00:00
commit-bot@chromium.org
0132a86876
Cleaned up the start page, added wait cursor, disabled Run button while waiting for results.
...
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/231853002
git-svn-id: http://skia.googlecode.com/svn/trunk@14121 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-09 22:54:02 +00:00
commit-bot@chromium.org
d6cab4a6af
I got too aggressive on the seccomp cleanup, turns out backports-debian doesn't have the linux/seccomp.h header.
...
Also forgot one last place that referenced syscall_reporter.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/231663002
git-svn-id: http://skia.googlecode.com/svn/trunk@14119 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-09 21:35:18 +00:00
commit-bot@chromium.org
149e9a107c
Rename kPMColor_SkColorType to kN32_SkColorType.
...
The new name better represents what this flag means.
BUG=skia:2384
R=reed@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/227433009
git-svn-id: http://skia.googlecode.com/svn/trunk@14117 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-09 20:45:29 +00:00
commit-bot@chromium.org
6d036c2e47
Initial code for webtry, a web application for allowing users to try out Skia.
...
Currently running at http://108.170.220.126:8000/
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/228693002
git-svn-id: http://skia.googlecode.com/svn/trunk@14114 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-09 18:59:44 +00:00
commit-bot@chromium.org
fc94829337
remove SK_SUPPORT_LEGACY_COMPATIBLEDEVICE_CONFIG
...
remove SK_SUPPORT_LEGACY_GETDEVICECAPABILITIES
BUG=skia:
R=robertphillips@google.com , bsalomon@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/227643005
git-svn-id: http://skia.googlecode.com/svn/trunk@14083 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-07 21:33:06 +00:00
commit-bot@chromium.org
e3beb6bd7d
SkNonCopyable should be used with private inheritance.
...
This is mostly s/public SkNoncopyable/SkNoncopyable/g.
Two classes (SkDrawLooper::Context and SkPicture::OperationList) don't actually work with SkNoncopyable because they introduce a virtual destructor. I added SkNoncopyableVirtual to make them work as intended. Sort of questionable whether they really need to be noncopyable in the first place, but I guess it doesn't hurt to keep the behavior the same.
BUG=skia:
R=reed@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/226183018
git-svn-id: http://skia.googlecode.com/svn/trunk@14081 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-07 19:34:38 +00:00
commit-bot@chromium.org
933e65d914
replace old SK_TRACE_EVENT macros with new TRACE_EVENT ones, and then remove them entirely!
...
BUG=skia:353
R=tomhudson@google.com , epoger@google.com , reed@google.com , egdaniel@google.com , bsalomon@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/196133033
git-svn-id: http://skia.googlecode.com/svn/trunk@13884 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-20 20:00:24 +00:00
commit-bot@chromium.org
44c48d062f
De-virtualize SkCanvas matrix ops.
...
This moves the matrix management logic into non-virtual SkCanvas
methods, and turns the virtuals into protected notifiers.
R=reed@google.com , robertphillips@google.com , bsalomon@google.com
BUG=skia:2297
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/195793012
git-svn-id: http://skia.googlecode.com/svn/trunk@13799 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-13 20:03:58 +00:00