d081cf661a
Pin to a newer version of ANGLE than M36 branch.
...
R=robertphillips@google.com
TBR=robertphillips@google.com
BUG=skia:
NOTRY=true
NOTREECHECKS=true
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/390433002
2014-07-11 06:51:59 -07:00
ffc75efc1a
Revert of Add alternate SkPicture::clone ( https://codereview.chromium.org/381193002/ )
...
Reason for revert:
Going to try to just remove the many-at-once clone interface
Original issue's description:
> Add alternate SkPicture::clone
>
> This adds an alternate version of SkPicture::clone for two reasons:
>
> 1) Chromium uses the SkPicture copy constructor to unpack the pictures from the old-style clone interface (and I would like to remove the copy ctor)
>
> 2) This is part of the long term plan to wean Chrome off of cloning. Once pictures are thread safe we will switch the new SkPicture::clone call to just return 'this'. From there it is a small step to removing clone entirely.
>
> Note that the two versions of clone() is temporary. Once this is landed (and rolled) I will land a Chrome-side patch to remove their use of the old interface (Use new SkPicture::clone interface - https://codereview.chromium.org/380323002/ )
>
> Committed: https://skia.googlesource.com/skia/+/e372e78223a8ce916d276d6e0420d552fb0267e9
R=mtklein@google.com , reed@google.com
TBR=mtklein@google.com , reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/386933004
2014-07-11 06:45:58 -07:00
134ae83012
manual bench rebase after bf0b9ce
...
R=robertphillips@google.com , jcgregorio@google.com
TBR=robertphillips@google.com
Bypassing trybots:
NOTRY=true
NOTREECHECKS=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/385073005
2014-07-11 06:34:59 -07:00
24969a3146
Pin to a specific version of ANGLE.
...
Pulling from HEAD is dangerous, as we now know. This change is a temporary fix
to open the tree, we need a system for which version of ANGLE we are pinning to.
BUG=skia:
NOTRY=true
NOTREECHECKS=true
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/387893002
2014-07-11 06:30:55 -07:00
bf0b9ced0b
Add file access modes to sk_exists.
...
Both Windows and Posix 'access' calls take a mode parameter which,
in addition to checking existence, checks access modes.
This change exposes this functionality.
R=mtklein@google.com , reed@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/384903002
2014-07-10 15:18:23 -07:00
bbf9f6d1cb
Revert of Slim Skia down to just one murmur3 implementation. ( https://codereview.chromium.org/376183004/ )
...
Reason for revert:
broke 10.6 compile
[17:13:56.863876] [4/336] CXX obj/src/core/core.SkBBoxHierarchyRecord.o
[17:13:56.863997] FAILED: c++ -MMD -MF obj/src/core/core.SkBBoxRecord.o.d -DSK_INTERNAL -DSK_GAMMA_SRGB -DSK_GAMMA_APPLY_TO_A8 -DSK_SCALAR_TO_FLOAT_EXCLUDED -DSK_ALLOW_STATIC_GLOBAL_INITIALIZERS=1 -DSK_SUPPORT_GPU=1 -DSK_SUPPORT_OPENCL=0 -DSK_FORCE_DISTANCEFIELD_FONTS=0 -DSK_SCALAR_IS_FLOAT -DSK_BUILD_FOR_MAC -DSK_USE_POSIX_THREADS -DSK_RELEASE -DNDEBUG -I../../include/config -I../../include/core -I../../include/pathops -I../../include/pipe -I../../include/ports -I../../include/utils -I../../include/xml -I../../src/core -I../../src/sfnt -I../../src/image -I../../src/opts -I../../src/utils -I../../include/utils/mac -I../../include/gpu -I../../src/gpu -fasm-blocks -mpascal-strings -O3 -gdwarf-2 -Wnewline-eof -mmacosx-version-min=10.6 -arch x86_64 -mssse3 -fvisibility=hidden -fvisibility-inlines-hidden -c ../../src/core/SkBBoxRecord.cpp -o obj/src/core/core.SkBBoxRecord.o
[17:13:56.864085] In file included from ../../src/core/SkPictureFlat.h:14,
[17:13:56.864130] from ../../src/core/SkPictureData.h:14,
[17:13:56.864173] from ../../src/core/SkPictureRecord.h:18,
[17:13:56.864217] from ../../src/core/SkBBoxRecord.h:12,
[17:13:56.864261] from ../../src/core/SkBBoxRecord.cpp:9:
[17:13:56.864336] ../../src/core/SkChecksum.h: In static member function ‘static uint32_t SkChecksum::Compute(const uint32_t*, size_t)’:
[17:13:56.864397] ../../src/core/SkChecksum.h:127: error: invalid conversion from ‘const uint32_t*’ to ‘const uint32_t*’
[17:13:56.864462] ../../src/core/SkChecksum.h:128: error: invalid conversion from ‘const uint32_t*’ to ‘const uint32_t*’
[17:13:56.864510] ../../src/core/SkChecksum.h:129: error: comparison between distinct pointer types ‘const uint32_t*’ and ‘const uint32_t*’ lacks a cast
Original issue's description:
> Slim Skia down to just one murmur3 implementation.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/6ac0037b70410ff7d5ce5788bc89314223e1a587
>
> Committed: https://skia.googlesource.com/skia/+/67a3271f0de9ccc32d559b042b862528272047cc
>
> Committed: https://skia.googlesource.com/skia/+/53d435990bdb4d14df78013da45a9364d0287ebe
R=mtklein@google.com , mtklein@chromium.org
TBR=mtklein@chromium.org , mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/381253003
2014-07-10 14:29:43 -07:00
4d1605a8d6
Enable tools/CrashHandler again.
...
- Defaults to on the bots, triggered off CHROME_HEADLESS=1 in the environment.
- Defaults off otherwise.
- Can be enabled by setting CHROME_HEADLESS=1 (weird) or GYP_DEFINES=skia_crash_handler=1.
BUG=skia:
R=borenet@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/383813002
2014-07-10 14:16:04 -07:00
c4f216151b
add readPixels() to SkBitmap
...
BUG=chromium:390782
R=scroggo@google.com , bsalomon@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/377303002
2014-07-10 14:15:57 -07:00
e372e78223
Add alternate SkPicture::clone
...
This adds an alternate version of SkPicture::clone for two reasons:
1) Chromium uses the SkPicture copy constructor to unpack the pictures from the old-style clone interface (and I would like to remove the copy ctor)
2) This is part of the long term plan to wean Chrome off of cloning. Once pictures are thread safe we will switch the new SkPicture::clone call to just return 'this'. From there it is a small step to removing clone entirely.
Note that the two versions of clone() is temporary. Once this is landed (and rolled) I will land a Chrome-side patch to remove their use of the old interface (Use new SkPicture::clone interface - https://codereview.chromium.org/380323002/ )
R=mtklein@google.com , reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/381193002
2014-07-10 14:10:58 -07:00
53d435990b
Slim Skia down to just one murmur3 implementation.
...
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/6ac0037b70410ff7d5ce5788bc89314223e1a587
Committed: https://skia.googlesource.com/skia/+/67a3271f0de9ccc32d559b042b862528272047cc
R=reed@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/376183004
2014-07-10 14:10:47 -07:00
b17c764f85
Handle NULL typeface in SampleApp.
...
It is possible that SampleApp will use the NULL typeface as the default.
This is valid and should be handled properly on shutdown.
2014-07-10 16:21:49 -04:00
3031a2f1df
Yet more perlin noise rebaselines.
...
R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/385733003
2014-07-10 13:02:30 -07:00
bb02bb5ab1
You guessed it -- more perlin noise rebaselines.
...
R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/386693002
2014-07-10 12:42:01 -07:00
250b59dd49
Ibid.
...
R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/381223002
2014-07-10 12:01:29 -07:00
0c4a70d6e9
Yet more perlin noise rebaselines.
...
(Apparently my rebaseline_server skills leave something to be desired.)
R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/384863002
2014-07-10 11:57:26 -07:00
626650f62f
Some more perlinnoise rebaselines.
...
R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/381973002
2014-07-10 11:29:20 -07:00
654a9c20ac
Use a consume load in SkLazyPtr.
...
This only affects ARM, where an acquire needs a memory barrier but consume does not. I am interested to see if there's a noticeable effect on the Android bots.
BUG=skia:
NOTRY=true
R=bungeman@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/381143002
2014-07-10 11:24:18 -07:00
e50737332d
Re-add friend Chrome requires
...
R=jcgregorio@google.com
TBR=jcgregorio@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/381963002
2014-07-10 11:24:12 -07:00
42483d9026
Split SkTRacy into SkTRacy and SkTRacyReffable.
...
Looks like TSAN can't always suppress our existing implementation of SkTRacy
(what is turning here into SkTRacyReffable). To minimize flakiness, use
SkTRacy where possible and SkTRacyReffable where necessary.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/497cda3a6b72b9cb390334e8756d38b4ffac044f
NOTRY=true
R=robertphillips@google.com , mtklein@google.com , reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/388503002
2014-07-10 11:11:50 -07:00
3a3eef4a63
New baselines for perlin noise changes.
...
Pixel results affected by ca6a7c2945R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
BUG=skia:
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/385643003
2014-07-10 10:52:21 -07:00
497cda3a6b
Split SkTRacy into SkTRacy and SkTRacyReffable.
...
Looks like TSAN can't always suppress our existing implementation of SkTRacy
(what is turning here into SkTRacyReffable). To minimize flakiness, use
SkTRacy where possible and SkTRacyReffable where necessary.
BUG=skia:
R=robertphillips@google.com , mtklein@google.com , reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/388503002
2014-07-10 10:38:22 -07:00
777a7dd519
Add config to build mips with dsp2 optimizations enabled by default.
...
R=borenet@google.com
Review URL: https://codereview.chromium.org/380213004
2014-07-10 13:04:24 -04:00
6142609b22
Cleanup SkPicture* classes a bit
...
This is an attempt to reduce the number of friends the various SkPicture* classes have.
Probably the only controversial part is making getBitmap, getPath, getPicture and getPaint
public on SkPictureData (and adding a new initIterator entry point).
R=mtklein@google.com , reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/384753004
2014-07-10 09:35:12 -07:00
fd429991e9
import google-api-python-client using DEPS
...
BUG=skia:2641
R=jcgregorio@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/381933002
2014-07-10 09:03:26 -07:00
61b1436c22
sk_malloc_throw/sk_calloc_throw in debug prints size in failure message
...
R=caryclark@google.com , mtklein@google.com , reed@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/377113004
2014-07-10 08:59:39 -07:00
15840a2e84
Delete third_party/harfbuzz
...
BUG=skia:
R=bungeman@google.com , reed@google.com
Review URL: https://codereview.chromium.org/384503008
2014-07-10 11:32:44 -04:00
e6b28cf25b
Remove shadows suppression
...
The 'shadows' GM isn't appearing on the "Recent GM Failures" page. It might have been a blip.
R=jcgregorio@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/387533002
2014-07-10 07:57:16 -07:00
c26d991bf2
Split SkPictureReplacementPlayback out of SkPicturePlayback
...
R=mtklein@google.com , reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/383733002
2014-07-10 07:21:27 -07:00
67a3271f0d
Slim Skia down to just one murmur3 implementation.
...
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/6ac0037b70410ff7d5ce5788bc89314223e1a587
R=reed@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/376183004
2014-07-10 06:03:46 -07:00
c7d29c86b2
update our build system to support the experimental L-Release NDK
...
This includes adding 64-bit support for arm, x86, and mips.
R=borenet@google.com
Review URL: https://codereview.chromium.org/377993002
2014-07-10 08:10:20 -04:00
04f1877399
Whitespace change to verify buildbot scripts after https://skia.googlesource.com/buildbot/+/dd42159
...
BUG=skia:2682
Review URL: https://codereview.chromium.org/361243003
2014-07-10 07:48:52 -04:00
996861db81
Update SKP version to 47
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/387433002
2014-07-10 00:16:59 -07:00
da03653f34
fix typo, had two RGBA instead of RGBA and BGRA
...
TBR=caryclark@google.com
BUG=skia:
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/382633004
2014-07-09 17:28:19 -07:00
57ad493789
Handle bad ICO data better.
...
Interpret size and offset as size_t, as they should be. When read
as int, they could be negative values. If they are negative (rather
than positive and very large), they will not allow us to fail the
length test, resulting in trying to read uninitialized memory.
BUG=b/16010240
R=halcanary@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/374413005
2014-07-09 15:04:20 -07:00
5fe23b357a
Add suppression for shadows test
...
R=jvanverth@google.com
TBR=jcgregorio@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/377403004
2014-07-09 14:24:00 -07:00
1feac79203
Revert of Slim Skia down to just one murmur3 implementation. ( https://codereview.chromium.org/376183004/ )
...
Reason for revert:
Valgrind unhappy. skia:2735
Original issue's description:
> Slim Skia down to just one murmur3 implementation.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/6ac0037b70410ff7d5ce5788bc89314223e1a587
R=reed@google.com , mtklein@chromium.org
TBR=mtklein@chromium.org , reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/378413002
2014-07-09 14:18:52 -07:00
e4636aa173
Merge Replay and Quilt tasks, adding in all BBH implementations.
...
Replay isn't that helpful of a test any more now that we have the more
stringent Quilt tests. Quilt was missing bounding box hierarchies, though,
while Replay was sort of testing RTree (pointlessly, as it was drawing without
any clip). Now Quilt does everything, testing RTree, QuadTree, and TileGrid.
Quilt mode now falls back to drawing all at once (i.e. Replay) for GMs that
don't tile perfectly. Still a TODO to make this check more flexible than exact
pixel matches.
Two GMs fail when using a BBH:
- imageresizetiled
- resizeimagefilter
We think we're not adjusting the bounds of save layers by their paint.
This is probably a bug, but one to be fixed separately from adding new tests.
BUG=skia:
R=robertphillips@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/377373003
2014-07-09 13:10:58 -07:00
ec66e6264d
Refactor SkPicturePlayback for SkPictureReplacementPlayback
...
This CL is intended to maximize code reuse when SkPictureReplacementPlayback is split off.
R=mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/378343002
2014-07-09 13:00:07 -07:00
762c718824
Remove useless options from bench
...
BUG=skia:
R=jcgregorio@google.com , bensong@google.com , bsalomon@google.com , robertphillips@google.com , reed@google.com
Author: kelvinly@google.com
Review URL: https://codereview.chromium.org/375863006
2014-07-09 12:25:27 -07:00
db5f7bf0a4
Do not export SkTDArray when building Skia as a DLL
...
This class has four members (deleteAll, freeAll, unrefAll and
safeUnrefAll) which will only compile for certain instantiations of
SkTDArray depending on the template argument type. Marking this class
as dllexport breaks the build with clang-cl because of
http://llvm.org/PR20163 . Since this class is header-only, we can just
make it non-exported to enable building Skia as a DLL with clang-cl.
BUG=skia:
R=ctguil@chromium.org , mtklein@google.com , reed@google.com
Author: ehsan.akhgari@gmail.com
Review URL: https://codereview.chromium.org/368253002
2014-07-09 11:13:55 -07:00
2d9d9c9ded
Update one last expectation from gamma change.
...
R=bungeman@google.com
TBR=bungeman@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/380823002
2014-07-09 11:12:06 -07:00
d78a168ec2
Improve gpu tracing when applying markers directly to gpu target
...
- Change the debug marker strings sent by the GrGpuGL target to only grab the last object
added to the set of active markers. This improves the readability when we end up with a
large stack of trace markers. Any trace markers the come from the IODB will continue to
be squashed into a single debug marker
- Added some more useful, high level markers
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/378933002
2014-07-09 10:41:26 -07:00
1c577cd3ee
Always initialize SkDashPathEffect fields.
...
SkDashPathEffect is flattened into a hash key as part of the old-and-busted
SkPicture paint deduping code. If all its fields aren't intialized, this hash
will be based on uninitialized data. This means the hash won't be
deterministic, and worse, Valgrind and MSAN will make us feel bad.
An alternative to this is to have SkDashPath::CalcDashParameters always
guarantee it writes something to all its output parameters, even when the dash
intervals make no sense. I like it being dumb and its users defensive, but
could go either way.
BUG=391001
R=reed@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/379813004
2014-07-09 09:54:11 -07:00
2e09d18f78
Add bounds checks to SkTDynamicHash
...
BUG=391001
R=bsalomon@google.com , mtklein@google.com , sugoi@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/380443002
2014-07-09 09:20:54 -07:00
e53363fa7c
Cleanup: Remove SkUTF16_Str API.
...
It does not have any users in Skia, Blink and Chromium.
BUG=None
TEST=make all
R=mtklein@google.com , reed@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/366243004
2014-07-09 09:18:05 -07:00
1459be5ae3
Optimized R11 EAC compressor
...
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/373243002
2014-07-09 09:15:45 -07:00
6ac0037b70
Slim Skia down to just one murmur3 implementation.
...
BUG=skia:
R=reed@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/376183004
2014-07-09 08:49:08 -07:00
40b32be371
nanobench: add median and --cpu/--gpu
...
BUG=skia:
R=krajcevski@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/377283002
2014-07-09 08:46:50 -07:00
79fd216144
Revert of Make GrGLConfigConversionEffect work for Imagination and some other GPUs. ( https://codereview.chromium.org/277323002/ )
...
Reason for revert:
Need to only use the highp variations on GLES contexts not GL contexts.
http://108.170.220.120:10117/builders/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release/builds/3398/steps/RunTests/logs/stdio
Original issue's description:
> Make GrGLConfigConversionEffect work for Imagination and some other GPUs.
>
> BUG=372341
>
> Committed: https://skia.googlesource.com/skia/+/93cf46f7d687128d2ad05762bd65fea6c4539553
R=tomhudson@chromium.org , changjun.yang@intel.com , rmistry@google.com , jcgregorio@google.com
NOTREECHECKS=true
NOTRY=true
BUG=372341
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/377263003
2014-07-09 08:14:36 -07:00
6132b436d8
rebaseline_server: cache results in long-running ImageDiffDB instance
...
Rather than rebuilding the ImageDiffDB from scratch every time we update expected/actual results, keep the same ImageDiffDB instance around and add image pairs to it.
This makes updating results within a long-running server.py *much* faster, and tests out an idea I'm ruminating in https://goto.google.com/LongRunningImageDiffDBServer : we could run an ImageDiffDB server that developers could connect to from their locally running rebaseline_server instances, for much faster launch times.
BUG=skia:2414
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/379563005
2014-07-09 07:59:06 -07:00
jcgregorio
robertphillips
bensong
bungeman
reed
mtklein
senorblanco
Derek Sollenberger
epoger
halcanary
Mike Klein
Eric Boren
reed
scroggo
kelvinly
ehsan.akhgari
jvanverth
egdaniel
tfarina
krajcevski
bsalomon