Use : instead of + as file separator to avoid + being converted to a space.

Bug #261616 r=timeless

webtools/bonsai/cvsview2.cgi

@@ -460,8 +460,8 @@ sub do_directory {
 
     print "<TABLE BORDER CELLPADDING=2>\n";
 
-    foreach my $file (split(/\+/, $opt_files)) {
-        my ($path) = "$dir/$file,v";
+    foreach my $file (split(/:/, $opt_files)) {
+        my ($path) = "$dir/" . &url_decode($file) . ",v";
         my ($ufile) = url_quote($file);
 
         CheckHidden($path);
@@ -546,7 +546,7 @@ sub do_directory {
 
     if ( !$file && $opt_files ) {
         $file = $opt_files;
-        $file =~ s@\+.*@@;
+        $file =~ s@:.*@@;
     }
 
     print "\n<TABLE CELLPADDING=0 CELLSPACING=0><TR><TD>\n",

webtools/bonsai/showcheckins.cgi

@@ -228,22 +228,26 @@ foreach $checkin (@list) {
      print "<br>$$info{notes}\n" if $$info{notes};
 
      $peoplearray{$$info{person}} = 1;
+     my @file_list;
+     foreach my $fn (split(/!NeXt!/, $$info{files})) {
+         push @file_list, &url_quote($fn);
+     }
      print "<TD>". GenerateUserLookUp($$info{person}) . "</TD>\n";
      print "<TD><a href=\"cvsview2.cgi?" . 
            "root=$::TreeInfo{$::TreeID}{repository}&" .
-           "subdir=$$info{dir}&" .
-           "files=" . join('+', split(/!NeXt!/, $$info{files})) . "&" .
-           "command=DIRECTORY$branchpart\">" .
-           BreakBig($$info{dir}) .
+           "subdir=" . &url_quote($$info{dir}) .
+           "&files=" . join(':', @file_list) .
+           "&command=DIRECTORY$branchpart\">" .
+           &BreakBig(&html_quote($$info{dir})) .
            "</a></TD>\n";
      print "<TD>\n";
      foreach my $file (split(/!NeXt!/, $$info{files})) {
           print "  <a href=\"cvsview2.cgi?" .
                 "root=$::TreeInfo{$::TreeID}{repository}&" .
-                "subdir=$$info{dir}&" .
-                "files=$file&" .
-                "command=DIRECTORY$branchpart\">" .
-                "$file</a>\n";
+                "subdir=" . &url_quote($$info{dir}) .
+                "&files=" . &url_quote($file) .
+                "&command=DIRECTORY$branchpart\">" .
+                &html_quote($file) . "</a>\n";
      }
      print "</td>\n";