neqo/hooks
Martin Thomson 836e852616
Clippy pedantic (#1649)
* Add must_use everywhere clippy thinks we need to

* Add panics docs everywhere

* Remove some redundant else blocks

* Fix or suppress similar_names lint

* Automatic fix for doc_markdown lint

* Remove unnecessary `Res` wrappings

These are mostly the result of removing internal errors in our code.
The cleanup there was incomplete.

* Cleanup some unused_self instances, including some dead code

* Use String::new instead of String::from("")

* Remove deny-warnings feature

Enable warnings for clippy::pedantic
Disable clippy::module_name_repetitions for all lib.rs

* Fix missing error doc on one! function

* Invert the test in the pre-commit hook

* Document errors on all public interfaces

* Suppress excessive bools lint for args struct

* Take suggested tweak for map_unwrap_or lint

* Take Copy argument by value

* Nest or patterns as suggested

* Suppress one struct_field_names lint because I can't think of a better name

* Remove unnecessary async on functions

* Remove unnecessary wrap again

* Remove implicit clone calls

* Refactor client main a little to reduce its length

* Pass by reference where the linter says we can

* Remove some easy lints in the server main.rs

* Another simple auto-fix lint

* Merging match arms automatically

* Avoid manual assertion

* Remove integer casts where possible

* Invert some conditions to avoid inversions

* Suppress some too_many_lines lints

* Remove some unnecessary borrows

* Add some missing semicolons

* Avoid a closure when not needed

* Remove some Default::default usage

* Fix some unreadable literals

* qlog needs f32, which means precision loss

* Stop allocating large buffers on the stack

* Avoid wildcard matches

* Fix panics doc

* Reorder items

* Remove extra deref

* Fix format args

* Iterate better

* Update neqo-transport/src/qlog.rs

Co-authored-by: Max Inden <mail@max-inden.de>
Signed-off-by: Lars Eggert <lars@eggert.org>

* Remove unused path from Db arm of enum

* Fix unknown lint warning

* Clone directly rather than indirectly

* Those any functions aren't used

* Suppress warnings here for now

* Fix some thread_local usages

* Unused, remove

* Update SharedVec as suggested, plus a bonus default thing

---------

Signed-off-by: Lars Eggert <lars@eggert.org>
Co-authored-by: Lars Eggert <lars@eggert.org>
Co-authored-by: Max Inden <mail@max-inden.de>
2024-02-14 11:33:12 +02:00
..
check_internal_errors Move internal errors to hooks 2021-06-23 07:51:50 +00:00
pre-commit Clippy pedantic (#1649) 2024-02-14 11:33:12 +02:00