Merge pull request #1137 from mythmon/renable-nsp

Fix #521 - Re-enable NSP

recipe-server/bin/ci/lint

@@ -11,7 +11,11 @@ echo "Linting Style files"
 bin/ci/docker-run.sh npm run lint:css
 
 echo "Checking JS package security"
-# NSP doesn't deal well with unreliable networks, so it produces too
-# many false positives. This lets us run it, but not fail builds.
-# TODO: Detect network problems distinct from security errors.
-bin/ci/docker-run.sh npm run lint:js-security || true
+# Disable automatic failure
+set +e
+# nsp uses exit code 1 for security problems
+bin/ci/docker-run.sh npm run lint:js-security
+if [[ $? -eq 1 ]]; then
+    exit 1
+fi
+set -e

recipe-server/package.json

@@ -27,6 +27,7 @@
     "babel-runtime": "6.11.6",
     "classnames": "2.2.5",
     "cssmin": "0.4.3",
+    "debug": "2.6.9",
     "font-awesome": "4.6.3",
     "immutable": "3.8.1",
     "jquery": "3.1.0",
@@ -103,7 +104,7 @@
     "karma-webpack": "2.0.4",
     "less": "2.7.2",
     "less-loader": "4.0.4",
-    "nsp": "2.6.3",
+    "nsp": "3.1.0",
     "postcss-loader": "0.11.1",
     "randexp": "0.4.5",
     "react-addons-test-utils": "15.2.1",