mozilla
/
normandy
зеркало из https://github.com/mozilla/normandy.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность

recipe-client-addon: Fix test failure in PreferenceExperiments. (#790) 

Fixes #789.
This commit is contained in:
Mike Cooper 2017-06-02 16:27:06 -07:00 коммит произвёл Michael Kelly
Родитель 5b8d8e0599
Коммит e69093233f
1 изменённых файлов: 4 добавлений и 1 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

5
recipe-client-addon/test/browser/browser_PreferenceExperiments.js
Просмотреть файл

@ -367,6 +367,9 @@ add_task(withMockExperiments(withMockPreferences(async function(experiments, moc
// stop should also support user pref experiments // stop should also support user pref experiments
add_task(withMockExperiments(withMockPreferences(async function(experiments, mockPreferences) { add_task(withMockExperiments(withMockPreferences(async function(experiments, mockPreferences) {
const stopObserver = sinon.stub(PreferenceExperiments, "stopObserver"); const stopObserver = sinon.stub(PreferenceExperiments, "stopObserver");
const hasObserver = sinon.stub(PreferenceExperiments, "hasObserver");
hasObserver.returns(true);
mockPreferences.set("fake.preference", "experimentvalue", "user"); mockPreferences.set("fake.preference", "experimentvalue", "user");
experiments["test"] = experimentFactory({ experiments["test"] = experimentFactory({
name: "test", name: "test",
@ -377,7 +380,6 @@ add_task(withMockExperiments(withMockPreferences(async function(experiments, moc
previousPreferenceValue: "oldvalue", previousPreferenceValue: "oldvalue",
preferenceBranchType: "user", preferenceBranchType: "user",
}); });
PreferenceExperiments.startObserver("test", "fake.preference", "experimentvalue");
await PreferenceExperiments.stop("test"); await PreferenceExperiments.stop("test");
ok(stopObserver.calledWith("test"), "stop removed an observer"); ok(stopObserver.calledWith("test"), "stop removed an observer");
@ -389,6 +391,7 @@ add_task(withMockExperiments(withMockPreferences(async function(experiments, moc
); );
stopObserver.restore(); stopObserver.restore();
hasObserver.restore();
}))); })));
// stop should not call stopObserver if there is no observer registered. // stop should not call stopObserver if there is no observer registered.