2238: Enforce argument schemas on model creation r=rehandalal a=mythmon
I realized that since we weren't checking schemas at the model level, none of the tests for argument verification checked their schemas. I needed this assurance for the tests I'm writing for #2236, but it's interesting enough to include as a separate PR.
Co-authored-by: Mike Cooper <mythmon@gmail.com>
2225: Fix windowsversion filter object r=mythmon a=uhlissuh
changes this filter object to take a list of versions.
Co-authored-by: Alissa Sobo <alissasobo@gmail.com>
2214: Updates to the containerized contract tests setup r=jaredlockhart a=chartjes
* renames action in Makefile for running the tests
* fixes problem with test container using the same port as app container
* replaces contract test job in Circle CI job file
Co-authored-by: Chris Hartjes <chartjes@mozilla.com>
Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com>
2208: Automatically set needed envvars during tests r=tiftran a=mythmon
This is another one of those "how did this even work" moments. We clearly set up these environment variables for tests at some point, but it doesn't work now, and I can't find a point in recent history where it did work.
Without these changes, a lot of the tests fail for me, especially when I'm using VSCode's Pytest integration. With this change, everything works great.
Co-authored-by: Mike Cooper <mythmon@gmail.com>
Co-authored-by: tiftran <ttran@mozilla.com>
2223: Remove app user from Dockerfile.development fixes#2221 r=mythmon a=jaredlockhart
Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com>
2211: Pin dependency @mozilla/normandy-action-argument-schemas to 0.10.0 r=tiftran a=renovate[bot]
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| @​mozilla/normandy-action-argument-schemas | dependencies | pin | [`0.10` -> `0.10.0`](https://renovatebot.com/diffs/npm/@mozilla%2fnormandy-action-argument-schemas//) |
📌 **Important**: Renovate will wait until you have merged this Pin PR before creating any *upgrade* PRs for the affected packages. Add the preset `:preserveSemverRanges` your config if you instead don't wish to pin dependencies.
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2210: Add JEXL filter object r=rehandalal a=mythmon
This could be used by NDT to combine with other filter objects, so that we can nest a JEXL filter inside a sticky or OR expression, without having to bail out entirely. It also adds the ability to comment the reasons behind a JEXL expression, and note any additional capabilities that may be needed.
Co-authored-by: Mike Cooper <mythmon@gmail.com>
This could be used by NDT to combine with other filter objects, so that we
can nest a JEXL filter inside a sticky or OR expression, without having to
bail out entirely. It also adds the ability to comment the reasons behind a
JEXL expression, and note any additional capabilities that may be needed.
2168: API contract tests update r=mythmon a=chartjes
* tests can now be run using two Docker containers (one for 'test' and the other for 'app')
* added CircleCI job to run them
Co-authored-by: Chris Hartjes <chartjes@grumpy-learning.com>
Co-authored-by: Chris Hartjes <chartjes@mozilla.com>
bors[bot]
Mike Cooper
Rehan Dalal
Alissa Sobo
Jared Lockhart
Chris Hartjes
tiftran
Renovate Bot