pjs/webtools/tinderbox/addnote.cgi

#!/usr/bin/perl --
# -*- Mode: perl; indent-tabs-mode: nil -*-
#
# The contents of this file are subject to the Netscape Public
# License Version 1.1 (the "License"); you may not use this file
# except in compliance with the License. You may obtain a copy of
# the License at http://www.mozilla.org/NPL/
#
# Software distributed under the License is distributed on an "AS
# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
# implied. See the License for the specific language governing
# rights and limitations under the License.
#
# The Original Code is the Tinderbox build tool.
#
# The Initial Developer of the Original Code is Netscape Communications
# Corporation. Portions created by Netscape are
# Copyright (C) 1998 Netscape Communications Corporation. All
# Rights Reserved.
#
# Contributor(s): 

use strict;
use Fcntl qw(:flock);

require 'tbglobals.pl';
require 'showbuilds.pl';

# Process the form arguments
my %form = &split_cgi_args();
my %cookie_jar = &split_cookie_args();

my ($args, $tree, $logfile, $errorparser, $buildname, $buildtime);

if (defined($args = $form{log})) {
  # Use simplified arguments that uses the logfile as a key.
  ($tree, $logfile) = split /\//, $args;
  $tree = &require_only_one_tree($tree);

  my $br = tb_find_build_record($tree, $logfile);
  $errorparser = $br->{errorparser};
  $buildname   = $br->{buildname};
  $buildtime   = $br->{buildtime};
} else {
  # Use old style arguments;
  $tree        = &require_only_one_tree($form{tree});
  $logfile     = $form{logfile};
  $errorparser = $form{errorparser};
  $buildname   = $form{buildname};
  $buildtime   = $form{buildtime};
}

print "Content-Type:text/html\n";

# Remember email address in cookie
#
if (defined $ENV{REQUEST_METHOD} and $ENV{REQUEST_METHOD} eq 'POST'
    and defined $form{note}) {
    # Expire the cookie 5 months from now
    print "Set-Cookie: email=$form{who}; expires="
        . toGMTString(time + 86400 * 152) . "; path=/\n";
}     
print "\n<HTML>\n";

if ($form{note}) {
  # Form Submission.
  # Add the comment.

  my $note = $form{note};
  my $who  = $form{who};

  $note =~ s/\&/&amp;/gi;
  $note =~ s/\</&lt;/gi;
  $note =~ s/\>/&gt;/gi;
  my $enc_note = url_encode($note);

  $who =~ s/\&/&amp;/gi;
  $who =~ s/\</&lt;/gi;
  $who =~ s/\>/&gt;/gi;

  my $now = time;

  # Save comment to the notes.txt file.
  #
  my $err = 0;
  open NOTES, ">>", "$::tree_dir/$tree/notes.txt" or $err++;
  if ($err) {
      print "<title>Error</title>\n";
      print "<h1>Could not open $tree/notes.txt for writing.</h1>\n";
      print "<h2>Please contact the webmaster.</h2>\n";
      die "Could not open $tree/notes.txt for writing.\n";
  }
  flock NOTES, LOCK_EX;
  print NOTES "$buildtime|$buildname|$who|$now|$enc_note\n"; 

  # Find the latest times for the "other" trees
  my (%quickdata);
  tb_loadquickparseinfo($tree, $form{maxdate}, \%quickdata, 1);

  foreach my $element (keys %form) {
    # The checkboxes for the builds have "NAME" set to the build name
    if (defined $quickdata{$element}->{buildtime}) {
      print NOTES "$quickdata{$element}->{buildtime}|$element|$who|$now|$enc_note\n"; 
    }
  }
  close NOTES;

  # Give a confirmation
  #
  print "<H1>The following comment has been added to the log</h1>\n";
  print "<pre>\n[<b>$who - ".print_time($now)."</b>]\n$note\n</pre>";

  my $enc_buildname = url_encode($buildname);
  print "<p><a href='showlog.cgi?tree=$tree&buildname=$enc_buildname"
    ."&buildtime=$buildtime&logfile=$logfile&errorparser=$errorparser'>"
    ."Go back to the Error Log</a><br><a href='showbuilds.cgi?tree=$tree'>"
    ."Go back to the build Page</a>";

  # Rebuild the static tinderbox pages
  my %new_form = ();
  $new_form{tree} = $tree;
  &tb_build_static(\%new_form);

} else {
  # Print the form to submit a comment

  if ($buildname eq '' or $buildtime == 0) {
    print "<h1>Invalid parameters</h1>\n";
    die "\n";
  }

  # Retrieve the email address from the cookie jar.
  #
  my $emailvalue = '';
  $emailvalue = " value='$cookie_jar{email}'" if defined $cookie_jar{email};
  $emailvalue =~ s/\&/&amp;/gi;
  $emailvalue =~ s/\</&lt;/gi;
  $emailvalue =~ s/\>/&gt;/gi;

  print <<__END_FORM;
<head><title>Add a Comment to $buildname log</title></head>
<body BGCOLOR="#FFFFFF" TEXT="#000000"LINK="#0000EE" VLINK="#551A8B" ALINK="#FF0000">

<table><tr><td>
  <b><font size="+2">
    Add a Log Comment
  </font></b>
</td></tr><tr><td>
  <b><code>
    $buildname
  </code></b>
</td></tr></table>

<form action='addnote.cgi' METHOD='post'>

<INPUT Type='hidden' name='buildname' value='${buildname}'>
<INPUT Type='hidden' name='buildtime' value='${buildtime}'>
<INPUT Type='hidden' name='errorparser' value='$errorparser'>
<INPUT Type='hidden' name='logfile' value='$logfile'>
<INPUT Type='hidden' name='tree' value='$tree'>

<table border=0 cellpadding=4 cellspacing=1>
<tr valign=top>
  <td align=right>
     <NOWRAP>Email address:</NOWRAP>
  </td><td>
     <INPUT Type='input' name='who' size=32$emailvalue><BR>
  </td>
</tr><tr valign=top>
  <td align=right>
     Comment:
  </td><td>
     <TEXTAREA NAME=note ROWS=10 COLS=30 WRAP=HARD></textarea>
  </td>
</tr>
</table>
<br><b><font size="+2">Additional Builds</font></b><br>
(Comment will be added to the most recent cycle.)<br>
__END_FORM

  # Find the names of the "other" trees
  my (%quickdata);
  tb_loadquickparseinfo($tree, $form{maxdate}, \%quickdata);
  my $ignore_builds = &tb_load_ignorebuilds($tree);

  # Add a checkbox for the each of the other builds
  for my $other_build_name (sort keys %quickdata) {
    if ($other_build_name ne '' and $other_build_name ne $buildname
        and not $ignore_builds->{$other_build_name}) {
      print "<INPUT TYPE='checkbox' NAME='$other_build_name'>";
      print "$other_build_name<BR>\n";
    }
  }

  print "<INPUT Type='submit' name='submit' value='Add Comment'><BR>";
  print "</form>\n</body>\n</html>";
}
Change /usr/bonsaitools/bin/perl to /usr/bin/perl [p=reed r=justdave] 2006-12-07 07:59:39 +03:00			`#!/usr/bin/perl --`
Bonsai and Tinderbox have been freed. 1998-06-17 01:43:24 +04:00			`# -- Mode: perl; indent-tabs-mode: nil --`
			`#`
updated license boilerplate 1999-11-02 02:33:56 +03:00			`# The contents of this file are subject to the Netscape Public`
			`# License Version 1.1 (the "License"); you may not use this file`
			`# except in compliance with the License. You may obtain a copy of`
			`# the License at http://www.mozilla.org/NPL/`
Bonsai and Tinderbox have been freed. 1998-06-17 01:43:24 +04:00			`#`
updated license boilerplate 1999-11-02 02:33:56 +03:00			`# Software distributed under the License is distributed on an "AS`
			`# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or`
			`# implied. See the License for the specific language governing`
			`# rights and limitations under the License.`
Bonsai and Tinderbox have been freed. 1998-06-17 01:43:24 +04:00			`#`
			`# The Original Code is the Tinderbox build tool.`
			`#`
			`# The Initial Developer of the Original Code is Netscape Communications`
updated license boilerplate 1999-11-02 02:33:56 +03:00			`# Corporation. Portions created by Netscape are`
			`# Copyright (C) 1998 Netscape Communications Corporation. All`
			`# Rights Reserved.`
			`#`
			`# Contributor(s):`
Bonsai and Tinderbox have been freed. 1998-06-17 01:43:24 +04:00
Add 'use strict;' to expose globals. Remove uses of global $tree & $form. Remove tabs from showbuilds.pl Bug #359451 r=bear 2007-01-23 20:49:10 +03:00			`use strict;`
			`use Fcntl qw(:flock);`
Bonsai and Tinderbox have been freed. 1998-06-17 01:43:24 +04:00
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`require 'tbglobals.pl';`
Use setuid scripts to handle mail. Bug #344695 r=bear 2006-07-17 21:14:35 +04:00			`require 'showbuilds.pl';`
Bonsai and Tinderbox have been freed. 1998-06-17 01:43:24 +04:00
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`# Process the form arguments`
Add 'use strict;' to expose globals. Remove uses of global $tree & $form. Remove tabs from showbuilds.pl Bug #359451 r=bear 2007-01-23 20:49:10 +03:00			`my %form = &split_cgi_args();`
			`my %cookie_jar = &split_cookie_args();`

			`my ($args, $tree, $logfile, $errorparser, $buildname, $buildtime);`
Remove tinderbox dependency upon obsolete bonsai scripts Bug #273441 r=bear 2006-05-27 04:18:42 +04:00
Find builds with <tree>/<logfile> to shorten urls 1999-07-07 02:35:00 +04:00			`if (defined($args = $form{log})) {`
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`# Use simplified arguments that uses the logfile as a key.`
Find builds with <tree>/<logfile> to shorten urls 1999-07-07 02:35:00 +04:00			`($tree, $logfile) = split /\//, $args;`
Validate the \|tree\| cgi argument and limit new tree creation to (alphanumeric\|.\|-) . Bug #367870 r=bear 2007-01-25 01:27:55 +03:00			`$tree = &require_only_one_tree($tree);`
Find builds with <tree>/<logfile> to shorten urls 1999-07-07 02:35:00 +04:00
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`my $br = tb_find_build_record($tree, $logfile);`
Find builds with <tree>/<logfile> to shorten urls 1999-07-07 02:35:00 +04:00			`$errorparser = $br->{errorparser};`
			`$buildname = $br->{buildname};`
			`$buildtime = $br->{buildtime};`
			`} else {`
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`# Use old style arguments;`
Validate the \|tree\| cgi argument and limit new tree creation to (alphanumeric\|.\|-) . Bug #367870 r=bear 2007-01-25 01:27:55 +03:00			`$tree = &require_only_one_tree($form{tree});`
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`$logfile = $form{logfile};`
			`$errorparser = $form{errorparser};`
			`$buildname = $form{buildname};`
			`$buildtime = $form{buildtime};`
Find builds with <tree>/<logfile> to shorten urls 1999-07-07 02:35:00 +04:00			`}`

Remember the email address in a cookie. 1999-04-23 01:02:48 +04:00			`print "Content-Type:text/html\n";`
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00
			`# Remember email address in cookie`
			`#`
			`if (defined $ENV{REQUEST_METHOD} and $ENV{REQUEST_METHOD} eq 'POST'`
			`and defined $form{note}) {`
Remember the email address in a cookie. 1999-04-23 01:02:48 +04:00			`# Expire the cookie 5 months from now`
			`print "Set-Cookie: email=$form{who}; expires="`
			`. toGMTString(time + 86400 * 152) . "; path=/\n";`
			`}`
			`print "\n<HTML>\n";`
Bonsai and Tinderbox have been freed. 1998-06-17 01:43:24 +04:00
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`if ($form{note}) {`
			`# Form Submission.`
			`# Add the comment.`
Bonsai and Tinderbox have been freed. 1998-06-17 01:43:24 +04:00
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`my $note = $form{note};`
			`my $who = $form{who};`
Rebuild static pages when note is added. 1999-06-05 02:56:36 +04:00
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`$note =~ s/\&/&/gi;`
			`$note =~ s/\</</gi;`
			`$note =~ s/\>/>/gi;`
			`my $enc_note = url_encode($note);`
Adds functionality to write multiple comments to a log with one submission. Also fixes some bugs and UI problems. Reviewed by terry. 1998-08-26 01:22:32 +04:00
Bug 407625: XSS hole - 'who' param on addnote.cgi wasn't quoted properly r=bear 2007-12-15 03:28:02 +03:00			`$who =~ s/\&/&/gi;`
			`$who =~ s/\</</gi;`
			`$who =~ s/\>/>/gi;`

Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`my $now = time;`
Adds functionality to write multiple comments to a log with one submission. Also fixes some bugs and UI problems. Reviewed by terry. 1998-08-26 01:22:32 +04:00
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`# Save comment to the notes.txt file.`
			`#`
Report an error if notes.txt is not writable. Bug #223304 r=bear 2006-06-05 21:49:31 +04:00			`my $err = 0;`
Use $::tree_dir to allow tree data to be decoupled from tinderbox server directory. Bug #409052 r=bear 2007-12-19 23:00:54 +03:00			`open NOTES, ">>", "$::tree_dir/$tree/notes.txt" or $err++;`
Report an error if notes.txt is not writable. Bug #223304 r=bear 2006-06-05 21:49:31 +04:00			`if ($err) {`
			`print "<title>Error</title>\n";`
			`print "<h1>Could not open $tree/notes.txt for writing.</h1>\n";`
			`print "<h2>Please contact the webmaster.</h2>\n";`
			`die "Could not open $tree/notes.txt for writing.\n";`
			`}`
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`flock NOTES, LOCK_EX;`
			`print NOTES "$buildtime\|$buildname\|$who\|$now\|$enc_note\n";`
Adds functionality to write multiple comments to a log with one submission. Also fixes some bugs and UI problems. Reviewed by terry. 1998-08-26 01:22:32 +04:00
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`# Find the latest times for the "other" trees`
Add binaryurl to quickparse output. Bug #369449 r=bear 2007-02-10 03:38:34 +03:00			`my (%quickdata);`
Bug #359451 r=bear This should be the last of the globals changes: * Set ::default_hours & ::nowdate in tbglobals.pl * Make ::rel_path local to showbuilds.pl . * Move ::maxdate & ::mindate into $td hash populated by tb_load_data() * Show an error if multiple modes (e.g. panel, quickparse) are given to showbuilds.cgi * Fix link in express mode of showbuilds.cgi * Do not show 'previous hours' links for static index.html * Pass down all form values to 'previous hours' links & the links in panel & express modes (except in static builds). * Remove global references & unused code from viewvc.pl * Note which remaining globals are used by viewvc.pl & bonsai's cvsquery.pl 2007-03-13 01:44:03 +03:00			`tb_loadquickparseinfo($tree, $form{maxdate}, \%quickdata, 1);`
Adds functionality to write multiple comments to a log with one submission. Also fixes some bugs and UI problems. Reviewed by terry. 1998-08-26 01:22:32 +04:00
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`foreach my $element (keys %form) {`
			`# The checkboxes for the builds have "NAME" set to the build name`
Add binaryurl to quickparse output. Bug #369449 r=bear 2007-02-10 03:38:34 +03:00			`if (defined $quickdata{$element}->{buildtime}) {`
			`print NOTES "$quickdata{$element}->{buildtime}\|$element\|$who\|$now\|$enc_note\n";`
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`}`
			`}`
			`close NOTES;`
Bonsai and Tinderbox have been freed. 1998-06-17 01:43:24 +04:00
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`# Give a confirmation`
			`#`
			`print "<H1>The following comment has been added to the log</h1>\n";`
			`print "<pre>\n[<b>$who - ".print_time($now)."</b>]\n$note\n</pre>";`
Bonsai and Tinderbox have been freed. 1998-06-17 01:43:24 +04:00
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`my $enc_buildname = url_encode($buildname);`
			`print "<p><a href='showlog.cgi?tree=$tree&buildname=$enc_buildname"`
Bug #359451 r=bear This should be the last of the globals changes: * Set ::default_hours & ::nowdate in tbglobals.pl * Make ::rel_path local to showbuilds.pl . * Move ::maxdate & ::mindate into $td hash populated by tb_load_data() * Show an error if multiple modes (e.g. panel, quickparse) are given to showbuilds.cgi * Fix link in express mode of showbuilds.cgi * Do not show 'previous hours' links for static index.html * Pass down all form values to 'previous hours' links & the links in panel & express modes (except in static builds). * Remove global references & unused code from viewvc.pl * Note which remaining globals are used by viewvc.pl & bonsai's cvsquery.pl 2007-03-13 01:44:03 +03:00			`."&buildtime=$buildtime&logfile=$logfile&errorparser=$errorparser'>"`
			`."Go back to the Error Log</a><br><a href='showbuilds.cgi?tree=$tree'>"`
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`."Go back to the build Page</a>";`
Adds functionality to write multiple comments to a log with one submission. Also fixes some bugs and UI problems. Reviewed by terry. 1998-08-26 01:22:32 +04:00
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`# Rebuild the static tinderbox pages`
Add 'use strict;' to expose globals. Remove uses of global $tree & $form. Remove tabs from showbuilds.pl Bug #359451 r=bear 2007-01-23 20:49:10 +03:00			`my %new_form = ();`
			`$new_form{tree} = $tree;`
Validate the \|tree\| cgi argument and limit new tree creation to (alphanumeric\|.\|-) . Bug #367870 r=bear 2007-01-25 01:27:55 +03:00			`&tb_build_static(\%new_form);`
Rebuild static pages when note is added. 1999-06-05 02:56:36 +04:00
Adds functionality to write multiple comments to a log with one submission. Also fixes some bugs and UI problems. Reviewed by terry. 1998-08-26 01:22:32 +04:00			`} else {`
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`# Print the form to submit a comment`
Adds functionality to write multiple comments to a log with one submission. Also fixes some bugs and UI problems. Reviewed by terry. 1998-08-26 01:22:32 +04:00
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`if ($buildname eq '' or $buildtime == 0) {`
Find builds with <tree>/<logfile> to shorten urls 1999-07-07 02:35:00 +04:00			`print "<h1>Invalid parameters</h1>\n";`
			`die "\n";`
			`}`
Bonsai and Tinderbox have been freed. 1998-06-17 01:43:24 +04:00
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`# Retrieve the email address from the cookie jar.`
			`#`
Add 'use strict;' to expose globals. Remove uses of global $tree & $form. Remove tabs from showbuilds.pl Bug #359451 r=bear 2007-01-23 20:49:10 +03:00			`my $emailvalue = '';`
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`$emailvalue = " value='$cookie_jar{email}'" if defined $cookie_jar{email};`
Bug 407625: XSS hole - 'who' param on addnote.cgi wasn't quoted properly r=bear 2007-12-15 03:28:02 +03:00			`$emailvalue =~ s/\&/&/gi;`
			`$emailvalue =~ s/\</</gi;`
			`$emailvalue =~ s/\>/>/gi;`
Bonsai and Tinderbox have been freed. 1998-06-17 01:43:24 +04:00
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`print <<__END_FORM;`
Clean-up presentation. Remove ignored builds for list. 1999-02-13 00:29:53 +03:00			`<head><title>Add a Comment to $buildname log</title></head>`
			`<body BGCOLOR="#FFFFFF" TEXT="#000000"LINK="#0000EE" VLINK="#551A8B" ALINK="#FF0000">`
Bonsai and Tinderbox have been freed. 1998-06-17 01:43:24 +04:00
Clean-up presentation. Remove ignored builds for list. 1999-02-13 00:29:53 +03:00			`<table><tr><td>`
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`<b><font size="+2">`
			`Add a Log Comment`
			`</font></b>`
Clean-up presentation. Remove ignored builds for list. 1999-02-13 00:29:53 +03:00			`</td></tr><tr><td>`
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`<b><code>`
			`$buildname`
			`</code></b>`
Clean-up presentation. Remove ignored builds for list. 1999-02-13 00:29:53 +03:00			`</td></tr></table>`
Bonsai and Tinderbox have been freed. 1998-06-17 01:43:24 +04:00
Put all the INPUT elements inside of the FORM element, OK? 1999-02-18 00:56:14 +03:00			`<form action='addnote.cgi' METHOD='post'>`

Bonsai and Tinderbox have been freed. 1998-06-17 01:43:24 +04:00			`<INPUT Type='hidden' name='buildname' value='${buildname}'>`
			`<INPUT Type='hidden' name='buildtime' value='${buildtime}'>`
			`<INPUT Type='hidden' name='errorparser' value='$errorparser'>`
			`<INPUT Type='hidden' name='logfile' value='$logfile'>`
Clean-up presentation. Remove ignored builds for list. 1999-02-13 00:29:53 +03:00			`<INPUT Type='hidden' name='tree' value='$tree'>`
Adds functionality to write multiple comments to a log with one submission. Also fixes some bugs and UI problems. Reviewed by terry. 1998-08-26 01:22:32 +04:00
Clean-up presentation. Remove ignored builds for list. 1999-02-13 00:29:53 +03:00			`<table border=0 cellpadding=4 cellspacing=1>`
			`<tr valign=top>`
			`<td align=right>`
			`<NOWRAP>Email address:</NOWRAP>`
			`</td><td>`
Remember the email address in a cookie. 1999-04-23 01:02:48 +04:00			`<INPUT Type='input' name='who' size=32$emailvalue><BR>`
Clean-up presentation. Remove ignored builds for list. 1999-02-13 00:29:53 +03:00			`</td>`
			`</tr><tr valign=top>`
			`<td align=right>`
			`Comment:`
			`</td><td>`
Get rid of annoying whitespace in text area. 1999-04-22 23:52:23 +04:00			`<TEXTAREA NAME=note ROWS=10 COLS=30 WRAP=HARD></textarea>`
Clean-up presentation. Remove ignored builds for list. 1999-02-13 00:29:53 +03:00			`</td>`
			`</tr>`
			`</table>`
Typo fix, patch courtesy caillon@returnzero.com. 2003-05-02 06:54:18 +04:00			`<br><b><font size="+2">Additional Builds</font></b><br>`
Take out checkbox for selected build, since it didn't work. 1999-02-18 23:13:30 +03:00			`(Comment will be added to the most recent cycle.)<br>`
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`__END_FORM`

			`# Find the names of the "other" trees`
Add binaryurl to quickparse output. Bug #369449 r=bear 2007-02-10 03:38:34 +03:00			`my (%quickdata);`
Bug #359451 r=bear This should be the last of the globals changes: * Set ::default_hours & ::nowdate in tbglobals.pl * Make ::rel_path local to showbuilds.pl . * Move ::maxdate & ::mindate into $td hash populated by tb_load_data() * Show an error if multiple modes (e.g. panel, quickparse) are given to showbuilds.cgi * Fix link in express mode of showbuilds.cgi * Do not show 'previous hours' links for static index.html * Pass down all form values to 'previous hours' links & the links in panel & express modes (except in static builds). * Remove global references & unused code from viewvc.pl * Note which remaining globals are used by viewvc.pl & bonsai's cvsquery.pl 2007-03-13 01:44:03 +03:00			`tb_loadquickparseinfo($tree, $form{maxdate}, \%quickdata);`
Use local hashes instead of global variables to store tree status data. Store static tree configuration from treedata.pl into global hash. Bug #359451 r=bear 2007-01-31 01:34:14 +03:00			`my $ignore_builds = &tb_load_ignorebuilds($tree);`
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00
			`# Add a checkbox for the each of the other builds`
Add binaryurl to quickparse output. Bug #369449 r=bear 2007-02-10 03:38:34 +03:00			`for my $other_build_name (sort keys %quickdata) {`
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`if ($other_build_name ne '' and $other_build_name ne $buildname`
Use local hashes instead of global variables to store tree status data. Store static tree configuration from treedata.pl into global hash. Bug #359451 r=bear 2007-01-31 01:34:14 +03:00			`and not $ignore_builds->{$other_build_name}) {`
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`print "<INPUT TYPE='checkbox' NAME='$other_build_name'>";`
			`print "$other_build_name<BR>\n";`
Adds functionality to write multiple comments to a log with one submission. Also fixes some bugs and UI problems. Reviewed by terry. 1998-08-26 01:22:32 +04:00			`}`
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`}`
Adds functionality to write multiple comments to a log with one submission. Also fixes some bugs and UI problems. Reviewed by terry. 1998-08-26 01:22:32 +04:00
Clean up global names. Spit and polish. Fix '-w' warnings. 1999-10-29 22:52:04 +04:00			`print "<INPUT Type='submit' name='submit' value='Add Comment'><BR>";`
			`print "</form>\n</body>\n</html>";`
Adds functionality to write multiple comments to a log with one submission. Also fixes some bugs and UI problems. Reviewed by terry. 1998-08-26 01:22:32 +04:00			`}`