Minor fixes

webtools/testopia/template/en/default/testopia/case/filter.html.tmpl

@@ -46,11 +46,12 @@
                     mult      => 1 } %]
       </td>
       <td style="padding-right: 30px;">
-      [% PROCESS select sel = { name  => 'component_id',
+      [% PROCESS select sel = { name  => 'component',
                     accesskey => 'm', 
                     list      => plan.product.components
                     elements  => 5,
-                    mult      => 1 } %]
+                    mult      => 1,
+                    byname    => 1 } %]
       </td>      
       <td valign="top">
       [% PROCESS select sel = { name  => 'isautomated',

webtools/testopia/template/en/default/testopia/caserun/delete.html.tmpl

@@ -56,10 +56,6 @@ This case has <a href="buglist.cgi?bug_id=[% caserun.bug_list FILTER none %]">[%
     [% FOREACH c = caseruns %]
       <input type="hidden" name="caserun_id" value="[% c.id FILTER none %]" />
     [% END %]
-  <p>
-  <input type="checkbox" name="single" id="single" value="1" /><label for="single">Only remove this case-run for environment <b>[% caseruns.0.environment.name FILTER html %]</b> and build <b>[% caseruns.0.build.name FILTER html %]</b></label><br/>
-  </p>
-    
   [% ELSE %]
   <p>
   <input type="checkbox" name="single" id="single" value="1" /><label for="single">Only remove this case-run for environment <b>[% caserun.environment.name FILTER html %]</b> and build <b>[% caserun.build.name FILTER html %]</b></label><br/>

webtools/testopia/tr_list_caseruns.cgi

@@ -247,7 +247,7 @@ elsif ($action eq 'do_delete'){
         print $cgi->multipart_end;
         print $cgi->multipart_start;
     }
-    $vars->{'deleted'} = 1;
+    $vars->{'deleted'} = $i;
     $vars->{'run_id'} = $cgi->param('run_id');
     $template->process("testopia/caserun/delete.html.tmpl", $vars) ||
         ThrowTemplateError($template->error());

webtools/testopia/tr_list_plans.cgi

@@ -123,7 +123,7 @@ if ($action eq 'Commit'){
     $vars->{'plan'} = $plan;
     $vars->{'title'} = "Update Successful";
     $vars->{'tr_error'} = "You did not have rights to edit ". scalar @uneditable . "plans" if scalar @uneditable > 0;
-    $vars->{'tr_message'} = "$i Test Plan(s) Updated";
+    $vars->{'tr_message'} = "$i Test Plan(s) Updated" if $i;
     $vars->{'current_tab'} = 'plan';
     $template->process("testopia/search/advanced.html.tmpl", $vars)
         || ThrowTemplateError($template->error()); 

webtools/testopia/tr_list_runs.cgi

@@ -146,8 +146,8 @@ if ($action eq 'Commit'){
     }
     my $run = Bugzilla::Testopia::TestRun->new({});
     $vars->{'run'} = $run;
-    $vars->{'title'} = "Update Successful";
-    $vars->{'tr_message'} = "$i Test Runs Updated";
+    $vars->{'title'} = $i ? "Update Successful" : "Nothing Updated";
+    $vars->{'tr_message'} = "$i Test Runs Updated" if $i;
     $vars->{'current_tab'} = 'run';
     $vars->{'build_list'} = $run->get_distinct_builds();
     $template->process("testopia/search/advanced.html.tmpl", $vars)

webtools/testopia/tr_show_case.cgi

@@ -154,7 +154,10 @@ elsif ($action eq 'do_clone'){
         foreach my $p (keys %seen){
             $count++;
             my $plan = Bugzilla::Testopia::TestPlan->new($p);
-            next unless $plan->canedit;
+            unless ($plan->canedit){
+                $vars->{'tr_error'} = "Could not link to at least one plan";
+                next;
+            }
             $case->link_plan($p);
         }
         delete $case->{'plans'};
@@ -357,7 +360,6 @@ sub do_update{
     my $est_time    = $cgi->param("estimated_time") || undef;
     if ($tester){
         $tester = login_to_id(trim($cgi->param('tester'))) || ThrowUserError("invalid_username", { name => $cgi->param('tester') });
-        trick_taint($tester);
     }
 
     ThrowUserError('testopia-missing-required-field', {'field' => 'summary'})  if $summary  eq '';

webtools/testopia/tr_show_plan.cgi

@@ -88,7 +88,7 @@ if ($action eq 'Archive' || $action eq 'Unarchive'){
 #############
 elsif ($action eq 'Clone'){
     print $cgi->header;
-    ThrowUserError("testopia-create-denied", {'object' => 'plans'}) unless Bugzilla->user->in_group('Testers');
+    ThrowUserError("testopia-create-denied", {'object' => 'plan'}) unless Bugzilla->user->in_group('Testers');
     my $plan = Bugzilla::Testopia::TestPlan->new($plan_id);
     do_update($plan);
     $vars->{'plan'} = $plan;