From 091413037dec83174bfc731787e60735aca979da Mon Sep 17 00:00:00 2001 From: "mozilla.mano%sent.com" Date: Sun, 26 Nov 2006 22:47:46 +0000 Subject: [PATCH] Bug 288254 - Findbar XBL widget. r=gavin,masayuki,bienvenu. --- browser/base/content/browser-doctype.inc | 2 - browser/base/content/browser-sets.inc | 13 +- browser/base/content/browser.js | 40 +- browser/base/content/browser.xul | 3 +- browser/base/content/global-scripts.inc | 1 - .../pinstripe/browser/bookmark-hover-left.png | 0 .../pinstripe/browser/bookmark-hover-mid.png | 0 .../browser/bookmark-hover-right.png | 0 browser/themes/pinstripe/browser/browser.css | 30 +- browser/themes/pinstripe/browser/jar.mn | 3 - browser/themes/winstripe/browser/browser.css | 5 - mail/base/content/mailWindowOverlay.js | 10 +- mail/base/content/mailWindowOverlay.xul | 9 +- mail/base/content/messageWindow.js | 4 - mail/base/content/messageWindow.xul | 2 +- mail/base/content/messenger.xul | 2 +- mail/base/content/msgMail3PaneWindow.js | 4 - toolkit/components/help/content/help.js | 2 - toolkit/components/help/content/help.xul | 19 +- .../typeaheadfind/content/findBar.inc | 0 .../typeaheadfind/content/findBar.js | 0 toolkit/components/typeaheadfind/jar.mn | 1 - .../viewsource/content/viewPartialSource.js | 7 - .../viewsource/content/viewPartialSource.xul | 19 +- .../viewsource/content/viewSource.js | 6 - .../viewsource/content/viewSource.xul | 18 +- toolkit/content/jar.mn | 1 + toolkit/content/widgets/findbar.xml | 1225 +++++++++++++++++ toolkit/content/xul.css | 6 + toolkit/themes/pinstripe/global/findBar.css | 174 +-- toolkit/themes/pinstripe/global/jar.mn | 3 + .../toolbarbutton-customhover-left.png | Bin 0 -> 3072 bytes .../toolbar/toolbarbutton-customhover-mid.png | Bin 0 -> 2841 bytes .../toolbarbutton-customhover-right.png | Bin 0 -> 4536 bytes toolkit/themes/winstripe/global/findBar.css | 57 +- 35 files changed, 1393 insertions(+), 273 deletions(-) delete mode 100644 browser/themes/pinstripe/browser/bookmark-hover-left.png delete mode 100644 browser/themes/pinstripe/browser/bookmark-hover-mid.png delete mode 100644 browser/themes/pinstripe/browser/bookmark-hover-right.png delete mode 100755 toolkit/components/typeaheadfind/content/findBar.inc delete mode 100755 toolkit/components/typeaheadfind/content/findBar.js create mode 100644 toolkit/content/widgets/findbar.xml create mode 100644 toolkit/themes/pinstripe/global/toolbar/toolbarbutton-customhover-left.png create mode 100644 toolkit/themes/pinstripe/global/toolbar/toolbarbutton-customhover-mid.png create mode 100644 toolkit/themes/pinstripe/global/toolbar/toolbarbutton-customhover-right.png diff --git a/browser/base/content/browser-doctype.inc b/browser/base/content/browser-doctype.inc index 80b44bf52f6..d7867b7cb5c 100644 --- a/browser/base/content/browser-doctype.inc +++ b/browser/base/content/browser-doctype.inc @@ -9,8 +9,6 @@ %globalRegionDTD; %charsetDTD; - -%findBarDTD; %textcontextDTD; #ifdef TOOLBAR_CUSTOMIZATION_SHEET diff --git a/browser/base/content/browser-sets.inc b/browser/base/content/browser-sets.inc index 7b7fb999d31..64e6464affa 100644 --- a/browser/base/content/browser-sets.inc +++ b/browser/base/content/browser-sets.inc @@ -47,7 +47,6 @@ - #ifdef MOZ_PLACES @@ -136,9 +135,15 @@ - - - + + + #ifdef MOZ_PLACES_BOOKMARKS diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js index 1edf0d74a5d..533899c8aed 100644 --- a/browser/base/content/browser.js +++ b/browser/base/content/browser.js @@ -94,6 +94,7 @@ var gCharsetMenu = null; var gLastBrowserCharset = null; var gPrevCharset = null; var gURLBar = null; +var gFindBar = null; var gProxyButton = null; var gProxyFavIcon = null; var gProxyDeck = null; @@ -788,11 +789,10 @@ function BrowserStartup() var sidebarSplitter; if (window.opener && !window.opener.closed) { - if (window.opener.gFindBar && window.opener.gFindBar.mFindMode == FIND_NORMAL) { - var openerFindBar = window.opener.document.getElementById("FindToolbar"); - if (openerFindBar && !openerFindBar.hidden) - gFindBar.openFindBar(); - } + var openerFindBar = window.opener.gFindBar; + if (openerFindBar && !openerFindBar.hidden && + openerFindBar.findMode == gFindBar.FIND_NORMAL) + gFindBar.open(); var openerSidebarBox = window.opener.document.getElementById("sidebar-box"); // The opener can be the hidden window too, if we're coming from the state @@ -882,6 +882,7 @@ function prepareForStartup() gURLBar = document.getElementById("urlbar"); gNavigatorBundle = document.getElementById("bundle_browser"); gProgressMeterPanel = document.getElementById("statusbar-progresspanel"); + gFindBar = document.getElementById("FindToolbar"); gBrowser.addEventListener("DOMUpdatePageReport", gPopupBlockerObserver.onUpdatePageReport, false); // Note: we need to listen to untrusted events, because the pluginfinder XBL // binding can't fire trusted ones (runs with page privileges). @@ -987,8 +988,6 @@ function delayedStartup() sidebar.setAttribute("src", sidebarBox.getAttribute("src")); } - gFindBar.initFindBar(); - #ifndef MOZ_PLACES_BOOKMARKS // add bookmark options to context menu for tabs addBookmarkMenuitems(); @@ -1162,8 +1161,6 @@ function BrowserShutdown() gSanitizeListener.shutdown(); BrowserOffline.uninit(); - - gFindBar.uninitFindBar(); var windowManager = Components.classes['@mozilla.org/appshell/window-mediator;1'].getService(); var windowManagerInterface = windowManager.QueryInterface(Components.interfaces.nsIWindowMediator); @@ -2558,9 +2555,8 @@ function toggleAffectedChrome(aHide) gChromeState.statusbarOpen = !statusbar.hidden; statusbar.hidden = aHide; - var findBar = document.getElementById("FindToolbar"); - gChromeState.findOpen = !findBar.hidden; - gFindBar.closeFindBar(); + gChromeState.findOpen = !gFindBar.hidden; + gFindBar.close(); } else { if (gChromeState.notificationsOpen) { @@ -2573,7 +2569,7 @@ function toggleAffectedChrome(aHide) } if (gChromeState.findOpen) - gFindBar.openFindBar(); + gFindBar.open(); } if (gChromeState.sidebarOpen) @@ -3817,7 +3813,6 @@ nsBrowserStatusHandler.prototype = // Do not update urlbar if there was a subframe navigation var browser = getBrowser().selectedBrowser; - var findField = document.getElementById("find-field"); if (aWebProgress.DOMWindow == content) { if (location == "about:blank" || location == "") { //second condition is for new tabs, otherwise @@ -3836,9 +3831,6 @@ nsBrowserStatusHandler.prototype = if (!gBrowser.mTabbedMode && aWebProgress.isLoadingDocument) gBrowser.setIcon(gBrowser.mCurrentTab, null); - if (findField) - setTimeout(function() { findField.value = browser.findString; }, 0, findField, browser); - //XXXBlake don't we have to reinit this.urlBar, etc. // when the toolbar changes? if (gURLBar) { @@ -3870,14 +3862,17 @@ nsBrowserStatusHandler.prototype = } } UpdateBackForwardButtons(); - if (findField && gFindBar.mFindMode != FIND_NORMAL) { + + if (gFindBar.findMode != gFindBar.FIND_NORMAL) { // Close the Find toolbar if we're in old-style TAF mode - gFindBar.closeFindBar(); + gFindBar.close(); } - //fix bug 253793 - turn off highlight when page changes - if (document.getElementById("highlight").checked) - document.getElementById("highlight").removeAttribute("checked"); + // XXXmano new-findbar, do something useful once it lands. + // Of course, this is especially wrong with bfcache on... + + // fix bug 253793 - turn off highlight when page changes + gFindBar.getElement("highlight").checked = false; // See bug 358202, when tabs are switched during a drag operation, // timers don't fire on windows (bug 203573) @@ -4011,7 +4006,6 @@ nsBrowserStatusHandler.prototype = observerService.notifyObservers(content, notification, urlStr); } catch (e) { } - setTimeout(function() { if (document.getElementById("highlight").checked) toggleHighlight(true); }, 0); } } diff --git a/browser/base/content/browser.xul b/browser/base/content/browser.xul index 2f971fd220c..801258e277b 100644 --- a/browser/base/content/browser.xul +++ b/browser/base/content/browser.xul @@ -56,7 +56,6 @@ #endif - @@ -526,7 +525,7 @@ #endif -#include ../../../toolkit/components/typeaheadfind/content/findBar.inc + diff --git a/browser/base/content/global-scripts.inc b/browser/base/content/global-scripts.inc index f5ef3f9590b..bd1e2523265 100644 --- a/browser/base/content/global-scripts.inc +++ b/browser/base/content/global-scripts.inc @@ -39,7 +39,6 @@