Bug 112769: Add "New Tab" button to tab bar. r=sgehani, sr=hewitt

themes/classic/global/mac/browser.css

@@ -38,3 +38,9 @@ tab[busy] > .tab-icon {
 .tabs-closebutton > .toolbarbutton-icon {
   margin: 0;
 }
+
+.tabs-newbutton {
+  margin: 0px;
+  padding: 0px;
+  list-style-image: url("chrome://global/skin/icons/tab-new.gif");
+}

themes/classic/global/mac/globalBindings.xml

@@ -31,16 +31,19 @@
     </content>
   </binding>
   
-    <binding id="tabs-closebutton" 
+  <binding id="tabs-closebutton" 
            extends="chrome://global/content/bindings/tabbox.xml#tabs">
     <content>
       <xul:spacer class="tabs-left-cap"/>
-      <xul:spacer class="tabs-left"/>
+      <xul:stack>
+        <xul:spacer class="tabs-left"/>
+        <xul:toolbarbutton class="tabs-newbutton" xbl:inherits="oncommand=onnewtab,tooltiptext=tooltiptextnew"/>
+      </xul:stack>
       <children/>
       <xul:stack flex="1">
         <xul:spacer class="tabs-right"/>
         <xul:hbox class="tabs-closebutton-box" align="center" pack="end">
-          <xul:toolbarbutton class="tabs-closebutton close-button" xbl:inherits="oncommand=onclosetab"/>
+          <xul:toolbarbutton class="tabs-closebutton close-button" xbl:inherits="disabled=disableclose,oncommand=onclosetab"/>
         </xul:hbox>
       </xul:stack>
       <xul:spacer class="tabs-right-cap"/>

themes/classic/global/win/browser.css

@@ -43,3 +43,8 @@ tab[busy] > .tab-icon {
   margin: 0;
 }
 
+.tabs-newbutton {
+  margin: 0px;
+  padding: 0px;
+  list-style-image: url("chrome://global/skin/icons/tab-new.gif");
+}

themes/classic/jar.mn

@@ -142,6 +142,7 @@ classic.jar:
   skin/classic/global/console/console-error-dash.gif                    (global/console/console-error-dash.gif)
   skin/classic/global/console/console-error-caret.gif                   (global/console/console-error-caret.gif)
   skin/classic/global/icons/close-button.gif                            (global/icons/close-button.gif)
+  skin/classic/global/icons/tab-new.gif                                 (global/icons/tab-new.gif)
   skin/classic/global/toolbar/tbgrip-arrow.gif                          (global/toolbar/tbgrip-arrow.gif)
   skin/classic/global/toolbar/tbgrip-arrow-clps.gif                     (global/toolbar/tbgrip-arrow-clps.gif)
   skin/classic/global/toolbar/tbgrip-texture.gif                        (global/toolbar/tbgrip-texture.gif)

themes/modern/global/browser.css

@@ -90,3 +90,18 @@ tab[busy] {
   list-style-image: url("chrome://global/skin/icons/close-dis.gif") !important;
 }
 
+.tabs-newbutton {
+  margin: 0px;
+  padding: 2px 0px 3px 2px;
+  border: none;
+  list-style-image: url("chrome://global/skin/icons/tab-new.gif");
+}
+
+.tabs-newbutton:hover {
+  list-style-image: url("chrome://global/skin/icons/tab-new-hov.gif");
+}
+
+.tabs-newbutton:hover:active {
+  list-style-image: url("chrome://global/skin/icons/tab-new-act.gif");
+}
+

themes/modern/jar.mn

@@ -200,6 +200,9 @@ modern.jar:
   skin/modern/global/icons/close-act.gif                           (global/icons/close-act.gif)
   skin/modern/global/icons/close.gif                               (global/icons/close.gif)
   skin/modern/global/icons/close-hov.gif                           (global/icons/close-hov.gif)
+  skin/modern/global/icons/tab-new.gif                             (global/icons/tab-new.gif)
+  skin/modern/global/icons/tab-new-hov.gif                         (global/icons/tab-new-hov.gif)
+  skin/modern/global/icons/tab-new-act.gif                         (global/icons/tab-new-act.gif)
   skin/modern/global/icons/closebox.gif                            (global/icons/closebox.gif)
   skin/modern/global/menu/menu-arrow-dis.gif                       (global/menu/menu-arrow-dis.gif)
   skin/modern/global/menu/menu-arrow-hov.gif                       (global/menu/menu-arrow-hov.gif)

xpfe/global/resources/content/bindings/tabbox.xml

@@ -339,7 +339,10 @@
   <binding id="tabs-closebutton" 
            extends="chrome://global/content/bindings/tabbox.xml#tabs">
     <content>
-      <xul:spacer class="tabs-left"/>
+      <xul:stack>
+        <xul:spacer class="tabs-left"/>
+        <xul:toolbarbutton class="tabs-newbutton" xbl:inherits="oncommand=onnewtab,tooltiptext=tooltiptextnew"/>
+      </xul:stack>
       <children/>
       <xul:stack flex="1">
         <xul:spacer class="tabs-right"/>

xpfe/global/resources/content/bindings/tabbrowser.xml

@@ -57,8 +57,7 @@
           <xul:tooltip onpopupshowing="event.preventBubble(); if (document.tooltipNode.hasAttribute('label')) { this.setAttribute('label', document.tooltipNode.getAttribute('label')); return true; } return false;"/>
           <xul:menupopup onpopupshowing="this.parentNode.parentNode.parentNode.updatePopupMenu(this);">
             <xul:menuitem label="&newTab.label;" accesskey="&newTab.accesskey;"
-                          oncommand="var tabbrowser = this.parentNode.parentNode.parentNode.parentNode;
-                                     tabbrowser.selectedTab = tabbrowser.addTab('about:blank');"/>
+                          oncommand="this.parentNode.parentNode.parentNode.parentNode.newTab();"/>
             <xul:menuseparator/>
             <xul:menuitem label="&reloadTab.label;" accesskey="&reloadTab.accesskey;"
                           oncommand="var tabbrowser = this.parentNode.parentNode.parentNode.parentNode;
@@ -80,17 +79,21 @@
           </xul:menupopup>
 
           <xul:tabs class="tabbrowser-tabs" closebutton="true" disableclose="true" flex="1"
+                    tooltiptextnew="&newTabButton.tooltip;"
                     onclick="if (event.button != 1 || event.target.localName != 'tab') return; 
                              this.parentNode.parentNode.parentNode.removeTab(event.target);"
                     ondragover="nsDragAndDrop.dragOver(event, this.parentNode.parentNode.parentNode);
                                 event.stopPropagation();"
                     ondragdrop="nsDragAndDrop.drop(event, this.parentNode.parentNode.parentNode);
                                 event.stopPropagation();"
+                    onnewtab="var node = this.parentNode;
+                              while (node.localName != 'tabbrowser')
+                                node = node.parentNode;
+                              node.newTab();"
                     onclosetab="var node = this.parentNode;
                                 while (node.localName != 'tabbrowser')
                                   node = node.parentNode;
                                 node.removeCurrentTab();">
-
             <xul:tab validate="never" 
                      onerror="this.parentNode.parentNode.parentNode.parentNode.addToMissedIconCache(this.getAttribute('image'));
                               this.removeAttribute('image');"
@@ -585,6 +588,14 @@
         </body>
       </method>
 
+      <method name="newTab">
+        <body>
+          <![CDATA[
+            this.selectedTab = this.addTab('about:blank');
+          ]]>
+        </body>
+      </method>
+
       <method name="addTab">
         <parameter name="aURI"/>
         <parameter name="aReferrerURI"/>

xpfe/global/resources/locale/en-US/tabbrowser.dtd

@@ -1,6 +1,6 @@
 <!ENTITY  untitledTab            "(Untitled)">
 <!ENTITY  newTab.label           "New Tab">
-<!ENTITY  newTab.accesskey       "n">
+<!ENTITY  newTab.accesskey       "N">
 <!ENTITY  closeTab.label         "Close Tab">
 <!ENTITY  closeTab.accesskey         "c">
 <!ENTITY  closeOtherTabs.label   "Close Other Tabs">
@@ -9,3 +9,4 @@
 <!ENTITY  reloadAllTabs.accesskey         "A">
 <!ENTITY  reloadTab.label        "Reload Tab">
 <!ENTITY  reloadTab.accesskey         "r">
+<!ENTITY  newTabButton.tooltip   "Open a new tab">