From 1980a24ebe34a1ff36594f34805edc41dc880727 Mon Sep 17 00:00:00 2001 From: "darin%netscape.com" Date: Mon, 16 Apr 2001 20:39:10 +0000 Subject: [PATCH] Fixes bug 75354 "https content is being cached on disk!!" r=bbaetz, sr=dougt --- netwerk/protocol/http/src/nsHTTPChannel.cpp | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/netwerk/protocol/http/src/nsHTTPChannel.cpp b/netwerk/protocol/http/src/nsHTTPChannel.cpp index 7323fa52e63..ff4ee255ffa 100644 --- a/netwerk/protocol/http/src/nsHTTPChannel.cpp +++ b/netwerk/protocol/http/src/nsHTTPChannel.cpp @@ -168,7 +168,7 @@ nsHTTPChannel::nsHTTPChannel(nsIURI *aURL, nsHTTPHandler *aHandler) PRBool isHTTPS = PR_FALSE; if (NS_SUCCEEDED(mURI->SchemeIs("https", &isHTTPS)) && isHTTPS) - mLoadFlags |= nsIRequest::INHIBIT_PERSISTENT_CACHING; + mLoadFlags |= INHIBIT_PERSISTENT_CACHING; } nsHTTPChannel::~nsHTTPChannel() @@ -397,6 +397,11 @@ NS_IMETHODIMP nsHTTPChannel::SetLoadFlags(PRUint32 aLoadFlags) { mLoadFlags = aLoadFlags; + + PRBool isHTTPS = PR_FALSE; + if (NS_SUCCEEDED(mURI->SchemeIs("https", &isHTTPS)) && isHTTPS) + mLoadFlags |= INHIBIT_PERSISTENT_CACHING; + return NS_OK; } @@ -1413,9 +1418,9 @@ nsHTTPChannel::CheckCache() return rv; PRUint32 cacheFlags; - if (mLoadFlags & nsIRequest::CACHE_AS_FILE) + if (mLoadFlags & CACHE_AS_FILE) cacheFlags = nsINetDataCacheManager::CACHE_AS_FILE; - else if (mLoadFlags & nsIRequest::INHIBIT_PERSISTENT_CACHING) + else if (mLoadFlags & INHIBIT_PERSISTENT_CACHING) cacheFlags = nsINetDataCacheManager::BYPASS_PERSISTENT_CACHE; else cacheFlags = 0; @@ -2672,7 +2677,7 @@ nsHTTPChannel::Authenticate(const char *aChallenge, PRBool aProxyAuth) // not cached, except perhaps in the memory cache. // XXX if we had username and passwd in user-auth, and the interaction // XXX was standard, then it's safe to cache, I think (shaver) - mLoadFlags |= nsIRequest::INHIBIT_PERSISTENT_CACHING; + mLoadFlags |= INHIBIT_PERSISTENT_CACHING; // This smells like a clone function... maybe there is a // benefit in doing that, think. TODO.