Get rid of silly code that was converting a nsString to a naked unicode, which required automatic coercion _back_ to an nsString, this time using a copy on the heap :-/.

This commit is contained in:
waterson%netscape.com 1999-09-02 21:31:22 +00:00
Родитель 93145abc11
Коммит 1e71e7d09f
3 изменённых файлов: 9 добавлений и 51 удалений

Просмотреть файл

@ -2574,7 +2574,7 @@ RDFElementImpl::UnsetAttribute(PRInt32 aNameSpaceID, nsIAtom* aName, PRBool aNot
for (i = 0; i < count; i++) {
nsXULAttribute* attr = (nsXULAttribute*)mAttributes->ElementAt(i);
if ((attr->mNameSpaceID == aNameSpaceID) && (attr->mName == aName)) {
oldValue = attr->mValue.GetUnicode();
oldValue = attr->mValue;
mAttributes->RemoveElementAt(i);
NS_RELEASE(attr);
successful = PR_TRUE;
@ -3054,7 +3054,7 @@ RDFElementImpl::GetIdResource(nsIRDFResource** aResource)
const nsXULAttribute* attr = (const nsXULAttribute*) mAttributes->ElementAt(i);
if ((attr->mNameSpaceID == kNameSpaceID_None) &&
(attr->mName == kIdAtom)) {
return nsRDFContentUtils::MakeElementResource(mDocument, attr->mValue.GetUnicode(), aResource);
return nsRDFContentUtils::MakeElementResource(mDocument, attr->mValue, aResource);
}
}
}
@ -3080,22 +3080,8 @@ RDFElementImpl::GetRefResource(nsIRDFResource** aResource)
if (attr->mName != kRefAtom)
continue;
#if 0
// Found it!
nsresult rv;
// ...now resolve it to an absolute URI.
nsCOMPtr<nsIURI> base = dont_AddRef(mDocument->GetDocumentURL());
nsAutoString uri(attr->mValue);
rv = rdf_MakeAbsoluteURI(base, uri);
if (NS_FAILED(rv)) return rv;
// ...then, setup the new mapping.
return gRDFService->GetUnicodeResource(uri.GetUnicode(), aResource);
#else
return nsRDFContentUtils::MakeElementResource(mDocument, attr->mValue.GetUnicode(), aResource);
#endif
return nsRDFContentUtils::MakeElementResource(mDocument, attr->mValue, aResource);
}
}

Просмотреть файл

@ -2574,7 +2574,7 @@ RDFElementImpl::UnsetAttribute(PRInt32 aNameSpaceID, nsIAtom* aName, PRBool aNot
for (i = 0; i < count; i++) {
nsXULAttribute* attr = (nsXULAttribute*)mAttributes->ElementAt(i);
if ((attr->mNameSpaceID == aNameSpaceID) && (attr->mName == aName)) {
oldValue = attr->mValue.GetUnicode();
oldValue = attr->mValue;
mAttributes->RemoveElementAt(i);
NS_RELEASE(attr);
successful = PR_TRUE;
@ -3054,7 +3054,7 @@ RDFElementImpl::GetIdResource(nsIRDFResource** aResource)
const nsXULAttribute* attr = (const nsXULAttribute*) mAttributes->ElementAt(i);
if ((attr->mNameSpaceID == kNameSpaceID_None) &&
(attr->mName == kIdAtom)) {
return nsRDFContentUtils::MakeElementResource(mDocument, attr->mValue.GetUnicode(), aResource);
return nsRDFContentUtils::MakeElementResource(mDocument, attr->mValue, aResource);
}
}
}
@ -3080,22 +3080,8 @@ RDFElementImpl::GetRefResource(nsIRDFResource** aResource)
if (attr->mName != kRefAtom)
continue;
#if 0
// Found it!
nsresult rv;
// ...now resolve it to an absolute URI.
nsCOMPtr<nsIURI> base = dont_AddRef(mDocument->GetDocumentURL());
nsAutoString uri(attr->mValue);
rv = rdf_MakeAbsoluteURI(base, uri);
if (NS_FAILED(rv)) return rv;
// ...then, setup the new mapping.
return gRDFService->GetUnicodeResource(uri.GetUnicode(), aResource);
#else
return nsRDFContentUtils::MakeElementResource(mDocument, attr->mValue.GetUnicode(), aResource);
#endif
return nsRDFContentUtils::MakeElementResource(mDocument, attr->mValue, aResource);
}
}

Просмотреть файл

@ -2574,7 +2574,7 @@ RDFElementImpl::UnsetAttribute(PRInt32 aNameSpaceID, nsIAtom* aName, PRBool aNot
for (i = 0; i < count; i++) {
nsXULAttribute* attr = (nsXULAttribute*)mAttributes->ElementAt(i);
if ((attr->mNameSpaceID == aNameSpaceID) && (attr->mName == aName)) {
oldValue = attr->mValue.GetUnicode();
oldValue = attr->mValue;
mAttributes->RemoveElementAt(i);
NS_RELEASE(attr);
successful = PR_TRUE;
@ -3054,7 +3054,7 @@ RDFElementImpl::GetIdResource(nsIRDFResource** aResource)
const nsXULAttribute* attr = (const nsXULAttribute*) mAttributes->ElementAt(i);
if ((attr->mNameSpaceID == kNameSpaceID_None) &&
(attr->mName == kIdAtom)) {
return nsRDFContentUtils::MakeElementResource(mDocument, attr->mValue.GetUnicode(), aResource);
return nsRDFContentUtils::MakeElementResource(mDocument, attr->mValue, aResource);
}
}
}
@ -3080,22 +3080,8 @@ RDFElementImpl::GetRefResource(nsIRDFResource** aResource)
if (attr->mName != kRefAtom)
continue;
#if 0
// Found it!
nsresult rv;
// ...now resolve it to an absolute URI.
nsCOMPtr<nsIURI> base = dont_AddRef(mDocument->GetDocumentURL());
nsAutoString uri(attr->mValue);
rv = rdf_MakeAbsoluteURI(base, uri);
if (NS_FAILED(rv)) return rv;
// ...then, setup the new mapping.
return gRDFService->GetUnicodeResource(uri.GetUnicode(), aResource);
#else
return nsRDFContentUtils::MakeElementResource(mDocument, attr->mValue.GetUnicode(), aResource);
#endif
return nsRDFContentUtils::MakeElementResource(mDocument, attr->mValue, aResource);
}
}