Bug 381335 - Fix various js warnings in places front-end code. patch from Henrik Skupin <hskupin@gmail.com>, r=me.

browser/base/content/browser.js

@@ -339,7 +339,7 @@ var gBookmarksObserver = {
   
   onItemVisited: function() { },
   onFolderMoved: function() { },
-  onFolderChanged: function() { },
+  onFolderChanged: function() { }
 };
 
 /**

browser/components/places/content/bookmarkProperties.js

@@ -174,11 +174,12 @@ var BookmarkPropertiesPanel = {
         return this._strings.getString("dialogTitleAddMulti");
 
       return this._strings.getString("dialogTitleAddFolder");
-    } 
+    }
     if (this._action == ACTION_EDIT) {
       return this._strings
                  .getFormattedString("dialogTitleEdit", [this._itemTitle]);
     }
+    return "";
   },
 
   /**

browser/components/places/content/controller.js

@@ -1001,6 +1001,7 @@ PlacesController.prototype = {
     var selectedNode = this._view.selectedNode;
     var txn = new PlacesSetBookmarksToolbarTransaction(selectedNode.itemId);
     PlacesUtils.tm.doTransaction(txn);
+    return true;
   },
 
 

browser/components/places/content/toolbar.xml

@@ -266,7 +266,7 @@
               var siteURIString;
               try {
                 siteURIString = 
-                  this._anno.getItemAnnotationString(folder, "livemark/siteURI");
+                  PlaceUtils.annotations.getItemAnnotationString(folder, "livemark/siteURI");
               }
               catch (ex) {}
               // end duplication

browser/components/places/content/treeHelpers.js

@@ -57,6 +57,7 @@ function PrefHandler(pref, defaultValue, serializable) {
     getService(Components.interfaces.nsIPrefBranch2);
   this._pb.addObserver(this._pref, this, false);
 }
+
 PrefHandler.prototype = {
   /**
    * Clean up when the window is going away to avoid leaks. 
@@ -291,5 +292,5 @@ var OptionsFilter = {
     var options = queryNode.queryOptions.clone();
     options.sortingMode = result.sortingMode;
     this.getHandler(queries).value = options;
-  },
+  }
 };