Fix for bug 117030. gContentChanged wasn't always set when needed. SR=hewitt

mailnews/compose/resources/content/MsgComposeCommands.js

@@ -2111,6 +2111,7 @@ function AttachFile()
     var attachment = Components.classes["@mozilla.org/messengercompose/attachment;1"].createInstance(Components.interfaces.nsIMsgAttachment);
     attachment.url = currentAttachment;
     AddAttachment(attachment);
+    gContentChanged = true;
   }
   else
   {
@@ -2250,6 +2251,8 @@ function RemoveSelectedAttachment()
     {
       for ( var item = bucketTree.selectedItems.length - 1; item >= 0; item-- )
         body.removeChild(bucketTree.selectedItems[item]);
+
+      gContentChanged = true;
     }
   }
 
@@ -2527,6 +2530,7 @@ var attachmentBucketObserver = {
         attachment.url = rawData;
         attachment.name = prettyName;
         AddAttachment(attachment);
+        gContentChanged = true;
       }
       else {
         var errorTitle = sComposeMsgsBundle.getString("DuplicateFileErrorDlogTitle");

mailnews/compose/resources/content/addressingWidgetOverlay.xul

@@ -45,8 +45,8 @@ Rights Reserved.
         <treerow>
           <treecell class="treecell-addressingWidget" allowevents="true" align="stretch">
             <menulist id="msgRecipientType#1" class="aw-menulist menulist-compact" flex="1"
-                      onclick="awNotAnEmptyArea(event)" disableonsend="true"
-                      oncommand="awSetAutoComplete(this.id.slice(this.id.lastIndexOf('#') + 1));">
+                      disableonsend="true"
+                      oncommand="gContentChanged=true; awSetAutoComplete(this.id.slice(this.id.lastIndexOf('#') + 1));">
               <menupopup>
                 <menuitem value="addr_to" label="&toAddr.label;"/>
                 <menuitem value="addr_cc" label="&ccAddr.label;"/>
@@ -65,10 +65,10 @@ Rights Reserved.
                      minResultsForPopup="3" 
                      ontextcommand="awRecipientTextCommand(eventParam, this)"
                      onerrorcommand="awRecipientErrorCommand(eventParam, this)"
-                     oninput="setupAutocomplete();" disableonsend="true"
+                     oninput="gContentChanged=true; setupAutocomplete();" disableonsend="true"
                      onkeypress="awRecipientKeyPress(event, this)"
                      onkeydown="awRecipientKeyDown(event, this)">
-              <image onclick="awNotAnEmptyArea(event)" class="person-icon"/>
+              <image class="person-icon"/>
             </textbox>
           </treecell>
         </treerow>

mailnews/compose/resources/content/messengercompose.xul

@@ -405,8 +405,8 @@
           <tree id="addressingWidgetTree" flex="1"/>
           <hbox align="center">
             <label value="&subject.label;" accesskey="&subject.accesskey;"/>
-            <textbox id="msgSubject" flex="1" class="toolbar" onkeyup="SetComposeWindowTitle(event.which);" disableonsend="true"
-                       onkeypress="subjectKeyPress(event);" onchange="gContentChanged=true;"/>
+            <textbox id="msgSubject" flex="1" class="toolbar" onkeyup="SetComposeWindowTitle(event.which);"
+                        oninput="gContentChanged=true;" disableonsend="true" onkeypress="subjectKeyPress(event);"/>
           </hbox>
         </vbox>
         <splitter id="attachmentbucket-sizer" collapse="after"/>
@@ -416,7 +416,6 @@
           <tree id="attachmentBucket" class="inset toolbar" flex="1" style="height: 0px; width: 0px;"
                 dragdroptree="true"
                 onkeypress="if (event.keyCode == 8 || event.keyCode == 46) RemoveSelectedAttachment();"
-                onchange="gContentChanged=true;"
                 onclick="AttachmentBucketClicked(event);"
                 ondragover="nsDragAndDrop.dragOver(event, attachmentBucketObserver);"
                 ondragdrop="nsDragAndDrop.drop(event, attachmentBucketObserver);"