fix for bug #199360

for simple left clicks of urls in mail messages that we know should open a browser window
(or load in the top most browser window), do it right away.

if the url is slow to load, switching messages can kill the load, and the window
never shows up.

play nice with stand alone mail, which doesn't need this trick.

r=bryner, sr=mscott

mailnews/base/resources/content/mailWindow.js

@@ -63,6 +63,7 @@ var gSearchBox = null;
 var gAccountCentralLoaded = false;
 var gFakeAccountPageLoaded = false;
 var gPaneConfig = null;
+var gStandAloneMail = false;
 //End progress and Status variables
 
 // for checking if the folder loaded is Draft or Unsent which msg is editable
@@ -189,6 +190,8 @@ function CreateMailWindowGlobals()
   accountCentralBox = document.getElementById("accountCentralBox");
   gSearchBox = document.getElementById("searchBox");
   gPaneConfig = pref.getIntPref("mail.pane_config");
+
+  gStandAloneMail = pref.getBoolPref("mail.standalone");
 }
 
 function InitMsgWindow()
@@ -198,11 +201,48 @@ function InitMsgWindow()
   msgWindow.msgHeaderSink = messageHeaderSink;
   msgWindow.SetDOMWindow(window);
   mailSession.AddMsgWindow(msgWindow);
+
+  var messagepane = document.getElementById("messagepane");
+  messagepane.addEventListener("click",messagePaneOnClick,true);
+}
+
+function messagePaneOnClick(event)
+{
+  // if this is stand alone mail (no browser)
+  // or this isn't a simple left click, do nothing, and let the normal code execute
+  if (gStandAloneMail || event.button != 0 || event.metaKey || event.ctrlKey || event.shiftKey || event.altKey)
+    return;
+
+  // try to determine the href for what you are clicking on.  
+  // for example, it might be "" if you aren't left clicking on a link
+  var href = hrefForClickEvent(event);
+  if (!href) 
+    return;
+
+  // we know that http://, https://, ftp://, file://, chrome://, 
+  // resource://, about:, and gopher:// (as if), 
+  // should load in a browser.  but if we don't have one of those
+  // (examples are mailto, imap, news, mailbox, snews, nntp, ldap, 
+  // and externally handled schemes like aim)
+  // we may or may not want a browser window, in which case we return here
+  // and let the normal code handle it
+  var needABrowser = /(^http(s)?:|^ftp:|^file:|^gopher:|^chrome:|^resource:|^about:)/i;
+  if (href.search(needABrowser) == -1) 
+    return;
+
+  // if you get here, the user did a simple left click on a link
+  // that we know should be in a browser window.
+  // since we are in the message pane, send it to the top most browser window 
+  // (or open one) right away, instead of waiting for us to get some data and
+  // determine the content type, and then open a browser window
+  openTopBrowserWith(href);
+  // we want to preventDefault, so that in
+  // nsGenericHTMLElement::HandleDOMEventForAnchors(), we don't try to handle the click again
+  event.preventDefault();
 }
 
 function AddDataSources()
 {
-
   accountManagerDataSource = accountManagerDataSource.QueryInterface(Components.interfaces.nsIRDFDataSource);
   folderDataSource = folderDataSource.QueryInterface(Components.interfaces.nsIRDFDataSource);
   //to move menu item
@@ -677,3 +717,5 @@ const gMailToolBarPrefListener =
     document.getElementById("button-" + prefName.substr(this.domain.length+1)).hidden = !(pref.getBoolPref(prefName));
   }
 };
+
+

mailnews/mailnews.js

@@ -525,3 +525,6 @@ pref("mail.compose.add_undisclosed_recipients", true);
 pref("mail.purge.min_delay",480);
 pref("mail.purge.timer_interval",5); 
 
+// to reduce forking in the js / C++
+// overridden by stand alone mail
+pref("mail.standalone", false);

modules/libpref/src/init/mailnews.js

@@ -525,3 +525,6 @@ pref("mail.compose.add_undisclosed_recipients", true);
 pref("mail.purge.min_delay",480);
 pref("mail.purge.timer_interval",5); 
 
+// to reduce forking in the js / C++
+// overridden by stand alone mail
+pref("mail.standalone", false);

xpfe/browser/resources/content/metadata.js

@@ -383,7 +383,7 @@ function openLink(node)
     // Security-Critical: Only links to 'safe' protocols should be functional.
     // Specifically, javascript: and data: URLs must be made non-functional
     // here, because they will run with full privilege.
-    var safeurls = /(^http(s)?:|^file:|^chrome:|^resource:|^mailbox:|^imap:|^news:|^about:|^mailto:|^ftp:|^gopher:)/i;
+    var safeurls = /(^http(s)?:|^file:|^chrome:|^resource:|^mailbox:|^imap:|^(s)?news:|^nntp:|^about:|^mailto:|^ftp:|^gopher:)/i;
     if (url.search(safeurls) == 0) {
         var secMan = Components.classes["@mozilla.org/scriptsecuritymanager;1"].getService().
                          QueryInterface(nsIScriptSecurityManager);

xpfe/communicator/resources/content/contentAreaUtils.js

@@ -102,6 +102,18 @@ function openNewWindowWith(url, sendReferrer)
   window.openDialog(getBrowserURL(), "_blank", "chrome,all,dialog=no", url, charsetArg, referrer);
 }
 
+function openTopBrowserWith(url)
+{
+  var windowMediator = Components.classes["@mozilla.org/appshell/window-mediator;1"].getService(Components.interfaces.nsIWindowMediator);
+  var browserWin = windowMediator.getMostRecentWindow("navigator:browser");
+
+  // if there's an existing browser window, open this url in one
+  if (browserWin)
+    browserWin.getBrowser().loadURI(url); // Just do a normal load.
+  else
+    window.openDialog(getBrowserURL(), "_blank", "chrome,all,dialog=no", url, null, null);
+}
+
 function openNewTabWith(url, sendReferrer, reverseBackgroundPref) 
 {
   var browser;