Replace 'data' with 'value' according to XUL 1.0 spec. b=75400, r=akkana, sr=sfraser

editor/ui/composer/content/editorOverlay.xul

@@ -249,7 +249,7 @@
 
     <command id="cmd_viewCompToolbar"     oncommand="goToggleToolbar('EditToolbar','cmd_viewCompToolbar');"         checked="true"/>
     <command id="cmd_viewFormatToolbar"   oncommand="goToggleToolbar('FormatToolbar','cmd_viewFormatToolbar');"     checked="true"/>
-    <command id="cmd_viewEditModeToolbar" oncommand="goToggleToolbar('EditModeToolbar','cmd_viewEditModeToolbar');" checked="false"/>
+    <command id="cmd_viewEditModeToolbar" oncommand="goToggleToolbar('EditModeToolbar','cmd_viewEditModeToolbar');" checked="true"/>
     <command id="cmd_viewtaskbar"         oncommand="goToggleToolbar('taskbar','cmd_viewtaskbar');"                 checked="true"/>
 
     <!-- Obsolete; these will go away -->
@@ -434,14 +434,14 @@
     <menuseparator position="8"/>
 
     <!-- Note: the 'Init' menu methods for Paragraph, List, and Align
-         assume that the id = 'menu_'+tagName (the 'data' label),
+         assume that the id = 'menu_'+tagName (the 'value' label),
          except for the first ('none') item
      -->
     <!-- Paragraph Style submenu -->
     <menu id="paragraphMenu" label="&paragraphMenu.label;"
           accesskey="&formatparagraphmenu.accesskey;"
           position="9" oncreate="InitParagraphMenu()">
-      <menupopup oncommand="doStatefulCommand('cmd_paragraphState', event.target.getAttribute('data'))">
+      <menupopup oncommand="doStatefulCommand('cmd_paragraphState', event.target.getAttribute('value'))">
         <menuitem id="menu_bodyText"  type="radio" name="1" label="&bodyTextCmd.label;"             accesskey="&bodytext.accesskey;"              value=""/>
         <menuitem id="menu_p"         type="radio" name="1" label="&paragraphParagraphCmd.label;"   accesskey="&paragraphparagraph.accesskey;"  value="p"/>
         <menuitem id="menu_h1"        type="radio" name="1" label="&heading1Cmd.label;"             accesskey="&heading1.accesskey;"            value="h1"/>
@@ -482,7 +482,7 @@
         oncreate="InitAlignMenu()"
         position="14">
       <!-- Align submenu -->
-      <menupopup oncommand="doStatefulCommand('cmd_align', event.target.getAttribute('data'))">
+      <menupopup oncommand="doStatefulCommand('cmd_align', event.target.getAttribute('value'))">
         <menuitem id="menu_left"    label="&alignLeft.label;"  accesskey="&alignleft.accesskey;"      type="radio" name="1" value="left"/>
         <menuitem id="menu_center"  label="&alignCenter.label;"  accesskey="&aligncenter.accesskey;"  type="radio" name="1" value="center"/>
         <menuitem id="menu_right"   label="&alignRight.label;"   accesskey="&alignright.accesskey;"   type="radio" name="1" value="right"/>

editor/ui/composer/content/pref-composer.js

@@ -76,8 +76,8 @@ function Startup()
   if (backgroundImage)
     dialog.BackgroundImageInput.value = backgroundImage;
 
-  // "data" attribute value is a string conversion of boolean!
+  // "value" attribute value is a string conversion of boolean!
-  if( document.getElementById( "useCustomColors" ).data == "true" )
+  if( document.getElementById( "useCustomColors" ).value == "true" )
     UseCustomColors();
   else
     UseDefaultColors();

editor/ui/dialogs/content/EditorSaveAsCharset.js

@@ -172,7 +172,7 @@ function LoadAvailableCharSets()
              if(row) {
                 var cell= row.firstChild;
                 if(cell) {
-                   cell.setAttribute("data", charsetDict[i][1]);
+                   cell.setAttribute("value", charsetDict[i][1]);
                 }
              }
              if(charset == charsetDict[i][1] ) 
@@ -203,7 +203,7 @@ function SelectCharset()
 {
   if(initDone) {
     try {
-      charset = GetSelectedTreelistAttribute(dialog.charsetTree, "data");
+      charset = GetSelectedTreelistAttribute(dialog.charsetTree, "value");
       //dump("charset = " + charset + "\n");
       if(charset != "") {
          charsetWasChanged = true;