From 307dbcfbea621788e31c2c2b7e6c542a8c1c4cee Mon Sep 17 00:00:00 2001 From: "nhotta%netscape.com" Date: Mon, 16 Sep 2002 17:41:48 +0000 Subject: [PATCH] Changed to call util function to unescape URI for status bar, bug 81024, r=ftang, sr=darin. --- docshell/base/nsWebShell.cpp | 46 ++++++++++++++---------------------- 1 file changed, 18 insertions(+), 28 deletions(-) diff --git a/docshell/base/nsWebShell.cpp b/docshell/base/nsWebShell.cpp index ff34d25d72b..042761bdb4e 100644 --- a/docshell/base/nsWebShell.cpp +++ b/docshell/base/nsWebShell.cpp @@ -674,35 +674,25 @@ nsWebShell::OnOverLink(nsIContent* aContent, nsCOMPtr textToSubURI = do_GetService(NS_ITEXTTOSUBURI_CONTRACTID, &rv); if (NS_FAILED(rv)) return rv; - PRUnichar *uStr; - nsString aSpec(aURLSpec); - PRInt32 pos = aSpec.FindChar(':'); - nsAutoString scheme; - static const char kMailToURI[] = "mailto"; - // If the scheme is mailtourl then should not convert from a document charset - if ((pos == (PRInt32)(sizeof kMailToURI - 1)) && (aSpec.Left(scheme, pos) != -1) && - scheme.EqualsIgnoreCase(kMailToURI)) { - // use UTF-8 instead and apply URL escape. - rv = textToSubURI->UnEscapeAndConvert("UTF-8",NS_ConvertUCS2toUTF8(aURLSpec).get(), &uStr); - } - else { - // use doc charset instead and apply URL escape. - nsCOMPtr presShell; - nsCOMPtr doc; - nsDocShell::GetPresShell(getter_AddRefs(presShell)); - NS_ENSURE_TRUE(presShell, NS_ERROR_FAILURE); - presShell->GetDocument(getter_AddRefs(doc)); - NS_ENSURE_TRUE(doc, NS_ERROR_FAILURE); - nsAutoString charset; - NS_ENSURE_SUCCESS(doc->GetDocumentCharacterSet(charset), NS_ERROR_FAILURE); - rv = textToSubURI->UnEscapeAndConvert(NS_ConvertUCS2toUTF8(charset.get()).get(), - NS_ConvertUCS2toUTF8(aURLSpec).get(), &uStr); - } + // use doc charset to unescape the URL + nsCOMPtr presShell; + nsDocShell::GetPresShell(getter_AddRefs(presShell)); + NS_ENSURE_TRUE(presShell, NS_ERROR_FAILURE); - if (NS_SUCCEEDED(rv)) { - rv = browserChrome->SetStatus(nsIWebBrowserChrome::STATUS_LINK, uStr); - nsMemory::Free(uStr); - } + nsCOMPtr doc; + presShell->GetDocument(getter_AddRefs(doc)); + NS_ENSURE_TRUE(doc, NS_ERROR_FAILURE); + + nsAutoString charset; + rv = doc->GetDocumentCharacterSet(charset); + NS_ENSURE_SUCCESS(rv, rv); + + nsAutoString uStr; + rv = textToSubURI->UnEscapeURIForUI(NS_LossyConvertUCS2toASCII(charset), + NS_ConvertUCS2toUTF8(aURLSpec), uStr); + + if (NS_SUCCEEDED(rv)) + rv = browserChrome->SetStatus(nsIWebBrowserChrome::STATUS_LINK, uStr.get()); } return rv; }