From 3606bb4b5a841ff117d8dd4948d7a098da344b6c Mon Sep 17 00:00:00 2001
From: Dan Witte <dwitte@mozilla.com>
Date: Mon, 13 Sep 2010 10:54:02 -0700
Subject: [PATCH] Bug 589413 - Failure to open libnss3.so when Firefox path
 contains UTF-8 characters. Part 3: tests. r=bent, a=final+

---
 .../components/ctypes/tests/test_ctypes.xul   | 27 ++++++++++++-
 .../ctypes/tests/unit/test_jsctypes.js.in     | 39 ++++++++++++++-----
 2 files changed, 55 insertions(+), 11 deletions(-)

diff --git a/toolkit/components/ctypes/tests/test_ctypes.xul b/toolkit/components/ctypes/tests/test_ctypes.xul
index b065986463c..db276f15203 100644
--- a/toolkit/components/ctypes/tests/test_ctypes.xul
+++ b/toolkit/components/ctypes/tests/test_ctypes.xul
@@ -51,6 +51,10 @@
 
   <script type="application/javascript">
   <![CDATA[
+    Components.utils.import("resource://gre/modules/ctypes.jsm");
+
+    CTYPES_TEST_LIB = ctypes.libraryName("jsctypes-test");
+    CTYPES_UNICODE_LIB = ctypes.libraryName("jsctyp\u00E8s-t\u00EB\u00DFt");
 
     /*
      * input: string of the url where we are running from
@@ -81,23 +85,42 @@
       return dir;    
     }
 
+    function setupLibs(path) {
+      let libFile = path.clone();
+      libFile.append(CTYPES_TEST_LIB);
+      ok(libFile.exists(), "ctypes test library doesn't exist!?");
+
+      libFile.copyTo(null, CTYPES_UNICODE_LIB);
+    }
+
+    function cleanupLibs(path) {
+      let unicodeFile = path.clone();
+      unicodeFile.append(CTYPES_UNICODE_LIB);
+      ok(unicodeFile.exists(), "ctypes unicode test library doesn't exist!?");
+      unicodeFile.remove(false);
+    }
+
     function test()
     {
       SimpleTest.waitForExplicitFinish();
 
+      var dir = getCurrentDir(location.path);
+      ok(dir.exists() && dir.isDirectory(), "Chrome test dir doesn't exist?!");
+      setupLibs(dir);
+
       var worker = new ChromeWorker("ctypes_worker.js");
       worker.onmessage = function(event) {
         is(event.data, "Done!", "Wrong message!");
+        cleanupLibs(dir);
         SimpleTest.finish();
       }
       worker.onerror = function(event) {
         ok(false, "Worker had an error: " + event.message);
         worker.terminate();
+        cleanupLibs(dir);
         SimpleTest.finish();
       }
 
-      var dir = getCurrentDir(location.path);
-      ok(dir.exists() && dir.isDirectory(), "Chrome test dir doesn't exist?!");
       worker.postMessage(dir.path);
     }
 
diff --git a/toolkit/components/ctypes/tests/unit/test_jsctypes.js.in b/toolkit/components/ctypes/tests/unit/test_jsctypes.js.in
index 7b3317b0b27..bb278747be5 100644
--- a/toolkit/components/ctypes/tests/unit/test_jsctypes.js.in
+++ b/toolkit/components/ctypes/tests/unit/test_jsctypes.js.in
@@ -38,12 +38,15 @@
  *
  * ***** END LICENSE BLOCK ***** */
 
-Components.utils.import("resource://gre/modules/ctypes.jsm");
-
-const Cc = Components.classes;
-const Ci = Components.interfaces;
+try {
+  // We might be running without privileges, in which case it's up to the
+  // harness to give us the 'ctypes' object.
+  Components.utils.import("resource://gre/modules/ctypes.jsm");
+} catch(e) {
+}
 
 CTYPES_TEST_LIB = ctypes.libraryName("jsctypes-test");
+CTYPES_UNICODE_LIB = ctypes.libraryName("jsctyp\u00E8s-t\u00EB\u00DFt");
 
 function getParent(obj, fun)
 {
@@ -59,8 +62,13 @@ function checkParentIsCTypes(o)
 
 function do_check_throws(f, type, stack)
 {
-  if (!stack)
-    stack = Components.stack.caller;
+  if (!stack) {
+    try {
+      // We might not have a 'Components' object.
+      stack = Components.stack.caller;
+    } catch (e) {
+    }
+  }
 
   try {
     f();
@@ -88,8 +96,8 @@ function run_test()
   run_abstract_class_tests();
 
   // open the library
-  let libfile = do_get_file(CTYPES_TEST_LIB).path;
-  let library = ctypes.open(libfile);
+  let libfile = do_get_file(CTYPES_TEST_LIB);
+  let library = ctypes.open(libfile.path);
 
   // Make sure we can call a function in the library.
   run_void_tests(library);
@@ -215,7 +223,7 @@ function run_test()
   }, Error);
 
   // test that library functions throw when bound to other objects
-  library = ctypes.open(libfile);
+  library = ctypes.open(libfile.path);
   let obj = {};
   obj.declare = library.declare;
   do_check_throws(function () { run_void_tests(obj); }, Error);
@@ -233,6 +241,19 @@ function run_test()
 
   // bug 522360
   do_check_eq(run_load_system_library(), true);
+
+  // Test loading a library with a unicode name (bug 589413). Note that nsIFile
+  // implementations are not available in some harnesses; if not, the harness
+  // should take care of the copy for us.
+  let unicodefile = do_get_file(CTYPES_UNICODE_LIB, true);
+  let copy = libfile.copyTo instanceof Function;
+  if (copy)
+    libfile.copyTo(null, unicodefile.leafName);
+  library = ctypes.open(unicodefile.path);
+  run_void_tests(library);
+  library.close();
+  if (copy)
+    unicodefile.remove(false);
 }
 
 function run_abstract_class_tests()