зеркало из https://github.com/mozilla/pjs.git
Fix for bug 72184: prevents users from entering too-large comments/descriptions that get rejected by MySQL's MAX_PACKET_SIZE restrictions.
Patch by Myk Melez <myk@mozilla.org>. r=bbaetz,gerv
This commit is contained in:
Родитель
9a9a1d9386
Коммит
391c90292b
|
@ -324,6 +324,19 @@ sub ValidateBugID {
|
|||
|
||||
}
|
||||
|
||||
|
||||
sub ValidateComment {
|
||||
# Make sure a comment is not too large (greater than 64K).
|
||||
|
||||
my ($comment) = @_;
|
||||
|
||||
if (defined($comment) && length($comment) > 65535) {
|
||||
DisplayError("Comments cannot be longer than 65,535 characters.");
|
||||
exit;
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
# check and see if a given string actually represents a positive
|
||||
# integer, and abort if not.
|
||||
#
|
||||
|
|
|
@ -77,6 +77,7 @@ elsif ($action eq "insert")
|
|||
{
|
||||
confirm_login();
|
||||
ValidateBugID($::FORM{'bugid'});
|
||||
ValidateComment($::FORM{'comment'});
|
||||
validateFilename();
|
||||
validateData();
|
||||
validateDescription();
|
||||
|
@ -95,6 +96,7 @@ elsif ($action eq "edit")
|
|||
elsif ($action eq "update")
|
||||
{
|
||||
confirm_login();
|
||||
ValidateComment($::FORM{'comment'});
|
||||
validateID();
|
||||
validateCanEdit($::FORM{'id'});
|
||||
validateDescription();
|
||||
|
|
|
@ -49,6 +49,8 @@ sub sillyness {
|
|||
|
||||
confirm_login();
|
||||
|
||||
ValidateComment($::FORM{'comment'});
|
||||
|
||||
my $cookiepath = Param("cookiepath");
|
||||
print "Set-Cookie: PLATFORM=$::FORM{'product'} ; path=$cookiepath ; expires=Sun, 30-Jun-2029 00:00:00 GMT\n" if ( exists $::FORM{'product'} );
|
||||
print "Set-Cookie: VERSION-$::FORM{'product'}=$::FORM{'version'} ; path=$cookiepath ; expires=Sun, 30-Jun-2029 00:00:00 GMT\n" if ( exists $::FORM{'product'} && exists $::FORM{'version'} );
|
||||
|
|
|
@ -92,6 +92,8 @@ if (defined $::FORM{'dup_id'} && $::FORM{'knob'} eq "duplicate") {
|
|||
DuplicateUserConfirm();
|
||||
}
|
||||
|
||||
ValidateComment($::FORM{'comment'});
|
||||
|
||||
######################################################################
|
||||
# End Data/Security Validation
|
||||
######################################################################
|
||||
|
|
Загрузка…
Ссылка в новой задаче